Skip to content

Commit 071e99e

Browse files
adhorodyskiclaude
andcommitted
Restructure reviewer checklist: add Process & Documentation section
Reorganize reviewer checklist items to improve clarity by grouping related items under dedicated sections. This commit adds the "Process & Documentation" section and consolidates all process-related checklist items including author checklist verification, issue linking, guideline compliance, and final review completion. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 886acde commit 071e99e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

contributingGuides/REVIEWER_CHECKLIST.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
## Reviewer Checklist
22

3+
### Process & Documentation
34
- [ ] I have verified the author checklist is complete (all boxes are checked off).
45
- [ ] I verified the correct issue is linked in the `### Fixed Issues` section above
6+
- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md)
7+
- [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.
8+
- [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
59
- [ ] I verified testing steps are clear and they cover the changes made in this PR
610
- [ ] I verified the steps for local testing are in the `Tests` section
711
- [ ] I verified the steps for Staging and/or Production testing are in the `QA steps` section
@@ -29,7 +33,6 @@
2933
- [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
3034
- [ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#jsdocs)) were followed
3135
- [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
32-
- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md)
3336
- [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again)
3437
- [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
3538
- [ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
@@ -57,8 +60,6 @@
5760
- [ ] I added `Design` label and/or tagged `@Expensify/design` so the design team can review the changes.
5861
- [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page.
5962
- [ ] For any bug fix or new feature in this PR, I verified that sufficient [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) are included to prevent regressions in this flow.
60-
- [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.
61-
- [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
6263

6364
### Screenshots/Videos
6465
<details>

0 commit comments

Comments
 (0)