Skip to content

Commit 085af72

Browse files
adhorodyskiclaude
andcommitted
Add Testing & Verification section to reviewer checklist
Group all testing-related checklist items under a dedicated section including test steps verification, platform testing, offline testing, screenshot requirements, and unit test coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 071e99e commit 085af72

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

contributingGuides/REVIEWER_CHECKLIST.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,23 @@
66
- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md)
77
- [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.
88
- [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
9+
10+
### Testing & Verification
911
- [ ] I verified testing steps are clear and they cover the changes made in this PR
1012
- [ ] I verified the steps for local testing are in the `Tests` section
1113
- [ ] I verified the steps for Staging and/or Production testing are in the `QA steps` section
1214
- [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
1315
- [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
1416
- [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
1517
- [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
16-
- [ ] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
1718
- [ ] I verified tests pass on **all platforms** & I tested again on:
1819
- [ ] Android: HybridApp
1920
- [ ] Android: mWeb Chrome
2021
- [ ] iOS: HybridApp
2122
- [ ] iOS: mWeb Safari
2223
- [ ] MacOS: Chrome / Safari
2324
- [ ] MacOS: Desktop
25+
- [ ] For any bug fix or new feature in this PR, I verified that sufficient [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) are included to prevent regressions in this flow.
2426
- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
2527
- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx`
2628
- [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
@@ -59,7 +61,7 @@
5961
- [ ] I verified that all the inputs inside a form are aligned with each other.
6062
- [ ] I added `Design` label and/or tagged `@Expensify/design` so the design team can review the changes.
6163
- [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page.
62-
- [ ] For any bug fix or new feature in this PR, I verified that sufficient [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) are included to prevent regressions in this flow.
64+
- [ ] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
6365

6466
### Screenshots/Videos
6567
<details>

0 commit comments

Comments
 (0)