fix: remove unnecessary code

annaweber830 · annaweber830 · commit 0ba83aeb455f · 2026-04-01T03:14:28.000-07:00
diff --git a/src/languages/de.ts b/src/languages/de.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5631,7 +5630,6 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
             reportFieldNameRequiredError: 'Bitte gib einen Berichtsfeldnamen ein',
             reportFieldTypeRequiredError: 'Bitte wähle einen Berichtsfeldtyp aus',
             circularReferenceError: 'Dieses Feld kann nicht auf sich selbst verweisen. Bitte aktualisieren.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Nicht unterstützte Formel-Token(s): ${value}. Verwende unterstützte Token wie {report:id}.`,
             reportFieldInitialValueRequiredError: 'Bitte wähle einen Anfangswert für ein Berichtsfeld aus',
             genericFailureMessage: 'Beim Aktualisieren des Berichtfelds ist ein Fehler aufgetreten. Bitte versuche es erneut.',
         },
diff --git a/src/languages/en.ts b/src/languages/en.ts
@@ -46,7 +46,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5637,7 +5636,6 @@ const translations = {
             reportFieldNameRequiredError: 'Please enter a report field name',
             reportFieldTypeRequiredError: 'Please choose a report field type',
             circularReferenceError: "This field can't refer to itself. Please update.",
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Unsupported formula token(s): ${value}. Use supported tokens such as {report:id}.`,
             reportFieldInitialValueRequiredError: 'Please choose a report field initial value',
             genericFailureMessage: 'An error occurred while updating the report field. Please try again.',
         },
diff --git a/src/languages/es.ts b/src/languages/es.ts
@@ -9,7 +9,6 @@ import type {
     MultifactorAuthenticationTranslationParams,
     NextStepParams,
     PaidElsewhereParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedPolicyTagParams,
     ViolationsRterParams,
 } from './params';
@@ -5526,7 +5525,6 @@ ${amount} para ${merchant} - ${date}`,
             reportFieldNameRequiredError: 'Ingresa un nombre de campo de informe',
             reportFieldTypeRequiredError: 'Elige un tipo de campo de informe',
             circularReferenceError: 'Este campo no puede hacer referencia a sí mismo. Por favor, actualizar.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Token(s) de fórmula no admitido(s): ${value}. Usa tokens admitidos como {report:id}.`,
             reportFieldInitialValueRequiredError: 'Elige un valor inicial de campo de informe',
             genericFailureMessage: 'Se ha producido un error al actualizar el campo de informe. Por favor, inténtalo de nuevo.',
         },
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5652,8 +5651,6 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
             reportFieldNameRequiredError: 'Veuillez saisir un nom de champ de note de frais',
             reportFieldTypeRequiredError: 'Veuillez choisir un type de champ de note de frais',
             circularReferenceError: 'Ce champ ne peut pas faire référence à lui-même. Veuillez le mettre à jour.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) =>
-                `Jeton(s) de formule non pris en charge : ${value}. Utilisez des jetons pris en charge comme {report:id}.`,
             reportFieldInitialValueRequiredError: 'Veuillez choisir une valeur initiale pour le champ de note de frais',
             genericFailureMessage: 'Une erreur s’est produite lors de la mise à jour du champ de note de frais. Veuillez réessayer.',
         },
diff --git a/src/languages/it.ts b/src/languages/it.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5621,7 +5620,6 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
             reportFieldNameRequiredError: 'Inserisci un nome per il campo del report',
             reportFieldTypeRequiredError: 'Scegli un tipo di campo del report',
             circularReferenceError: 'Questo campo non può fare riferimento a se stesso. Aggiorna per favore.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Token di formula non supportati: ${value}. Usa token supportati come {report:id}.`,
             reportFieldInitialValueRequiredError: 'Scegli un valore iniziale per il campo del resoconto',
             genericFailureMessage: 'Si è verificato un errore durante l’aggiornamento del campo del report. Riprova.',
         },
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5556,8 +5555,6 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
             reportFieldNameRequiredError: 'レポート項目名を入力してください',
             reportFieldTypeRequiredError: 'レポートフィールドの種類を選択してください',
             circularReferenceError: 'このフィールドを自分自身に参照することはできません。更新してください。',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) =>
-                `サポートされていない数式トークン: ${value}。{report:id}などのサポートされているトークンを使用してください。`,
             reportFieldInitialValueRequiredError: 'レポート項目の初期値を選択してください',
             genericFailureMessage: 'レポートフィールドの更新中にエラーが発生しました。もう一度お試しください。',
         },
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5602,7 +5601,6 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
             reportFieldNameRequiredError: 'Voer een naam voor een rapportveld in',
             reportFieldTypeRequiredError: 'Kies een veldtype voor het rapport',
             circularReferenceError: 'Dit veld kan niet naar zichzelf verwijzen. Werk het alsjeblieft bij.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Niet-ondersteunde formule-token(s): ${value}. Gebruik ondersteunde tokens zoals {report:id}.`,
             reportFieldInitialValueRequiredError: 'Kies een beginwaarde voor een rapportveld',
             genericFailureMessage: 'Er is een fout opgetreden bij het bijwerken van het rapportveld. Probeer het opnieuw.',
         },
diff --git a/src/languages/params.ts b/src/languages/params.ts
@@ -209,10 +209,6 @@ type MarkReimbursedFromIntegrationParams = {amount: string; currency: string};
 
 type ShareParams = {to: string};
 
-type UnsupportedFormulaValueErrorParams = {
-    value: string;
-};
-
 type UnshareParams = {to: string};
 
 type ConnectionNameParams = {
@@ -341,7 +337,6 @@ export type {
     MarkReimbursedFromIntegrationParams,
     ShareParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     ConnectionNameParams,
     ExportAgainModalDescriptionParams,
     UpdateRoleParams,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5596,7 +5595,6 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
             reportFieldNameRequiredError: 'Wprowadź nazwę pola raportu',
             reportFieldTypeRequiredError: 'Wybierz typ pola raportu',
             circularReferenceError: 'To pole nie może odnosić się do siebie. Zaktualizuj je.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Nieobsługiwane tokeny formuły: ${value}. Użyj obsługiwanych tokenów, np. {report:id}.`,
             reportFieldInitialValueRequiredError: 'Wybierz początkową wartość pola raportu',
             genericFailureMessage: 'Wystąpił błąd podczas aktualizowania pola raportu. Spróbuj ponownie.',
         },
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5601,7 +5600,6 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
             reportFieldNameRequiredError: 'Insira um nome de campo de relatório',
             reportFieldTypeRequiredError: 'Escolha um tipo de campo de relatório',
             circularReferenceError: 'Este campo não pode fazer referência a si mesmo. Atualize, por favor.',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Token(s) de fórmula não suportado(s): ${value}. Use tokens suportados como {report:id}.`,
             reportFieldInitialValueRequiredError: 'Escolha um valor inicial para o campo de relatório',
             genericFailureMessage: 'Ocorreu um erro ao atualizar o campo do relatório. Tente novamente.',
         },
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
@@ -58,7 +58,6 @@ import type {
     StepCounterParams,
     SyncStageNameConnectionsParams,
     UnshareParams,
-    UnsupportedFormulaValueErrorParams,
     UpdatedBudgetParams,
     UpdatedPolicyApprovalRuleParams,
     UpdatedPolicyBudgetNotificationParams,
@@ -5463,7 +5462,6 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
             reportFieldNameRequiredError: '请输入报表字段名称',
             reportFieldTypeRequiredError: '请选择报表字段类型',
             circularReferenceError: '此字段不能引用自身。请更新。',
-            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `不支持的公式标记：${value}。请使用支持的标记，例如 {report:id}。`,
             reportFieldInitialValueRequiredError: '请选择报表字段的初始值',
             genericFailureMessage: '更新报表字段时出错。请重试。',
         },
diff --git a/src/libs/WorkspaceReportFieldUtils.ts b/src/libs/WorkspaceReportFieldUtils.ts
@@ -109,103 +109,12 @@ function isReportFieldNameExisting(fieldList: Record<string, PolicyReportField>
     return Object.values(fieldList ?? {}).some((reportField) => reportField.name.toLowerCase() === fieldName.toLowerCase());
 }
 
-type FormulaParsePart = {
-    definition: string;
-    type: string;
-    fieldPath: string[];
-    functions: string[];
-};
-
-/**
- * Returns the list of unsupported {report:*} formula parts in the initial value.
- * Used to validate formula report fields so unsupported tokens (e.g. {report:i}) are rejected with a clear error.
- */
-function getUnsupportedReportFieldFormulaParts(initialValue?: string): string[] {
-    if (!initialValue || typeof initialValue !== 'string') {
-        return [];
-    }
-
-    // Dynamically require to avoid circular dependency with ReportActionsUtils
-    const {parse, FORMULA_PART_TYPES} = require('./Formula') as {
-        parse: (formula?: string) => FormulaParsePart[];
-        FORMULA_PART_TYPES: {REPORT: string};
-    };
-
-    const supportedReportFields = new Set([
-        'id',
-        'status',
-        'expensescount',
-        'type',
-        'startdate',
-        'enddate',
-        'total',
-        'reimbursable',
-        'currency',
-        'policyname',
-        'workspacename',
-        'created',
-        'submit',
-        'autoreporting',
-    ]);
-
-    const supportedSubmitDirections = new Set(['from', 'to', 'date']);
-    const supportedSubmitPersonFields = new Set(['firstname', 'lastname', 'fullname', 'email', 'userid', 'customfield1', 'payrollid', 'customfield2']);
-    const supportedAutoReportingFields = new Set(['start', 'end']);
-
-    const unsupported: string[] = [];
-    const parts = parse(initialValue);
-
-    for (const part of parts) {
-        if (part.type !== FORMULA_PART_TYPES.REPORT) {
-            continue;
-        }
-
-        const [field, ...rest] = part.fieldPath ?? [];
-        const normalizedField = field?.trim().toLowerCase();
-
-        if (!normalizedField || !supportedReportFields.has(normalizedField)) {
-            unsupported.push(part.definition);
-            continue;
-        }
-
-        if (normalizedField === 'submit') {
-            const direction = rest.at(0)?.trim().toLowerCase();
-            if (!direction || !supportedSubmitDirections.has(direction)) {
-                unsupported.push(part.definition);
-                continue;
-            }
-
-            // report:submit:date is valid (format is optional and validated elsewhere)
-            if (direction === 'date') {
-                continue;
-            }
-
-            // report:submit:from:* and report:submit:to:* need a subfield
-            const submitField = rest.at(1)?.trim().toLowerCase();
-            if (!submitField || !supportedSubmitPersonFields.has(submitField)) {
-                unsupported.push(part.definition);
-            }
-            continue;
-        }
-
-        if (normalizedField === 'autoreporting') {
-            const subField = rest.at(0)?.trim().toLowerCase();
-            if (!subField || !supportedAutoReportingFields.has(subField)) {
-                unsupported.push(part.definition);
-            }
-        }
-    }
-
-    return unsupported;
-}
-
 export {
     getReportFieldTypeTranslationKey,
     getReportFieldAlternativeTextTranslationKey,
     validateReportFieldListValueName,
     generateFieldID,
     getReportFieldInitialValue,
-    getUnsupportedReportFieldFormulaParts,
     hasFormulaPartsInInitialValue,
     isReportFieldNameExisting,
 };
diff --git a/src/pages/workspace/reports/CreateReportFieldsPage.tsx b/src/pages/workspace/reports/CreateReportFieldsPage.tsx
@@ -18,7 +18,7 @@ import Navigation from '@libs/Navigation/Navigation';
 import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
 import {hasAccountingConnections} from '@libs/PolicyUtils';
 import {isRequiredFulfilled} from '@libs/ValidationUtils';
-import {getUnsupportedReportFieldFormulaParts, hasFormulaPartsInInitialValue, isReportFieldNameExisting} from '@libs/WorkspaceReportFieldUtils';
+import {hasFormulaPartsInInitialValue, isReportFieldNameExisting} from '@libs/WorkspaceReportFieldUtils';
 import type {SettingsNavigatorParamList} from '@navigation/types';
 import AccessOrNotFoundWrapper from '@pages/workspace/AccessOrNotFoundWrapper';
 import type {WithPolicyAndFullscreenLoadingProps} from '@pages/workspace/withPolicyAndFullscreenLoading';
@@ -106,15 +106,6 @@ function WorkspaceCreateReportFieldsPage({
                 errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.circularReferenceError');
             }
 
-            if ((type === CONST.REPORT_FIELD_TYPES.TEXT || type === CONST.REPORT_FIELD_TYPES.FORMULA) && !!formInitialValue && !errors[INPUT_IDS.INITIAL_VALUE]) {
-                const unsupportedFormulaParts = getUnsupportedReportFieldFormulaParts(formInitialValue);
-                if (unsupportedFormulaParts.length > 0) {
-                    errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.unsupportedFormulaValueError', {
-                        value: unsupportedFormulaParts.join(', '),
-                    });
-                }
-            }
-
             if (type === CONST.REPORT_FIELD_TYPES.LIST && availableListValuesLength > 0 && !isRequiredFulfilled(formInitialValue)) {
                 errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.reportFieldInitialValueRequiredError');
             }
diff --git a/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx b/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx
@@ -16,7 +16,7 @@ import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavig
 import type {SettingsNavigatorParamList} from '@libs/Navigation/types';
 import {getReportFieldKey} from '@libs/ReportUtils';
 import {isRequiredFulfilled} from '@libs/ValidationUtils';
-import {getReportFieldInitialValue, getUnsupportedReportFieldFormulaParts} from '@libs/WorkspaceReportFieldUtils';
+import {getReportFieldInitialValue} from '@libs/WorkspaceReportFieldUtils';
 import NotFoundPage from '@pages/ErrorPage/NotFoundPage';
 import AccessOrNotFoundWrapper from '@pages/workspace/AccessOrNotFoundWrapper';
 import type {WithPolicyAndFullscreenLoadingProps} from '@pages/workspace/withPolicyAndFullscreenLoading';
@@ -76,15 +76,6 @@ function ReportFieldsInitialValuePage({
                 errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.circularReferenceError');
             }
 
-            if ((reportField?.type === CONST.REPORT_FIELD_TYPES.TEXT || reportField?.type === CONST.REPORT_FIELD_TYPES.FORMULA) && !!formInitialValue && !errors[INPUT_IDS.INITIAL_VALUE]) {
-                const unsupportedFormulaParts = getUnsupportedReportFieldFormulaParts(formInitialValue);
-                if (unsupportedFormulaParts.length > 0) {
-                    errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.unsupportedFormulaValueError', {
-                        value: unsupportedFormulaParts.join(', '),
-                    });
-                }
-            }
-
             if (reportField?.type === CONST.REPORT_FIELD_TYPES.LIST && availableListValuesLength > 0 && !isRequiredFulfilled(formInitialValue)) {
                 errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.reportFieldInitialValueRequiredError');
             }
