Skip to content

Commit 0ba8548

Browse files
committed
Split expense total is showing 0 incorrectly in preview
1 parent 94658ba commit 0ba8548

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

src/libs/TransactionPreviewUtils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import type {TransactionDetails} from './ReportUtils';
1616
import StringUtils from './StringUtils';
1717
import {
1818
compareDuplicateTransactionFields,
19+
getAmount,
1920
getFormattedCreated,
2021
getOriginalTransactionWithSplitInfo,
2122
hasMissingSmartscanFields,
@@ -253,7 +254,7 @@ function getTransactionPreviewTextAndTranslationPaths({
253254
}
254255
}
255256

256-
const amount = isBillSplit ? getOriginalTransactionWithSplitInfo(transaction).originalTransaction?.amount : requestAmount;
257+
const amount = isBillSplit ? getAmount(getOriginalTransactionWithSplitInfo(transaction).originalTransaction) : requestAmount;
257258
let displayAmountText: TranslationPathOrText = isTransactionScanning ? {translationPath: 'iou.receiptStatusTitle'} : {text: convertToDisplayString(amount, requestCurrency)};
258259
if (isFetchingWaypoints && !requestAmount) {
259260
displayAmountText = {translationPath: 'iou.fieldPending'};

tests/unit/TransactionPreviewUtils.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,18 @@ describe('TransactionPreviewUtils', () => {
132132

133133
expect(result.previewHeaderText).toContainEqual({translationPath: 'iou.approved'});
134134
});
135+
136+
it('should display the correct amount for a bill split transaction', () => {
137+
const functionArgs = {...basicProps, isBillSplit: true};
138+
const result = getTransactionPreviewTextAndTranslationPaths(functionArgs);
139+
expect(result.displayAmountText.text).toEqual('$1.00');
140+
});
141+
142+
it('should display the correct amount for a bill split transaction after updating the amount', () => {
143+
const functionArgs = {...basicProps, isBillSplit: true, transaction: {...basicProps.transaction, modifiedAmount: 50}};
144+
const result = getTransactionPreviewTextAndTranslationPaths(functionArgs);
145+
expect(result.displayAmountText.text).toEqual('$0.50');
146+
});
135147
});
136148

137149
describe('createTransactionPreviewConditionals', () => {

0 commit comments

Comments
 (0)