Skip to content

Commit 0bb5561

Browse files
grgiaclaude
andcommitted
Rename UpdateMergeHRFinalApprover to UpdateMergeFinalApprover
Aligns the FE constant, parameter file/type, and call site with the BE command name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 84fa90f commit 0bb5561

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/libs/API/parameters/UpdateMergeHRFinalApproverParams.ts renamed to src/libs/API/parameters/UpdateMergeFinalApproverParams.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
type UpdateMergeHRFinalApproverParams = {
1+
type UpdateMergeFinalApproverParams = {
22
/** The ID of the policy to update */
33
policyID: string;
44

55
/** Login of the member who will act as the final approver, or null to clear */
66
finalApprover: string | null;
77
};
88

9-
export default UpdateMergeHRFinalApproverParams;
9+
export default UpdateMergeFinalApproverParams;

src/libs/API/parameters/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ export type {default as EnablePolicyExpensifyCardsParams} from './EnablePolicyEx
258258
export type {default as UpdateGustoApprovalModeParams} from './UpdateGustoApprovalModeParams';
259259
export type {default as UpdateGustoFinalApproverParams} from './UpdateGustoFinalApproverParams';
260260
export type {default as UpdateMergeApprovalModeParams} from './UpdateMergeApprovalModeParams';
261-
export type {default as UpdateMergeHRFinalApproverParams} from './UpdateMergeHRFinalApproverParams';
261+
export type {default as UpdateMergeFinalApproverParams} from './UpdateMergeFinalApproverParams';
262262
export type {default as UpdateZenefitsApprovalModeParams} from './UpdateZenefitsApprovalModeParams';
263263
export type {default as UpdateZenefitsFinalApproverParams} from './UpdateZenefitsFinalApproverParams';
264264
export type {default as AcceptJoinRequestParams} from './AcceptJoinRequest';

src/libs/API/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ const WRITE_COMMANDS = {
389389
UPDATE_GUSTO_APPROVAL_MODE: 'UpdateGustoApprovalMode',
390390
UPDATE_GUSTO_FINAL_APPROVER: 'UpdateGustoFinalApprover',
391391
UPDATE_MERGE_APPROVAL_MODE: 'UpdateMergeApprovalMode',
392-
UPDATE_MERGE_HR_FINAL_APPROVER: 'UpdateMergeHRFinalApprover',
392+
UPDATE_MERGE_FINAL_APPROVER: 'UpdateMergeFinalApprover',
393393
SYNC_POLICY_TO_MERGE: 'SyncPolicyToMerge',
394394
UPDATE_ZENEFITS_APPROVAL_MODE: 'UpdateZenefitsApprovalMode',
395395
UPDATE_ZENEFITS_FINAL_APPROVER: 'UpdateZenefitsFinalApprover',
@@ -1022,7 +1022,7 @@ type WriteCommandParameters = {
10221022
[WRITE_COMMANDS.UPDATE_GUSTO_APPROVAL_MODE]: Parameters.UpdateGustoApprovalModeParams;
10231023
[WRITE_COMMANDS.UPDATE_GUSTO_FINAL_APPROVER]: Parameters.UpdateGustoFinalApproverParams;
10241024
[WRITE_COMMANDS.UPDATE_MERGE_APPROVAL_MODE]: Parameters.UpdateMergeApprovalModeParams;
1025-
[WRITE_COMMANDS.UPDATE_MERGE_HR_FINAL_APPROVER]: Parameters.UpdateMergeHRFinalApproverParams;
1025+
[WRITE_COMMANDS.UPDATE_MERGE_FINAL_APPROVER]: Parameters.UpdateMergeFinalApproverParams;
10261026
[WRITE_COMMANDS.SYNC_POLICY_TO_MERGE]: Parameters.SyncPolicyToMergeParams;
10271027
[WRITE_COMMANDS.UPDATE_ZENEFITS_APPROVAL_MODE]: Parameters.UpdateZenefitsApprovalModeParams;
10281028
[WRITE_COMMANDS.UPDATE_ZENEFITS_FINAL_APPROVER]: Parameters.UpdateZenefitsFinalApproverParams;

src/libs/actions/connections/MergeHR.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ function updateMergeHRFinalApprover(policyID: string, finalApprover: string | nu
175175
];
176176

177177
write(
178-
WRITE_COMMANDS.UPDATE_MERGE_HR_FINAL_APPROVER,
178+
WRITE_COMMANDS.UPDATE_MERGE_FINAL_APPROVER,
179179
{
180180
policyID,
181181
finalApprover,

0 commit comments

Comments
 (0)