Merge pull request Expensify#90376 from Expensify/dangrous-revert88752

Revert Expensify#88752

Author: Beamanator

src/libs/SearchUIUtils.ts

@@ -4419,7 +4419,7 @@ function createTypeMenuSections(params: TypeMenuSectionsParams): SearchTypeMenuS
 
         const insightsSearchKeys = [
             CONST.SEARCH.SEARCH_KEYS.SPEND_OVER_TIME,
-            CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS,
+            ...(!isTrackIntentUser ? [CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS] : []),
             CONST.SEARCH.SEARCH_KEYS.TOP_CATEGORIES,
             CONST.SEARCH.SEARCH_KEYS.TOP_MERCHANTS,
         ];

tests/unit/Search/SearchUIUtilsTest.ts

@@ -7045,50 +7045,6 @@ describe('SearchUIUtils', () => {
             expect(allKeys).not.toContain(CONST.SEARCH.SEARCH_KEYS.EXPORT);
         });
 
-        it('should show top spenders for track-intent users on eligible paid workspace', () => {
-            const mockPolicies = {
-                policy1: {
-                    id: 'policy1',
-                    name: 'Test Policy',
-                    owner: adminEmail,
-                    outputCurrency: 'USD',
-                    isPolicyExpenseChatEnabled: true,
-                    role: CONST.POLICY.ROLE.ADMIN,
-                    type: CONST.POLICY.TYPE.TEAM,
-                    employeeList: {
-                        [adminEmail]: {
-                            email: adminEmail,
-                            role: CONST.POLICY.ROLE.ADMIN,
-                            submitsTo: approverEmail,
-                        },
-                        [approverEmail]: {
-                            email: approverEmail,
-                            role: CONST.POLICY.ROLE.USER,
-                            submitsTo: adminEmail,
-                        },
-                    },
-                },
-            };
-
-            const sections = SearchUIUtils.createTypeMenuSections({
-                currentUserEmail: adminEmail,
-                currentUserAccountID: adminAccountID,
-                cardFeedsByPolicy: {},
-                defaultCardFeed: undefined,
-                policies: mockPolicies,
-                savedSearches: {},
-                isOffline: false,
-                defaultExpensifyCard: undefined,
-                draftTransactionIDs: [],
-                isTrackIntentUser: true,
-            });
-
-            const allMenuItems = sections.flatMap((section) => section.menuItems);
-            const allKeys = allMenuItems.map((item) => item.key);
-
-            expect(allKeys).toContain(CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS);
-        });
-
         it('should generate correct routes', () => {
             const menuItems = SearchUIUtils.createTypeMenuSections({
                 currentUserEmail: undefined,