Decode tag in TagCell so tag column matches group-by-tag dropdown

Addresses review feedback on PR Expensify#85603:

- cead22: tag column showed raw HTML-encoded value (e.g. `uno & dos`)
  while the group-by-tag dropdown decoded it. TagCell now decodes the
  display value, mirroring how CategoryCell already handles categories.

- github-actions CONSISTENCY-3: extract `getDecodedTagName` into TagUtils
  (mirroring `getDecodedCategoryName` in CategoryUtils) and use it from
  ReportLayoutUtils instead of importing `Str` directly. Keeps the tag /
  category decoding pattern symmetric across the codebase.

Adds unit tests for `getDecodedTagName`.

Author: abzokhattab

src/components/TransactionItemRow/DataCells/TagCell.tsx

@@ -3,23 +3,28 @@ import TextWithIconCell from '@components/Search/SearchList/ListItem/TextWithIco
 import TextWithTooltip from '@components/TextWithTooltip';
 import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
 import useThemeStyles from '@hooks/useThemeStyles';
+import {getDecodedTagName} from '@libs/TagUtils';
 import {getTagForDisplay} from '@libs/TransactionUtils';
 import type TransactionDataCellProps from './TransactionDataCellProps';
 
 function TagCell({shouldUseNarrowLayout, shouldShowTooltip, transactionItem}: TransactionDataCellProps) {
     const icons = useMemoizedLazyExpensifyIcons(['Tag']);
     const styles = useThemeStyles();
+    // Decode HTML entities so tags stored with encoding (e.g. `uno & dos`) display as `uno & dos`,
+    // matching the report's group-by-tag dropdown which already decodes the value.
+    const tagForDisplay = getDecodedTagName(getTagForDisplay(transactionItem));
+
     return shouldUseNarrowLayout ? (
         <TextWithIconCell
             icon={icons.Tag}
             showTooltip={shouldShowTooltip}
-            text={getTagForDisplay(transactionItem)}
+            text={tagForDisplay}
             textStyle={[styles.textMicro, styles.mnh0]}
         />
     ) : (
         <TextWithTooltip
             shouldShowTooltip={shouldShowTooltip}
-            text={getTagForDisplay(transactionItem)}
+            text={tagForDisplay}
             numberOfLines={1}
             style={[styles.lineHeightLarge, styles.justifyContentCenter]}
         />

src/libs/ReportLayoutUtils.ts

@@ -1,11 +1,10 @@
-import {Str} from 'expensify-common';
 import type {OnyxEntry} from 'react-native-onyx';
 import type {LocaleContextProps} from '@components/LocaleContextProvider';
 import type {GroupedTransactions} from '@src/types/onyx';
 import type Report from '@src/types/onyx/Report';
 import type Transaction from '@src/types/onyx/Transaction';
 import {getDecodedCategoryName, isCategoryMissing} from './CategoryUtils';
-import {isTagMissing} from './TagUtils';
+import {getDecodedTagName, isTagMissing} from './TagUtils';
 import {getAmount, getCategory, getCurrency, getTag, isTransactionPendingDelete} from './TransactionUtils';
 
 /**
@@ -100,7 +99,7 @@ function groupTransactionsByTag(transactions: Transaction[], report: OnyxEntry<R
 
     for (const transaction of transactions) {
         const tag = getTag(transaction);
-        const tagKey = isTagMissing(tag) ? '' : Str.htmlDecode(tag);
+        const tagKey = isTagMissing(tag) ? '' : getDecodedTagName(tag);
 
         if (!groups.has(tagKey)) {
             groups.set(tagKey, []);

src/libs/TagUtils.ts

@@ -1,3 +1,4 @@
+import {Str} from 'expensify-common';
 import CONST from '@src/CONST';
 
 /**
@@ -19,4 +20,12 @@ function trimTag(tag: string): string {
     return tagWithoutEscapedColons.replace(/:*$/, '').replaceAll('☢', '\\:');
 }
 
-export {isTagMissing, trimTag};
+/**
+ * HTML-decodes a tag name so values stored with different encodings (e.g. `R&D` vs `R&D`)
+ * resolve to the same string. Mirrors getDecodedCategoryName in CategoryUtils.
+ */
+function getDecodedTagName(tagName: string): string {
+    return Str.htmlDecode(tagName);
+}
+
+export {isTagMissing, trimTag, getDecodedTagName};

tests/unit/TagUtilsTest.ts

@@ -1,4 +1,4 @@
-import {isTagMissing, trimTag} from '@libs/TagUtils';
+import {getDecodedTagName, isTagMissing, trimTag} from '@libs/TagUtils';
 import CONST from '@src/CONST';
 
 describe('TagUtils', () => {
@@ -68,4 +68,23 @@ describe('TagUtils', () => {
             expect(trimTag('tag\\:name\\\\::')).toBe('tag\\:name\\\\:');
         });
     });
+
+    describe('getDecodedTagName', () => {
+        it('decodes & to &', () => {
+            expect(getDecodedTagName('R&D')).toBe('R&D');
+        });
+
+        it('returns an unencoded string unchanged', () => {
+            expect(getDecodedTagName('R&D')).toBe('R&D');
+        });
+
+        it('returns an empty string when input is empty', () => {
+            expect(getDecodedTagName('')).toBe('');
+        });
+
+        it('decodes other common HTML entities', () => {
+            expect(getDecodedTagName('a &lt; b &gt; c')).toBe('a < b > c');
+            expect(getDecodedTagName('&quot;hello&quot;')).toBe('"hello"');
+        });
+    });
 });