Merge pull request Expensify#64769 from Expensify/revert-63853-parasharrajat/travel-update

[CP Staging] Revert "Use tripdata payload to get reservations setup"

Author: mountiny

cspell.json

@@ -681,8 +681,7 @@
         "zoneinfo",
         "zxcv",
         "zxldvw",
-        "مثال",
-        "pnrs"
+        "مثال"
     ],
     "ignorePaths": [
         "src/languages/de.ts",

src/ROUTES.ts

@@ -1961,12 +1961,12 @@ const ROUTES = {
         },
     },
     TRAVEL_TRIP_DETAILS: {
-        route: 'r/:reportID/trip/:transactionID/:pnr/:sequenceIndex',
-        getRoute: (reportID: string | undefined, transactionID: string | undefined, pnr: string | undefined, sequenceIndex: number, backTo?: string) => {
-            if (!reportID || !transactionID || !pnr) {
-                Log.warn('Invalid reportID, transactionID or pnr is used to build the TRAVEL_TRIP_DETAILS route');
+        route: 'r/:reportID/trip/:transactionID/:reservationIndex',
+        getRoute: (reportID: string | undefined, transactionID: string | undefined, reservationIndex: number, backTo?: string) => {
+            if (!reportID || !transactionID) {
+                Log.warn('Invalid reportID or transactionID is used to build the TRAVEL_TRIP_DETAILS route');
             }
-            return getUrlWithBackToParam(`r/${reportID}/trip/${transactionID}/${pnr}/${sequenceIndex}`, backTo);
+            return getUrlWithBackToParam(`r/${reportID}/trip/${transactionID}/${reservationIndex}`, backTo);
         },
     },
     TRAVEL_DOMAIN_SELECTOR: {

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -869,7 +869,7 @@ function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = fals
                             if (reservations > 1) {
                                 Navigation.navigate(ROUTES.TRAVEL_TRIP_SUMMARY.getRoute(report.reportID, transaction.transactionID, getReportRHPActiveRoute()));
                             }
-                            Navigation.navigate(ROUTES.TRAVEL_TRIP_DETAILS.getRoute(report.reportID, transaction.transactionID, '0', 0, getReportRHPActiveRoute()));
+                            Navigation.navigate(ROUTES.TRAVEL_TRIP_DETAILS.getRoute(report.reportID, transaction.transactionID, 0, getReportRHPActiveRoute()));
                         }}
                     />
                 )}

src/components/ReportActionItem/TripDetailsView.tsx

@@ -1,7 +1,6 @@
 import {Str} from 'expensify-common';
 import React, {useMemo} from 'react';
 import {View} from 'react-native';
-import type {OnyxEntry} from 'react-native-onyx';
 import Icon from '@components/Icon';
 import MenuItemWithTopDescription from '@components/MenuItemWithTopDescription';
 import OfflineWithFeedback from '@components/OfflineWithFeedback';
@@ -19,20 +18,19 @@ import variables from '@styles/variables';
 import * as Expensicons from '@src/components/Icon/Expensicons';
 import CONST from '@src/CONST';
 import type {ReservationData} from '@src/libs/TripReservationUtils';
-import {getReservationsFromTripReport, getTripReservationCode, getTripReservationIcon} from '@src/libs/TripReservationUtils';
+import {getReservationsFromTripTransactions, getTripReservationCode, getTripReservationIcon} from '@src/libs/TripReservationUtils';
 import ROUTES from '@src/ROUTES';
-import type {Report} from '@src/types/onyx';
 import type {Reservation, ReservationTimeDetails} from '@src/types/onyx/Transaction';
 import type Transaction from '@src/types/onyx/Transaction';
 
 type ReservationViewProps = {
     reservation: Reservation;
     transactionID: string;
     tripRoomReportID: string;
-    sequenceIndex: number;
+    reservationIndex: number;
 };
 
-function ReservationView({reservation, transactionID, tripRoomReportID, sequenceIndex}: ReservationViewProps) {
+function ReservationView({reservation, transactionID, tripRoomReportID, reservationIndex}: ReservationViewProps) {
     const theme = useTheme();
     const styles = useThemeStyles();
     const StyleUtils = useStyleUtils();
@@ -141,18 +139,14 @@ function ReservationView({reservation, transactionID, tripRoomReportID, sequence
             iconWidth={20}
             iconStyles={[StyleUtils.getTripReservationIconContainer(false), styles.mr3]}
             secondaryIconFill={theme.icon}
-            onPress={() =>
-                Navigation.navigate(
-                    ROUTES.TRAVEL_TRIP_DETAILS.getRoute(tripRoomReportID, transactionID, String(reservation.reservationID), sequenceIndex, Navigation.getReportRHPActiveRoute()),
-                )
-            }
+            onPress={() => Navigation.navigate(ROUTES.TRAVEL_TRIP_DETAILS.getRoute(tripRoomReportID, transactionID, reservationIndex, Navigation.getReportRHPActiveRoute()))}
         />
     );
 }
 
 type TripDetailsViewProps = {
     /** The active tripRoomReportID, used for Onyx subscription */
-    tripRoomReport: OnyxEntry<Report>;
+    tripRoomReportID: string;
 
     /** Whether we should display the horizontal rule below the component */
     shouldShowHorizontalRule: boolean;
@@ -161,15 +155,11 @@ type TripDetailsViewProps = {
     tripTransactions: Transaction[];
 };
 
-function TripDetailsView({tripRoomReport, shouldShowHorizontalRule, tripTransactions}: TripDetailsViewProps) {
+function TripDetailsView({tripRoomReportID, shouldShowHorizontalRule, tripTransactions}: TripDetailsViewProps) {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
 
-    if (!tripRoomReport) {
-        return null;
-    }
-
-    const reservationsData: ReservationData[] = getReservationsFromTripReport(tripRoomReport, tripTransactions);
+    const reservationsData: ReservationData[] = getReservationsFromTripTransactions(tripTransactions);
 
     return (
         <View>
@@ -184,14 +174,14 @@ function TripDetailsView({tripRoomReport, shouldShowHorizontalRule, tripTransact
                 </View>
             </View>
             <>
-                {reservationsData.map(({reservation, transactionID, sequenceIndex}) => {
+                {reservationsData.map(({reservation, transactionID, reservationIndex}) => {
                     return (
                         <OfflineWithFeedback>
                             <ReservationView
                                 reservation={reservation}
                                 transactionID={transactionID}
-                                tripRoomReportID={tripRoomReport.reportID}
-                                sequenceIndex={sequenceIndex}
+                                tripRoomReportID={tripRoomReportID}
+                                reservationIndex={reservationIndex}
                             />
                         </OfflineWithFeedback>
                     );

src/components/ReportActionItem/TripRoomPreview.tsx

@@ -20,8 +20,9 @@ import {convertToDisplayString} from '@libs/CurrencyUtils';
 import DateUtils from '@libs/DateUtils';
 import {canUseTouchScreen} from '@libs/DeviceCapabilities';
 import Navigation from '@libs/Navigation/Navigation';
+import {getMoneyRequestSpendBreakdown} from '@libs/ReportUtils';
 import type {ReservationData} from '@libs/TripReservationUtils';
-import {getReservationsFromTripReport, getTripReservationIcon, getTripTotal} from '@libs/TripReservationUtils';
+import {getReservationsFromTripTransactions, getTripReservationIcon} from '@libs/TripReservationUtils';
 import type {ContextMenuAnchor} from '@pages/home/report/ContextMenu/ReportActionContextMenu';
 import variables from '@styles/variables';
 import * as Expensicons from '@src/components/Icon/Expensicons';
@@ -153,15 +154,14 @@ function TripRoomPreview({
     const chatReportID = chatReport?.reportID;
     const tripTransactions = useTripTransactions(chatReportID);
 
-    const reservationsData: ReservationData[] = getReservationsFromTripReport(chatReport, tripTransactions);
+    const reservationsData: ReservationData[] = getReservationsFromTripTransactions(tripTransactions);
     const dateInfo =
         chatReport?.tripData?.startDate && chatReport?.tripData?.endDate
             ? DateUtils.getFormattedDateRange(new Date(chatReport.tripData.startDate), new Date(chatReport.tripData.endDate))
             : '';
-    const reportCurrency = iouReport?.currency ?? chatReport?.currency;
-
-    const {totalDisplaySpend = 0, currency = reportCurrency} = chatReport ? getTripTotal(chatReport) : {};
+    const {totalDisplaySpend} = getMoneyRequestSpendBreakdown(chatReport);
 
+    const currency = iouReport?.currency ?? chatReport?.currency;
     const displayAmount = useMemo(() => {
         if (totalDisplaySpend) {
             return convertToDisplayString(totalDisplaySpend, currency);

src/libs/DebugUtils.ts

@@ -567,7 +567,6 @@ function validateReportDraftProperty(key: keyof Report | keyof ReportNameValuePa
                 startDate: 'string',
                 endDate: 'string',
                 tripID: 'string',
-                payload: 'object',
             });
         case 'calendlySchedule':
             return validateObject<ObjectElement<ReportNameValuePairs, 'calendlySchedule'>>(value, {

src/libs/Navigation/types.ts

@@ -1730,8 +1730,7 @@ type TravelNavigatorParamList = {
     [SCREENS.TRAVEL.TRIP_DETAILS]: {
         reportID: string;
         transactionID: string;
-        sequenceIndex: number;
-        pnr: string;
+        reservationIndex: number;
         backTo?: string;
     };
     [SCREENS.TRAVEL.TCS]: {