Merge pull request Expensify#67133 from allgandalf/fixtoggleProfileTool

Refactor `toggleProfileTool` to remove usage of `Onyx.Connect`

Author: tgolen

package.json

@@ -46,7 +46,7 @@
     "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
     "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
     "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
-    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=332 --cache --cache-location=node_modules/.cache/eslint",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=331 --cache --cache-location=node_modules/.cache/eslint",
     "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
     "lint-watch": "npx eslint-watch --watch --changed",
     "shellcheck": "./scripts/shellCheck.sh",

src/components/RecordTroubleshootDataToolMenu/BaseRecordTroubleshootDataToolMenu.tsx

@@ -103,7 +103,7 @@ function BaseRecordTroubleshootDataToolMenu({
         } else {
             Performance.disableMonitoring();
         }
-        toggleProfileTool();
+        toggleProfileTool(isProfilingInProgress);
         return () => {
             Performance.disableMonitoring();
         };

src/libs/actions/ProfilingTool.ts

@@ -3,18 +3,12 @@ import Onyx from 'react-native-onyx';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 
-let isProfilingInProgress = false;
-Onyx.connect({
-    key: ONYXKEYS.APP_PROFILING_IN_PROGRESS,
-    callback: (val) => (isProfilingInProgress = val ?? false),
-});
-
 /**
  * Toggle the test tools modal open or closed.
  * Throttle the toggle to make the modal stay open if you accidentally tap an extra time, which is easy to do.
  */
-function toggleProfileTool() {
-    const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, !isProfilingInProgress);
+function toggleProfileTool(isProfilingInProgress = false) {
+    const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, isProfilingInProgress);
     const throttledToggle = throttle(toggle, CONST.TIMING.TEST_TOOLS_MODAL_THROTTLE_TIME);
     throttledToggle();
 }