Skip to content

Commit 1839dd8

Browse files
MelvinBotmadmax330
MelvinBot
and
madmax330
committed
Rename file upload consts from NON_USD_BANK_ACCOUNT to CORPAY_DOCUMENT
Move ALLOWED_FILE_TYPES, FILE_LIMIT, MAX_FILE_SIZE, and TOTAL_FILES_SIZE_LIMIT to a new CORPAY_DOCUMENT const group since these consts are used in both USD and non-USD flows (e.g., DocusignFullStep is also used on the wallet page for global reimbursements). Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
1 parent 7747c4e commit 1839dd8

5 files changed

Lines changed: 32 additions & 30 deletions

File tree

‎src/CONST/index.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,11 +680,13 @@ const CONST = {
680680
PERSONAL: 'PERSONAL',
681681
},
682682
},
683-
NON_USD_BANK_ACCOUNT: {
683+
CORPAY_DOCUMENT: {
684684
ALLOWED_FILE_TYPES: ['pdf', 'jpg', 'jpeg', 'png'],
685685
FILE_LIMIT: 1,
686686
MAX_FILE_SIZE: 2097152,
687687
TOTAL_FILES_SIZE_LIMIT: 5242880,
688+
},
689+
NON_USD_BANK_ACCOUNT: {
688690
PURPOSE_OF_TRANSACTION_ID: 'Intercompany_Payment',
689691
CURRENT_USER_KEY: 'currentUser',
690692
CORPAY_UNDEFINED_OPTION_VALUE: 'Undefined',

‎src/components/SubStepForms/DocusignFullStep.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,14 @@ function DocusignFullStep<TFormID extends keyof OnyxFormValuesMapping>({
148148
onRemove={(fileName) => {
149149
handleRemoveFile(fileName);
150150
}}
151-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
151+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
152152
value={uploadedFiles}
153153
inputID={inputID as string}
154154
setError={(error) => {
155155
setUploadError(error);
156156
}}
157157
fileLimit={1}
158-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
158+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
159159
/>
160160
</FormProvider>
161161
</InteractiveStepWrapper>

‎src/pages/ReimbursementAccount/EnterSignerInfo/subSteps/UploadDocuments.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ function UploadDocuments({onNext, isEditing, policyID}: UploadDocumentsProps) {
140140
onRemove={(fileName) => {
141141
handleRemoveFile(fileName, uploadedIDs, copyOfIDInputID, setUploadedID);
142142
}}
143-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
143+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
144144
value={uploadedIDs}
145145
inputID={copyOfIDInputID}
146146
setError={(error) => {
@@ -168,7 +168,7 @@ function UploadDocuments({onNext, isEditing, policyID}: UploadDocumentsProps) {
168168
onRemove={(fileName) => {
169169
handleRemoveFile(fileName, uploadedProofsOfAddress, addressProofInputID, setUploadedProofOfAddress);
170170
}}
171-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
171+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
172172
value={uploadedProofsOfAddress}
173173
inputID={addressProofInputID}
174174
setError={(error) => {
@@ -195,7 +195,7 @@ function UploadDocuments({onNext, isEditing, policyID}: UploadDocumentsProps) {
195195
onRemove={(fileName) => {
196196
handleRemoveFile(fileName, uploadedProofsOfDirectors, directorsProofInputID, setUploadedProofsOfDirectors);
197197
}}
198-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
198+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
199199
value={uploadedProofsOfDirectors}
200200
inputID={directorsProofInputID}
201201
setError={(error) => {

‎src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerDetailsFormSubSteps/Documents.tsx‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ function Documents({onNext, isEditing, ownerBeingModifiedID}: DocumentsProps) {
124124
setError={(error) => {
125125
setUploadError(error, proofOfOwnershipInputID);
126126
}}
127-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
128-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
129-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
127+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
128+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
129+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
130130
value={defaultValues[proofOfOwnershipInputID]}
131131
inputID={proofOfOwnershipInputID}
132132
/>
@@ -153,9 +153,9 @@ function Documents({onNext, isEditing, ownerBeingModifiedID}: DocumentsProps) {
153153
setError={(error) => {
154154
setUploadError(error, copyOfIDInputID);
155155
}}
156-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
157-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
158-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
156+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
157+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
158+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
159159
value={defaultValues[copyOfIDInputID]}
160160
inputID={copyOfIDInputID}
161161
/>
@@ -180,9 +180,9 @@ function Documents({onNext, isEditing, ownerBeingModifiedID}: DocumentsProps) {
180180
setError={(error) => {
181181
setUploadError(error, addressProofInputID);
182182
}}
183-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
184-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
185-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
183+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
184+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
185+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
186186
value={defaultValues[addressProofInputID]}
187187
inputID={addressProofInputID}
188188
/>
@@ -207,9 +207,9 @@ function Documents({onNext, isEditing, ownerBeingModifiedID}: DocumentsProps) {
207207
setError={(error) => {
208208
setUploadError(error, codiceFiscaleInputID);
209209
}}
210-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
211-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
212-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
210+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
211+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
212+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
213213
value={defaultValues[codiceFiscaleInputID]}
214214
inputID={codiceFiscaleInputID}
215215
/>

‎src/pages/ReimbursementAccount/NonUSD/SignerInfo/subSteps/UploadDocuments.tsx‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ function UploadDocuments({onNext, isEditing}: UploadDocumentsProps) {
131131
onRemove={(fileName) => {
132132
handleRemoveFile(fileName, uploadedIDs, COPY_OF_ID, setUploadedID);
133133
}}
134-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
134+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
135135
value={uploadedIDs}
136136
inputID={COPY_OF_ID}
137137
setError={(error) => {
138138
setUploadError(error, COPY_OF_ID);
139139
}}
140-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
141-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
140+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
141+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
142142
/>
143143
<Text style={[styles.mutedTextLabel, styles.mt6]}>{translate('ownershipInfoStep.copyOfIDDescription')}</Text>
144144
{(isDocumentNeededStatus.isAddressProofNeeded ||
@@ -160,14 +160,14 @@ function UploadDocuments({onNext, isEditing}: UploadDocumentsProps) {
160160
onRemove={(fileName) => {
161161
handleRemoveFile(fileName, uploadedProofsOfAddress, ADDRESS_PROOF, setUploadedProofOfAddress);
162162
}}
163-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
163+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
164164
value={uploadedProofsOfAddress}
165165
inputID={ADDRESS_PROOF}
166166
setError={(error) => {
167167
setUploadError(error, ADDRESS_PROOF);
168168
}}
169-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
170-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
169+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
170+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
171171
/>
172172
<Text style={[styles.mutedTextLabel, styles.mt6]}>{translate('ownershipInfoStep.proofOfAddressDescription')}</Text>
173173
{(isDocumentNeededStatus.isProofOfDirectorsNeeded || isDocumentNeededStatus.isCodiceFiscaleNeeded || isDocumentNeededStatus.isPRDAndFSGNeeded) && (
@@ -188,14 +188,14 @@ function UploadDocuments({onNext, isEditing}: UploadDocumentsProps) {
188188
onRemove={(fileName) => {
189189
handleRemoveFile(fileName, uploadedProofsOfDirectors, PROOF_OF_DIRECTORS, setUploadedProofsOfDirectors);
190190
}}
191-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
191+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
192192
value={uploadedProofsOfDirectors}
193193
inputID={PROOF_OF_DIRECTORS}
194194
setError={(error) => {
195195
setUploadError(error, PROOF_OF_DIRECTORS);
196196
}}
197-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
198-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
197+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
198+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
199199
/>
200200
<Text style={[styles.mutedTextLabel, styles.mt6]}>{translate('signerInfoStep.proofOfDirectorsDescription')}</Text>
201201
{(isDocumentNeededStatus.isCodiceFiscaleNeeded || isDocumentNeededStatus.isPRDAndFSGNeeded) && <View style={[styles.sectionDividerLine, styles.mt6, styles.mb6]} />}
@@ -214,14 +214,14 @@ function UploadDocuments({onNext, isEditing}: UploadDocumentsProps) {
214214
onRemove={(fileName) => {
215215
handleRemoveFile(fileName, uploadedCodiceFiscale, CODICE_FISCALE, setUploadedCodiceFiscale);
216216
}}
217-
acceptedFileTypes={[...CONST.NON_USD_BANK_ACCOUNT.ALLOWED_FILE_TYPES]}
217+
acceptedFileTypes={[...CONST.CORPAY_DOCUMENT.ALLOWED_FILE_TYPES]}
218218
value={uploadedCodiceFiscale}
219219
inputID={CODICE_FISCALE}
220220
setError={(error) => {
221221
setUploadError(error, CODICE_FISCALE);
222222
}}
223-
fileLimit={CONST.NON_USD_BANK_ACCOUNT.FILE_LIMIT}
224-
maxFileSize={CONST.NON_USD_BANK_ACCOUNT.MAX_FILE_SIZE}
223+
fileLimit={CONST.CORPAY_DOCUMENT.FILE_LIMIT}
224+
maxFileSize={CONST.CORPAY_DOCUMENT.MAX_FILE_SIZE}
225225
/>
226226
<Text style={[styles.mutedTextLabel, styles.mt6]}>{translate('signerInfoStep.codiceFiscaleDescription')}</Text>
227227
{isDocumentNeededStatus.isPRDAndFSGNeeded && <View style={[styles.sectionDividerLine, styles.mt6, styles.mb6]} />}

0 commit comments

Comments
 (0)