Skip to content

Commit 1939c12

Browse files
authored
Merge pull request Expensify#75560 from paulnjs/paulnjs-fix/73760
fix: Search input on Reports page appends text to existing filter without whitespace
2 parents 1dac980 + 21b2ba3 commit 1939c12

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
6969
const {inputQuery: originalInputQuery} = queryJSON;
7070
const isDefaultQuery = isDefaultExpensesQuery(queryJSON);
7171
const [currentUserAccountID = -1] = useOnyx(ONYXKEYS.SESSION, {selector: accountIDSelector, canBeMissing: false});
72-
const queryText = buildUserReadableQueryString(queryJSON, personalDetails, reports, taxRates, allCards, allFeeds, policies, currentUserAccountID);
72+
const queryText = buildUserReadableQueryString(queryJSON, personalDetails, reports, taxRates, allCards, allFeeds, policies, currentUserAccountID, true);
7373

7474
// The actual input text that the user sees
7575
const [textInputValue, setTextInputValue] = useState(isDefaultQuery ? '' : queryText);

src/libs/SearchQueryUtils.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -970,6 +970,7 @@ function buildUserReadableQueryString(
970970
cardFeeds: OnyxCollection<OnyxTypes.CardFeeds>,
971971
policies: OnyxCollection<OnyxTypes.Policy>,
972972
currentUserAccountID: number,
973+
autoCompleteWithSpace = false,
973974
) {
974975
const {type, status, groupBy, policyID} = queryJSON;
975976
const filters = queryJSON.flatFilters;
@@ -1050,6 +1051,10 @@ function buildUserReadableQueryString(
10501051
title += buildFilterValuesString(getUserFriendlyKey(key), displayQueryFilters);
10511052
}
10521053

1054+
if (autoCompleteWithSpace && !title.endsWith(' ')) {
1055+
title += ' ';
1056+
}
1057+
10531058
return title;
10541059
}
10551060

0 commit comments

Comments
 (0)