Merge pull request Expensify#67538 from DylanDylann/Refactor-device-file-to-remove-onyx-connect

[No QA]: Remove Onyx.connect() for the key: ONYXKEYS.DEVICE_ID in src/libs/actions/Device/index.ts Expensify#66501

Author: tgolen

src/libs/actions/Device/index.ts

@@ -16,7 +16,9 @@ function getDeviceID(): Promise<string | null> {
             return;
         }
 
-        const connection = Onyx.connect({
+        // Use connectWithoutView because this is a one-time data fetch that disconnects immediately without triggering UI updates
+        // and this onyx key is created for non-UI task only.
+        const connection = Onyx.connectWithoutView({
             key: ONYXKEYS.DEVICE_ID,
             callback: (id) => {
                 Onyx.disconnect(connection);

tests/unit/ReportUtilsGetIconsTest.ts

@@ -148,7 +148,7 @@ describe('getIcons', () => {
     it('should return the correct icons for archived non expense request/report', () => {
         const report: Report = {
             ...LHNTestUtils.getFakeReport([1], 0, true),
-            type: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT,
+            type: CONST.REPORT.CHAT_TYPE.INVOICE,
         };
         const policy = LHNTestUtils.getFakePolicy('1');