Skip to content

Commit 1a1ed1c

Browse files
committed
address reviewer comments
1 parent 5e67fe1 commit 1a1ed1c

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

tests/unit/libs/PersonalDetailsUtilsTest.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,10 @@ import ONYXKEYS from '@src/ONYXKEYS';
44
import {formatPhoneNumber} from '../../utils/TestHelper';
55

66
describe('PersonalDetailsUtils', () => {
7-
beforeAll(async () => {
8-
await Onyx.merge(ONYXKEYS.COUNTRY_CODE, 1);
9-
});
10-
117
test('getPersonalDetailsOnyxDataForOptimisticUsers should return correct optimistic and finally data', () => {
12-
const newLogins = ['3322076524', 'test2@test.com'];
13-
const newAccountIDs = [1, 2];
14-
8+
const newLogins = ['3322076524', 'test2@test.com', '+14185438090'];
9+
const newAccountIDs = [1, 2, 3];
1510
const result = getPersonalDetailsOnyxDataForOptimisticUsers(newLogins, newAccountIDs, formatPhoneNumber);
16-
1711
const expected = {
1812
optimisticData: [
1913
{
@@ -34,6 +28,13 @@ describe('PersonalDetailsUtils', () => {
3428
isOptimisticPersonalDetail: true,
3529
login: 'test2@test.com',
3630
},
31+
// eslint-disable-next-line @typescript-eslint/naming-convention
32+
'3': {
33+
accountID: 3,
34+
displayName: '(418) 543-8090',
35+
isOptimisticPersonalDetail: true,
36+
login: '+14185438090',
37+
},
3738
},
3839
},
3940
],
@@ -46,11 +47,12 @@ describe('PersonalDetailsUtils', () => {
4647
'1': null,
4748
// eslint-disable-next-line @typescript-eslint/naming-convention
4849
'2': null,
50+
// eslint-disable-next-line @typescript-eslint/naming-convention
51+
'3': null,
4952
},
5053
},
5154
],
5255
};
53-
5456
expect(result).toEqual(expected);
5557
});
5658
});

0 commit comments

Comments
 (0)