Skip to content

Commit 1c89c19

Browse files
authored
Merge branch 'Expensify:main' into krishna2323/issue/87734-fix
2 parents 8fcc3c8 + 00eaba3 commit 1c89c19

237 files changed

Lines changed: 7159 additions & 3067 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Mobile-Expensify

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ android {
111111
minSdkVersion rootProject.ext.minSdkVersion
112112
targetSdkVersion rootProject.ext.targetSdkVersion
113113
multiDexEnabled rootProject.ext.multiDexEnabled
114-
versionCode 1009036802
115-
versionName "9.3.68-2"
114+
versionCode 1009036803
115+
versionName "9.3.68-3"
116116
// Supported language variants must be declared here to avoid from being removed during the compilation.
117117
// This also helps us to not include unnecessary language variants in the APK.
118118
resConfigs "en", "es"

config/eslint/eslint.seatbelt.tsv

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@
226226
"../../src/hooks/useNewTransactions.ts" "react-hooks/refs" 2
227227
"../../src/hooks/useOnboardingFlow.ts" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1
228228
"../../src/hooks/useOutstandingBalanceGuard.tsx" "@typescript-eslint/no-deprecated/ConfirmModal" 1
229-
"../../src/hooks/usePaginatedReportActions.ts" "react-hooks/refs" 1
230229
"../../src/hooks/usePaymentOptions.ts" "react-hooks/refs" 1
231230
"../../src/hooks/usePrevious.ts" "react-hooks/refs" 1
232231
"../../src/hooks/useProactiveAppReview.ts" "react-hooks/purity" 1
@@ -524,14 +523,13 @@
524523
"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx" "react-hooks/preserve-manual-memoization" 1
525524
"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx" "react-hooks/refs" 6
526525
"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx" "react-hooks/set-state-in-effect" 1
527-
"../../src/pages/inbox/report/ReportActionsList.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 5
528-
"../../src/pages/inbox/report/ReportActionsList.tsx" "react-hooks/refs" 7
526+
"../../src/pages/inbox/report/ReportActionsList.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 4
527+
"../../src/pages/inbox/report/ReportActionsList.tsx" "react-hooks/refs" 5
529528
"../../src/pages/inbox/report/ReportActionsList.tsx" "react-hooks/set-state-in-effect" 3
530-
"../../src/pages/inbox/report/ReportActionsView.tsx" "react-hooks/globals" 1
531-
"../../src/pages/inbox/report/ReportActionsView.tsx" "react-hooks/preserve-manual-memoization" 1
532529
"../../src/pages/inbox/report/TripSummary.tsx" "rulesdir/no-default-id-values" 1
533530
"../../src/pages/inbox/report/UserTypingEventListener.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 4
534531
"../../src/pages/inbox/report/shouldUseEmojiPickerSelection/index.website.ts" "no-restricted-syntax" 1
532+
"../../src/pages/inbox/report/useReportActionsNewActionLiveTail.ts" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1
535533
"../../src/pages/inbox/report/withReportOrNotFound.tsx" "react-hooks/refs" 3
536534
"../../src/pages/inbox/sidebar/SidebarLinksData.tsx" "react-hooks/refs" 1
537535
"../../src/pages/iou/MoneyRequestAmountForm.tsx" "react-hooks/set-state-in-effect" 3

contributingGuides/CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ You can create as many accounts as needed in order to test your changes directly
99

1010
**Notes**:
1111

12-
1. When creating test accounts, include a `+` (plus sign) in the email address (e.g., matt+1@gmail.com). This marks the account and their associated workspaces as test accounts in Expensify, ensuring Expensify Guides are not assigned to help with account setup.
12+
1. When creating test accounts:
13+
- Include a `+` (plus sign) in the email address (e.g., matt+1@gmail.com). This marks the account and their associated workspaces as test accounts in Expensify, ensuring Expensify Guides are not assigned to help with account setup.
14+
- When testing on live servers with a private domain, stick to a single, consistent test domain. Please avoid generating random or "fake" domains (e.g., asdfkef23@asfdasfwaf.com).
1315
2. When testing chat functionality in the app please do this between accounts you or your fellow contributors own - **do not test chatting with Concierge**, as this diverts to our customer support team. Thank you.
1416
3. A member of our customer onboarding team gets auto-assigned to every new policy created by a non-paying account to help them set up. Please **do not interact with these teams, ask for calls, or support on your issues.** If you do need to test functionality inside the defaultRooms (#admins & #announce) for any issues you’re working on, please let them know that you are a contributor and don’t need assistance. They will proceed to ignore the chat.
1517
4. Please **do not post in any Expensify owned public room for testing** (e.g #exfy-roadmap, #new-expensify-feedback). These rooms include real customers and investors. You can create your own public rooms, or [use this test public room](https://staging.new.expensify.com/r/2091104345528462) on either staging or production. Thanks!

docs/articles/new-expensify/connect-credit-cards/Share-a-Company-Card-Connection-Across-Workspaces.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@ Workspace Admins with an email on a private domain can share a company card feed
3434
1. Click the navigation tabs (on the left on web, on the bottom on mobile) and select **Workspaces > [Workspace Name]**
3535
2. Choose **Company cards** to view your company’s card setup page.
3636
- If you don't see **Company cards**, enable the feature under **More features > Company cards**
37-
3. Select your existing card connection.
38-
4. In **From other workspaces**, choose a company card feed to add to the Workspace.
37+
3. Click **Add cards**.
38+
4. Select your existing card connection.
39+
5. In **From other workspaces**, choose a company card feed to add to the Workspace.
3940

4041
---
4142

ios/NewExpensify/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</dict>
4545
</array>
4646
<key>CFBundleVersion</key>
47-
<string>9.3.68.2</string>
47+
<string>9.3.68.3</string>
4848
<key>FullStory</key>
4949
<dict>
5050
<key>OrgId</key>

ios/NotificationServiceExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.3.68</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.3.68.2</string>
16+
<string>9.3.68.3</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionPointIdentifier</key>

ios/ShareViewController/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.3.68</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.3.68.2</string>
16+
<string>9.3.68.3</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionAttributes</key>

jest/setup.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import mockStorage from 'react-native-onyx/dist/storage/__mocks__';
1111
import type Animated from 'react-native-reanimated';
1212
import 'setimmediate';
1313
import {TextDecoder, TextEncoder} from 'util';
14+
import type {RenderInfo} from '@components/FlatList/RenderTaskQueue';
1415
import '@src/polyfills/PromiseWithResolvers';
1516
import '@src/polyfills/requestIdleCallback';
1617
import mockFSLibrary from './setupMockFullstoryLib';
@@ -265,7 +266,7 @@ jest.mock(
265266
class SyncRenderTaskQueue {
266267
private handler: (info: unknown) => void = () => {};
267268

268-
add(info: unknown) {
269+
add(info: RenderInfo) {
269270
this.handler(info);
270271
}
271272

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)