Skip to content

Commit 1f5b98a

Browse files
committed
Merge branch 'main' into fix/preselected-items-top-of-list
2 parents ea4b42f + be6595c commit 1f5b98a

71 files changed

Lines changed: 1092 additions & 274 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/CONST/index.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1893,6 +1893,7 @@ const CONST = {
18931893
NATIVE_ID: 'composer',
18941894
MAX_LINES: 16,
18951895
MAX_LINES_SMALL_SCREEN: 6,
1896+
MAX_LINES_LANDSCAPE_MODE: 2,
18961897
MAX_LINES_FULL: -1,
18971898
// The minimum height needed to enable the full screen composer
18981899
FULL_COMPOSER_MIN_HEIGHT: 60,
@@ -8612,6 +8613,7 @@ const CONST = {
86128613
HAS_POLICY_ADMIN_CARD_FEED_ERRORS: 'hasPolicyAdminCardFeedErrors',
86138614
HAS_DOMAIN_ERRORS: 'hasDomainErrors',
86148615
HAS_LOCKED_BANK_ACCOUNT: 'hasLockedBankAccount',
8616+
HAS_DEVICE_MANAGEMENT_ERROR: 'hasDeviceManagementError',
86158617
},
86168618

86178619
DEBUG: {
@@ -9633,6 +9635,7 @@ const CONST = {
96339635
REVOKE_MFA: 'SettingsSecurity-RevokeMFA',
96349636
MERGE_ACCOUNTS: 'SettingsSecurity-MergeAccounts',
96359637
LOCK_UNLOCK_ACCOUNT: 'SettingsSecurity-LockUnlockAccount',
9638+
DEVICE_MANAGEMENT: 'SettingsSecurity-DeviceManagement',
96369639
CLOSE_ACCOUNT: 'SettingsSecurity-CloseAccount',
96379640
ADD_COPILOT: 'SettingsSecurity-AddCopilot',
96389641
DELEGATE_ITEM: 'SettingsSecurity-DelegateItem',
@@ -9764,6 +9767,12 @@ const CONST = {
97649767
ROUTE_SOURCE: 'route-source',
97659768
ROUTE_FILL: 'route-fill',
97669769
},
9770+
9771+
PARTNER_ID: {
9772+
IPHONE: 14,
9773+
ANDROID: 16,
9774+
NEWDOT: 83,
9775+
},
97679776
} as const;
97689777

97699778
const CONTINUATION_DETECTION_SEARCH_FILTER_KEYS = [

src/ONYXKEYS.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@ const ONYXKEYS = {
114114
/** Contains latitude and longitude of user's last known location */
115115
USER_LOCATION: 'userLocation',
116116

117+
/** Contains metadata (partner, login, validation date) for all of the user's logins */
118+
LOGINS: 'logins',
119+
117120
/** Contains metadata (partner, login, validation date) for all of the user's logins */
118121
LOGIN_LIST: 'loginList',
119122

@@ -570,6 +573,9 @@ const ONYXKEYS = {
570573
/** Stores the information about duplicated workspace */
571574
DUPLICATE_WORKSPACE: 'duplicateWorkspace',
572575

576+
/** Stores the state of the bulk Copy Policy Settings flow */
577+
COPY_POLICY_SETTINGS: 'copyPolicySettings',
578+
573579
/** Stores the information about currently edited advanced approval workflow */
574580
APPROVAL_WORKFLOW: 'approvalWorkflow',
575581

@@ -1374,6 +1380,7 @@ type OnyxValuesMapping = {
13741380
[ONYXKEYS.COUNTRY_CODE]: number;
13751381
[ONYXKEYS.COUNTRY]: string;
13761382
[ONYXKEYS.USER_LOCATION]: OnyxTypes.UserLocation;
1383+
[ONYXKEYS.LOGINS]: OnyxTypes.Logins;
13771384
[ONYXKEYS.LOGIN_LIST]: OnyxTypes.LoginList;
13781385
[ONYXKEYS.PENDING_CONTACT_ACTION]: OnyxTypes.PendingContactAction;
13791386
[ONYXKEYS.VALIDATE_ACTION_CODE]: OnyxTypes.ValidateMagicCodeAction;
@@ -1508,6 +1515,7 @@ type OnyxValuesMapping = {
15081515
[ONYXKEYS.ASSIGN_CARD]: OnyxTypes.AssignCard;
15091516
[ONYXKEYS.RAM_ONLY_MOBILE_SELECTION_MODE]: boolean;
15101517
[ONYXKEYS.DUPLICATE_WORKSPACE]: OnyxTypes.DuplicateWorkspace;
1518+
[ONYXKEYS.COPY_POLICY_SETTINGS]: OnyxTypes.CopyPolicySettings;
15111519
[ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL]: string;
15121520
[ONYXKEYS.NVP_LAST_DAY_FREE_TRIAL]: string;
15131521
[ONYXKEYS.NVP_BILLING_FUND_ID]: number;

src/ROUTES.ts

Lines changed: 35 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,14 @@ const DYNAMIC_ROUTES = {
226226
path: 'qbd-company-card-expense-account-select',
227227
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_QUICKBOOKS_DESKTOP_EXPORT, SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT],
228228
},
229+
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_OUT_OF_POCKET_EXPENSE_ACCOUNT_SELECT: {
230+
path: 'qbd-account-select',
231+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES],
232+
},
233+
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_OUT_OF_POCKET_EXPENSE_ENTITY_SELECT: {
234+
path: 'qbd-entity-select',
235+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES],
236+
},
229237
POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_INVOICE_ACCOUNT_SELECT: {
230238
path: 'invoice-account-select',
231239
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_QUICKBOOKS_ONLINE_EXPORT],
@@ -254,11 +262,23 @@ const DYNAMIC_ROUTES = {
254262
},
255263
POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT: {
256264
path: 'bank-account-select',
257-
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.XERO_EXPORT],
265+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_XERO_EXPORT],
258266
},
259267
POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR: {
260268
path: 'purchase-bill-status-selector',
261-
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.XERO_EXPORT],
269+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_XERO_EXPORT],
270+
},
271+
POLICY_ACCOUNTING_XERO_EXPORT: {
272+
path: 'xero/export',
273+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.ROOT, SCREENS.WORKSPACE.COMPANY_CARD_EXPORT],
274+
},
275+
POLICY_ACCOUNTING_XERO_PREFERRED_EXPORTER_SELECT: {
276+
path: 'xero-preferred-exporter/select',
277+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_XERO_EXPORT],
278+
},
279+
POLICY_ACCOUNTING_XERO_EXPORT_PURCHASE_BILL_DATE_SELECT: {
280+
path: 'purchase-bill-date-select',
281+
entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_XERO_EXPORT],
262282
},
263283
POLICY_ACCOUNTING_XERO_AUTO_SYNC: {
264284
path: 'xero-autosync',
@@ -725,6 +745,7 @@ const ROUTES = {
725745
SETTINGS_PAYMENT_CURRENCY: 'setting/preferences/payment-currency',
726746
SETTINGS_THEME: 'settings/preferences/theme',
727747
SETTINGS_SECURITY: 'settings/security',
748+
SETTINGS_DEVICE_MANAGEMENT: 'settings/security/device-management',
728749
SETTINGS_CLOSE: 'settings/security/closeAccount',
729750
SETTINGS_MERGE_ACCOUNTS: {
730751
route: 'settings/security/merge-accounts',
@@ -2090,28 +2111,6 @@ const ROUTES = {
20902111
return getUrlWithBackToParam(`workspaces/${policyID}/accounting/quickbooks-desktop/export/out-of-pocket-expense` as const, backTo);
20912112
},
20922113
},
2093-
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_ACCOUNT_SELECT: {
2094-
route: 'workspaces/:policyID/accounting/quickbooks-desktop/export/out-of-pocket-expense/account-select',
2095-
getRoute: (policyID?: string, backTo?: string) => {
2096-
if (!policyID) {
2097-
Log.warn('Invalid policyID is used to build the POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_ACCOUNT_SELECT route');
2098-
}
2099-
2100-
// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
2101-
return getUrlWithBackToParam(`workspaces/${policyID}/accounting/quickbooks-desktop/export/out-of-pocket-expense/account-select` as const, backTo);
2102-
},
2103-
},
2104-
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_SELECT: {
2105-
route: 'workspaces/:policyID/accounting/quickbooks-desktop/export/out-of-pocket-expense/entity-select',
2106-
getRoute: (policyID?: string, backTo?: string) => {
2107-
if (!policyID) {
2108-
Log.warn('Invalid policyID is used to build the POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_SELECT route');
2109-
}
2110-
2111-
// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
2112-
return getUrlWithBackToParam(`workspaces/${policyID}/accounting/quickbooks-desktop/export/out-of-pocket-expense/entity-select` as const, backTo);
2113-
},
2114-
},
21152114
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXISTING_CONNECTIONS: {
21162115
route: 'workspaces/:policyID/accounting/quickbooks-desktop/existing-connections',
21172116
getRoute: (policyID: string) => `workspaces/${policyID}/accounting/quickbooks-desktop/existing-connections` as const,
@@ -2974,6 +2973,18 @@ const ROUTES = {
29742973
route: 'workspace/:policyID/duplicate/select-features',
29752974
getRoute: (policyID: string) => `workspace/${policyID}/duplicate/select-features` as const,
29762975
},
2976+
POLICY_COPY_SETTINGS: {
2977+
route: 'policy/:policyID/copy-settings',
2978+
getRoute: (policyID: string) => `policy/${policyID}/copy-settings` as const,
2979+
},
2980+
POLICY_COPY_SETTINGS_SELECT_FEATURES: {
2981+
route: 'policy/:policyID/copy-settings/select-features',
2982+
getRoute: (policyID: string) => `policy/${policyID}/copy-settings/select-features` as const,
2983+
},
2984+
POLICY_COPY_SETTINGS_CONFIRM: {
2985+
route: 'policy/:policyID/copy-settings/confirm',
2986+
getRoute: (policyID: string) => `policy/${policyID}/copy-settings/confirm` as const,
2987+
},
29772988
WORKSPACE_RECEIPT_PARTNERS: {
29782989
route: 'workspaces/:policyID/receipt-partners',
29792990
getRoute: (policyID: string | undefined, backTo?: string) => {
@@ -3540,24 +3551,6 @@ const ROUTES = {
35403551
route: 'workspaces/:policyID/accounting/xero/import/taxes',
35413552
getRoute: (policyID: string) => `workspaces/${policyID}/accounting/xero/import/taxes` as const,
35423553
},
3543-
POLICY_ACCOUNTING_XERO_EXPORT: {
3544-
route: 'workspaces/:policyID/accounting/xero/export',
3545-
3546-
// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
3547-
getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`workspaces/${policyID}/accounting/xero/export` as const, backTo, false),
3548-
},
3549-
POLICY_ACCOUNTING_XERO_PREFERRED_EXPORTER_SELECT: {
3550-
route: 'workspaces/:policyID/connections/xero/export/preferred-exporter/select',
3551-
3552-
// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
3553-
getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`workspaces/${policyID}/connections/xero/export/preferred-exporter/select` as const, backTo),
3554-
},
3555-
POLICY_ACCOUNTING_XERO_EXPORT_PURCHASE_BILL_DATE_SELECT: {
3556-
route: 'workspaces/:policyID/accounting/xero/export/purchase-bill-date-select',
3557-
3558-
// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
3559-
getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`workspaces/${policyID}/accounting/xero/export/purchase-bill-date-select` as const, backTo),
3560-
},
35613554
POLICY_ACCOUNTING_XERO_ADVANCED: {
35623555
route: 'workspaces/:policyID/accounting/xero/advanced',
35633556
getRoute: (policyID: string | undefined) => {

src/SCREENS.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ const SCREENS = {
126126
UPDATE_PERSONAL_BANK_ACCOUNT: 'Settings_Update_Personal_Bank_Account',
127127
ADD_BANK_ACCOUNT_SELECT_COUNTRY_VERIFY_ACCOUNT: 'Settings_Add_Bank_Account_Select_Country_Verify_Account',
128128
BANK_ACCOUNT_PURPOSE: 'Settings_Bank_Account_Purpose',
129+
DEVICE_MANAGEMENT: 'Settings_Device_Management',
129130
CLOSE: 'Settings_Close',
130131
REPORT_CARD_LOST_OR_DAMAGED: 'Settings_ReportCardLostOrDamaged',
131132
REPORT_CARD_LOST_OR_DAMAGED_CONFIRM_MAGIC_CODE: 'Settings_ReportCardLostOrDamaged_ConfirmMagicCode',
@@ -300,6 +301,7 @@ const SCREENS = {
300301
REPORT_CHANGE_WORKSPACE: 'ReportChangeWorkspace',
301302
WORKSPACE_CONFIRMATION: 'Workspace_Confirmation',
302303
WORKSPACE_DUPLICATE: 'Workspace_Duplicate',
304+
POLICY_COPY_SETTINGS: 'Policy_Copy_Settings',
303305
REPORT_SETTINGS: 'Report_Settings',
304306
REPORT_DESCRIPTION: 'Report_Description',
305307
PARTICIPANTS: 'Participants',
@@ -526,6 +528,11 @@ const SCREENS = {
526528

527529
WORKSPACE_CONFIRMATION: {ROOT: 'Workspace_Confirmation_Root', OWNER_SELECTOR: 'Workspace_Confirmation_Owner_Selector', SUCCESS: 'Workspace_Confirmation_Success'},
528530
WORKSPACE_DUPLICATE: {ROOT: 'Workspace_Duplicate_Root', SELECT_FEATURES: 'Workspace_Duplicate_Select_Features'},
531+
POLICY_COPY_SETTINGS: {
532+
ROOT: 'Policy_Copy_Settings_Root',
533+
SELECT_FEATURES: 'Policy_Copy_Settings_Select_Features',
534+
CONFIRM: 'Policy_Copy_Settings_Confirm',
535+
},
529536

530537
WORKSPACES_LIST: 'Workspaces_List',
531538

@@ -572,8 +579,8 @@ const SCREENS = {
572579
QUICKBOOKS_DESKTOP_EXPORT_DATE_SELECT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Date_Select',
573580
QUICKBOOKS_DESKTOP_EXPORT_PREFERRED_EXPORTER: 'Workspace_Accounting_Quickbooks_Desktop_Export_Preferred_Exporter',
574581
QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES: 'Workspace_Accounting_Quickbooks_Desktop_Export_Out_Of_Pocket_Expenses',
575-
QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_SELECT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Out_Of_Pocket_Expenses_Select',
576-
QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES_ACCOUNT_SELECT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Out_Of_Pocket_Expenses_Account_Select',
582+
DYNAMIC_QUICKBOOKS_DESKTOP_OUT_OF_POCKET_EXPENSE_ENTITY_SELECT: 'Dynamic_Workspace_Accounting_Quickbooks_Desktop_Export_Out_Of_Pocket_Expenses_Select',
583+
DYNAMIC_QUICKBOOKS_DESKTOP_OUT_OF_POCKET_EXPENSE_ACCOUNT_SELECT: 'Dynamic_Workspace_Accounting_Quickbooks_Desktop_Export_Out_Of_Pocket_Expenses_Account_Select',
577584
DYNAMIC_QUICKBOOKS_DESKTOP_EXPORT: 'Dynamic_Workspace_Accounting_Quickbooks_Desktop_Export',
578585
QUICKBOOKS_DESKTOP_REUSE_EXISTING_CONNECTIONS: 'Policy_Accounting_Quickbooks_Desktop_Reuse_Existing_Connections',
579586
QUICKBOOKS_DESKTOP_SETUP_MODAL: 'Policy_Accounting_Quickbooks_Desktop_Setup_Modal',
@@ -594,14 +601,14 @@ const SCREENS = {
594601
XERO_TAXES: 'Policy_Accounting_Xero_Taxes',
595602
XERO_TRACKING_CATEGORIES: 'Policy_Accounting_Xero_Tracking_Categories',
596603
XERO_MAP_TRACKING_CATEGORY: 'Policy_Accounting_Xero_Map_Tracking_Category',
597-
XERO_EXPORT: 'Policy_Accounting_Xero_Export',
598-
XERO_EXPORT_PURCHASE_BILL_DATE_SELECT: 'Policy_Accounting_Xero_Export_Purchase_Bill_Date_Select',
604+
DYNAMIC_XERO_EXPORT: 'Dynamic_Policy_Accounting_Xero_Export',
605+
DYNAMIC_XERO_EXPORT_PURCHASE_BILL_DATE_SELECT: 'Dynamic_Policy_Accounting_Xero_Export_Purchase_Bill_Date_Select',
599606
XERO_ADVANCED: 'Policy_Accounting_Xero_Advanced',
600607
DYNAMIC_XERO_AUTO_SYNC: 'Dynamic_Policy_Accounting_Xero_Auto_Sync',
601608
DYNAMIC_XERO_ACCOUNTING_METHOD: 'Dynamic_Policy_Accounting_Xero_Accounting_Method',
602609
DYNAMIC_XERO_BILL_STATUS_SELECTOR: 'Dynamic_Policy_Accounting_Xero_Export_Bill_Status_Selector',
603610
XERO_INVOICE_ACCOUNT_SELECTOR: 'Policy_Accounting_Xero_Invoice_Account_Selector',
604-
XERO_EXPORT_PREFERRED_EXPORTER_SELECT: 'Workspace_Accounting_Xero_Export_Preferred_Exporter_Select',
611+
DYNAMIC_XERO_EXPORT_PREFERRED_EXPORTER_SELECT: 'Dynamic_Workspace_Accounting_Xero_Export_Preferred_Exporter_Select',
605612
XERO_BILL_PAYMENT_ACCOUNT_SELECTOR: 'Policy_Accounting_Xero_Bill_Payment_Account_Selector',
606613
DYNAMIC_XERO_EXPORT_BANK_ACCOUNT_SELECT: 'Dynamic_Policy_Accounting_Xero_Export_Bank_Account_Select',
607614
NETSUITE_IMPORT_MAPPING: 'Policy_Accounting_NetSuite_Import_Mapping',

0 commit comments

Comments
 (0)