Skip to content

Commit 2126290

Browse files
authored
Merge pull request Expensify#64848 from Expensify/Rory-FixAndroidBuilds
[No QA] Make previous rollout adjustments non-critical
2 parents 0cf569e + ca87838 commit 2126290

1 file changed

Lines changed: 13 additions & 18 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -180,20 +180,15 @@ jobs:
180180
GOOGLE_KEY_FILE: ./android-fastlane-json-key.json
181181
PACKAGE_NAME: org.me.mobiexpensifyg
182182

183+
# Complete the previous version rollout if the current rollout percentage is not -1 (no rollout in progress) or 1 (fully rolled out)
184+
- name: Submit previous production build to 100%
185+
if: ${{ github.ref == 'refs/heads/production' && !contains(fromJSON('["1", "-1"]'), steps.getAndroidRolloutPercentage.outputs.CURRENT_ROLLOUT_PERCENTAGE) }}
186+
run: bundle exec fastlane android complete_hybrid_rollout
187+
continue-on-error: true
188+
183189
- name: Submit production build for Google Play review and a slow rollout
184190
if: ${{ github.ref == 'refs/heads/production' }}
185-
run: |
186-
# Complete the previous version rollout if the current rollout percentage is not -1 (no rollout in progress) or 1 (fully rolled out)
187-
echo "Current rollout percentage: ${{ steps.getAndroidRolloutPercentage.outputs.CURRENT_ROLLOUT_PERCENTAGE }}"
188-
if [[ ${{ steps.getAndroidRolloutPercentage.outputs.CURRENT_ROLLOUT_PERCENTAGE }} != '-1' && ${{ steps.getAndroidRolloutPercentage.outputs.CURRENT_ROLLOUT_PERCENTAGE }} != '1' ]]; then
189-
echo "Completing the previous version rollout"
190-
bundle exec fastlane android complete_hybrid_rollout
191-
else
192-
echo "Skipping the completion of the previous version rollout"
193-
fi
194-
195-
# Submit the new version for review and slow rollout when it's approved
196-
bundle exec fastlane android upload_google_play_production_hybrid_rollout
191+
run: bundle exec fastlane android upload_google_play_production_hybrid_rollout
197192
env:
198193
VERSION: ${{ steps.getAndroidVersion.outputs.VERSION_CODE }}
199194

@@ -433,14 +428,14 @@ jobs:
433428
if: ${{ fromJSON(env.IS_APP_REPO) && fromJSON(env.SHOULD_BUILD_APP) }}
434429
run: bundle exec fastlane ios upload_dsyms_hybrid
435430

436-
- name: Submit production build for App Store review and a slow rollout
431+
- name: Submit previous production build to 100%
437432
if: ${{ github.ref == 'refs/heads/production' }}
438-
run: |
439-
# Complete the previous version rollout
440-
bundle exec fastlane ios complete_hybrid_rollout
433+
run: bundle exec fastlane ios complete_hybrid_rollout
434+
continue-on-error: true
441435

442-
# Submit the new version for review and phased rollout when it's approved
443-
bundle exec fastlane ios submit_hybrid_for_rollout
436+
- name: Submit production build for App Store review and a slow rollout
437+
if: ${{ github.ref == 'refs/heads/production' }}
438+
run: bundle exec fastlane ios submit_hybrid_for_rollout
444439
env:
445440
VERSION: ${{ steps.getIOSVersion.outputs.IOS_VERSION }}
446441
APPLE_ID: ${{ vars.APPLE_ID }}

0 commit comments

Comments
 (0)