Merge branch 'main' of https://github.com/Expensify/App into ikevin127-proposalPoliceDupe

Author: ikevin127

.eslintrc.changed.js

@@ -8,6 +8,7 @@ module.exports = {
         'deprecation/deprecation': 'error',
         'rulesdir/no-default-id-values': 'error',
         'rulesdir/provide-canBeMissing-in-useOnyx': 'error',
+        'rulesdir/no-unstable-hook-defaults': 'error',
         'no-restricted-syntax': [
             'error',
             {

.eslintrc.js

@@ -219,6 +219,7 @@ module.exports = {
         'es/no-optional-chaining': 'off',
         'deprecation/deprecation': 'off',
         'arrow-body-style': 'off',
+        'no-continue': 'off',
 
         // Import specific rules
         'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],

.github/scripts/buildActions.sh

@@ -49,14 +49,21 @@ for ((i=0; i < ${#GITHUB_ACTIONS[@]}; i++)); do
   ASYNC_BUILDS[i]=$!
 done
 
+EXIT_CODE=0
 for ((i=0; i < ${#GITHUB_ACTIONS[@]}; i++)); do
   ACTION=${GITHUB_ACTIONS[$i]}
   ACTION_DIR=$(dirname "$ACTION")
+  ACTION_NAME=$(basename "$ACTION" .ts)
 
   # Wait for the background build to finish
-  wait "${ASYNC_BUILDS[$i]}"
-
-  # Prepend the warning note to the top of the compiled file
-  OUTPUT_FILE="$ACTION_DIR/index.js"
-  echo "$NOTE_DONT_EDIT$(cat "$OUTPUT_FILE")" > "$OUTPUT_FILE"
+  if wait "${ASYNC_BUILDS[$i]}"; then
+    # Prepend the warning note to the top of the compiled file
+    OUTPUT_FILE="$ACTION_DIR/index.js"
+    echo "$NOTE_DONT_EDIT$(cat "$OUTPUT_FILE")" > "$OUTPUT_FILE"
+  else
+    echo "❌ $ACTION_NAME failed to build: $ACTION_DIR/index.js" >&2
+    EXIT_CODE=1
+  fi
 done
+
+exit $EXIT_CODE

.github/scripts/createDocsRoutes.ts

@@ -41,6 +41,7 @@ const routes = yaml.load(fs.readFileSync(`${docsDir}/_data/_routes.yml`, 'utf8')
 const platformNames = {
     expensifyClassic: 'expensify-classic',
     newExpensify: 'new-expensify',
+    travel: 'travel',
 } as const;
 
 /**
@@ -140,9 +141,11 @@ function createHubsWithArticles(hubs: string[], platformName: ValueOf<typeof pla
 function run() {
     const expensifyClassicArticleHubs = fs.readdirSync(`${docsDir}/articles/${platformNames.expensifyClassic}`);
     const newExpensifyArticleHubs = fs.readdirSync(`${docsDir}/articles/${platformNames.newExpensify}`);
+    const travelArticleHubs = fs.readdirSync(`${docsDir}/articles/${platformNames.travel}`);
 
     const expensifyClassicRoute = routes.platforms.find((platform) => platform.href === platformNames.expensifyClassic);
     const newExpensifyRoute = routes.platforms.find((platform) => platform.href === platformNames.newExpensify);
+    const travelRoute = routes.platforms.find((platform) => platform.href === platformNames.travel);
 
     if (expensifyClassicArticleHubs.length !== expensifyClassicRoute?.hubs.length) {
         console.error(warnMessage(platformNames.expensifyClassic));
@@ -154,8 +157,14 @@ function run() {
         process.exit(1);
     }
 
+    if (travelArticleHubs.length !== travelRoute?.hubs.length) {
+        console.error(warnMessage(platformNames.travel));
+        process.exit(1);
+    }
+
     createHubsWithArticles(expensifyClassicArticleHubs, platformNames.expensifyClassic, expensifyClassicRoute.hubs);
     createHubsWithArticles(newExpensifyArticleHubs, platformNames.newExpensify, newExpensifyRoute.hubs);
+    createHubsWithArticles(travelArticleHubs, platformNames.travel, travelRoute.hubs);
 
     // Convert the object to YAML and write it to the file
     let yamlString = yaml.dump(routes);

.github/workflows/createNewVersion.yml

@@ -126,11 +126,11 @@ jobs:
             echo "Race condition! E/App main was updated while this workflow was running, so push failed. Fetching remote, rebasing, and retrying push once."
             git fetch origin main
             if ! git rebase origin/main; then
-              echo "::error:: Rebase failed while retrying Mobile-Expensify push"
+              echo "::error:: Rebase failed while retrying E/App push"
               exit 1
             fi
             if ! git push origin main; then
-              echo "::error:: Mobile-Expensify change failed to push after rebase"
+              echo "::error:: E/App change failed to push after rebase"
               exit 1
             fi
           fi

.storybook/preview.tsx

@@ -3,11 +3,11 @@ import React from 'react';
 import Onyx from 'react-native-onyx';
 import {SafeAreaProvider} from 'react-native-safe-area-context';
 import type {Parameters} from 'storybook/internal/types';
+import OnyxListItemProvider from '@components/OnyxListItemProvider';
 import {SearchContextProvider} from '@components/Search/SearchContext';
 import ComposeProviders from '@src/components/ComposeProviders';
 import HTMLEngineProvider from '@src/components/HTMLEngineProvider';
 import {LocaleContextProvider} from '@src/components/LocaleContextProvider';
-import OnyxProvider from '@src/components/OnyxProvider';
 import {EnvironmentProvider} from '@src/components/withEnvironment';
 import {KeyboardStateProvider} from '@src/components/withKeyboardState';
 import ONYXKEYS from '@src/ONYXKEYS';
@@ -23,7 +23,16 @@ Onyx.init({
 const decorators = [
     (Story: React.ElementType) => (
         <ComposeProviders
-            components={[OnyxProvider, LocaleContextProvider, HTMLEngineProvider, SafeAreaProvider, PortalProvider, EnvironmentProvider, KeyboardStateProvider, SearchContextProvider]}
+            components={[
+                OnyxListItemProvider,
+                LocaleContextProvider,
+                HTMLEngineProvider,
+                SafeAreaProvider,
+                PortalProvider,
+                EnvironmentProvider,
+                KeyboardStateProvider,
+                SearchContextProvider,
+            ]}
         >
             <Story />
         </ComposeProviders>

Mobile-Expensify

@@ -114,8 +114,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009018005
-        versionName "9.1.80-5"
+        versionCode 1009018204
+        versionName "9.1.82-4"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"