You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The previous commit added two guards (snapshotPersisted check at trickle
effect start, late-arrival guard inside startTrickle) that intended to
prevent the trickle's optimistic from clobbering a canonical reportComment
that arrived during the pre-trickle setTimeout window.
Those guards broke the visible trickle in the common "server fast" case:
when the canonical reportComment lands during the 4s pre-trickle delay,
startTrickle was returning without firing [ConciergeTrickle] start. The
ui-verify spec requires the start log to fire within 15s of click; this
caused a regression.
The clobber-on-natural-completion case the guards targeted is a real
pre-existing bug, but it's separate from the revisit fix shipped in the
prior commit. Reverting the guards. The displayAfter anchoring (resume
on revisit) and TRICKLE_HARD_CAP_MS staleness gate stay.
0 commit comments