Merge branch 'main' into feat/migrate-category-selector-to-navigation

Author: jmusial

.github/actions/composite/isContributorPlus/action.yml

@@ -0,0 +1,33 @@
+name: Is Contributor+
+description: Check whether a GitHub user is a member of the Expensify/contributor-plus team. Sets IS_CPLUS=true when the user is a member, IS_CPLUS=false otherwise.
+
+inputs:
+  USERNAME:
+    description: The GitHub login of the user to check.
+    required: true
+  OS_BOTIFY_TOKEN:
+    description: OSBotify token. Needed to read team memberships (the default GITHUB_TOKEN lacks the read:org scope).
+    required: true
+
+outputs:
+  IS_CPLUS:
+    description: "'true' if the user is a member of Expensify/contributor-plus, 'false' otherwise."
+    value: ${{ steps.check.outputs.IS_CPLUS }}
+
+runs:
+  using: composite
+  steps:
+    - name: Check Contributor+ membership
+      id: check
+      shell: bash
+      env:
+        GH_TOKEN: ${{ inputs.OS_BOTIFY_TOKEN }}
+        USERNAME: ${{ inputs.USERNAME }}
+      run: |
+        if gh api "/orgs/Expensify/teams/contributor-plus/memberships/$USERNAME" --silent; then
+          echo "::notice::✅ $USERNAME is a Contributor+ member"
+          echo "IS_CPLUS=true" >> "$GITHUB_OUTPUT"
+        else
+          echo "::notice::$USERNAME is not a Contributor+ member"
+          echo "IS_CPLUS=false" >> "$GITHUB_OUTPUT"
+        fi

.github/workflows/claude-review.yml

@@ -7,25 +7,50 @@ permissions:
 on:
   pull_request_target:
     types: [opened, ready_for_review]
+  pull_request_review:
+    types: [submitted]
 
 concurrency:
   group: claude-review-${{ github.event.pull_request.html_url }}
   cancel-in-progress: true
 
 jobs:
   validate:
+    if: github.event_name == 'pull_request_target'
     uses: ./.github/workflows/contributorValidationGate.yml
     with:
       PR_NUMBER: ${{ github.event.pull_request.number }}
       PR_AUTHOR: ${{ github.event.pull_request.user.login }}
       AUTHOR_ASSOCIATION: ${{ github.event.pull_request.author_association }}
 
+  checkCPlusApproval:
+    if: github.event_name == 'pull_request_review' && github.event.review.state == 'approved'
+    runs-on: blacksmith-2vcpu-ubuntu-2404
+    outputs:
+      IS_CPLUS: ${{ steps.check.outputs.IS_CPLUS }}
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+        with:
+          fetch-depth: 1
+
+      - name: Check Contributor+ membership
+        id: check
+        uses: ./.github/actions/composite/isContributorPlus
+        with:
+          USERNAME: ${{ github.event.review.user.login }}
+          OS_BOTIFY_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
+
   review:
-    needs: [validate]
+    needs: [validate, checkCPlusApproval]
     if: |
-      needs.validate.outputs.IS_AUTHORIZED == 'true'
+      !cancelled()
       && github.event.pull_request.draft != true
       && !contains(github.event.pull_request.title, 'Revert')
+      && (
+        (github.event_name == 'pull_request_target' && needs.validate.outputs.IS_AUTHORIZED == 'true')
+        || (github.event_name == 'pull_request_review' && needs.checkCPlusApproval.outputs.IS_CPLUS == 'true')
+      )
     runs-on: blacksmith-2vcpu-ubuntu-2404
     env:
       PR_NUMBER: ${{ github.event.pull_request.number }}

src/CONST/LOCALES.ts

@@ -83,7 +83,6 @@ function isTranslationTargetLocale(locale: string): locale is TranslationTargetL
 }
 
 export {
-    BETA_LOCALES,
     EXTENDED_LOCALES,
     FULLY_SUPPORTED_LOCALES,
     LOCALES,

src/SplashScreenStateContext.tsx

@@ -72,5 +72,4 @@ function useSplashScreenActions() {
     return useContext(SplashScreenActionsContext);
 }
 
-export default SplashScreenStateContext;
 export {SplashScreenStateContextProvider, useSplashScreenState, useSplashScreenActions};

src/components/ActionSheetAwareScrollView/__mocks__/index.android.tsx

@@ -1,11 +1,5 @@
 import {Actions, ActionSheetAwareScrollViewProvider, useActionSheetAwareScrollViewActions, useActionSheetAwareScrollViewState} from './ActionSheetAwareScrollViewContext';
 
-function ActionSheetAwareScrollView() {
-    return null;
-}
-
-export default ActionSheetAwareScrollView;
-
 const renderScrollComponent = undefined;
 
 export {renderScrollComponent, ActionSheetAwareScrollViewProvider, Actions, useActionSheetAwareScrollViewState, useActionSheetAwareScrollViewActions};

src/components/ActionSheetAwareScrollView/__mocks__/index.ios.tsx

@@ -1,11 +1,5 @@
 import {Actions, ActionSheetAwareScrollViewProvider, useActionSheetAwareScrollViewActions, useActionSheetAwareScrollViewState} from './ActionSheetAwareScrollViewContext';
 
-function ActionSheetAwareScrollView() {
-    return null;
-}
-
-export default ActionSheetAwareScrollView;
-
 const renderScrollComponent = undefined;
 
 export {renderScrollComponent, ActionSheetAwareScrollViewProvider, Actions, useActionSheetAwareScrollViewState, useActionSheetAwareScrollViewActions};

src/components/ActionSheetAwareScrollView/__mocks__/index.tsx

@@ -1,11 +1,5 @@
 import {Actions, ActionSheetAwareScrollViewProvider, useActionSheetAwareScrollViewActions, useActionSheetAwareScrollViewState} from './ActionSheetAwareScrollViewContext';
 
-function ActionSheetAwareScrollView() {
-    return null;
-}
-
-export default ActionSheetAwareScrollView;
-
 const renderScrollComponent = undefined;
 
 export {renderScrollComponent, ActionSheetAwareScrollViewProvider, Actions, useActionSheetAwareScrollViewState, useActionSheetAwareScrollViewActions};

src/components/ActionSheetAwareScrollView/index.android.tsx

@@ -22,8 +22,6 @@ function ActionSheetAwareScrollView({style, children, ref, ...restProps}: Action
     );
 }
 
-export default ActionSheetAwareScrollView;
-
 /**
  * This function should be used as renderScrollComponent prop for FlatList
  * @param props - props that will be passed to the ScrollView from FlatList

src/components/ActionSheetAwareScrollView/index.ios.tsx

@@ -28,8 +28,6 @@ function ActionSheetAwareScrollView({style, children, ref, ...restProps}: Action
     );
 }
 
-export default ActionSheetAwareScrollView;
-
 /**
  * This function should be used as renderScrollComponent prop for FlatList
  * @param props - props that will be passed to the ScrollView from FlatList

src/components/ActionSheetAwareScrollView/index.tsx

@@ -20,8 +20,6 @@ function ActionSheetAwareScrollView({children, ref, ...restProps}: ActionSheetAw
     );
 }
 
-export default ActionSheetAwareScrollView;
-
 /**
  * The bottom spacing config for this action sheet is only used on Android and iOS. On other platforms,
  * this component will be a default Reanimated.ScrollView, because the onScroll handler used is from Reanimated.