Optimistically update original report totals when moving held expenses to a new hold report

When a user partially approves or pays an expense report offline, the held
transactions are reassigned to a new hold report inside
getReportFromHoldRequestsOnyxData, but the original report's total and
nonReimbursableTotal fields were never updated. As a result, after the
optimistic merge the original report still carried its pre-move total while
hasHeldExpenses returned false, causing getTotalAmountForIOUReportPreviewButton
to fall through to reimbursableSpend derived from the stale total and display
the wrong Pay amount.

This change updates the original iouReport's total and nonReimbursableTotal to
the previously-stored unheld amounts whenever the utility actually moved any
held transactions, and adds a matching failure rollback. Because both the
approve and pay partial flows share this utility, both inherit the fix.
unheldTotal is intentionally left unchanged — after the move, every remaining
transaction is unheld, so the existing unheldTotal value already equals the
new total.

Author: wildan-m

src/libs/actions/IOU/index.ts

@@ -4686,6 +4686,14 @@ function getReportFromHoldRequestsOnyxData({
 
     const isApprovalEnabled = policy ? policy.approvalMode && policy.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL : false;
 
+    // After the held transactions are reassigned to the new hold report, the original iouReport
+    // only contains the previously-unheld transactions. Its total/nonReimbursableTotal must be
+    // updated optimistically so that offline consumers (e.g. the Pay button label computed from
+    // report.total via getMoneyRequestSpendBreakdown) reflect the new remaining amount instead
+    // of the stale pre-move total. unheldTotal is intentionally left unchanged because it already
+    // equals the new total once all remaining transactions on this report are unheld.
+    const shouldUpdateOriginalReportTotals = holdTransactions.length > 0 && iouReport?.unheldTotal !== undefined;
+
     const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS | typeof ONYXKEYS.COLLECTION.TRANSACTION>> = [
         {
             onyxMethod: Onyx.METHOD.MERGE,
@@ -4745,6 +4753,17 @@ function getReportFromHoldRequestsOnyxData({
         },
     ];
 
+    if (shouldUpdateOriginalReportTotals) {
+        optimisticData.push({
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport?.reportID}`,
+            value: {
+                total: iouReport?.unheldTotal ?? 0,
+                nonReimbursableTotal: iouReport?.unheldNonReimbursableTotal ?? 0,
+            },
+        });
+    }
+
     const bringReportActionsBack: Record<string, OnyxTypes.ReportAction> = {};
     for (const reportAction of holdReportActions) {
         bringReportActionsBack[reportAction.reportActionID] = reportAction;
@@ -4815,6 +4834,17 @@ function getReportFromHoldRequestsOnyxData({
         },
     ];
 
+    if (shouldUpdateOriginalReportTotals) {
+        failureData.push({
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport?.reportID}`,
+            value: {
+                total: iouReport?.total,
+                nonReimbursableTotal: iouReport?.nonReimbursableTotal,
+            },
+        });
+    }
+
     // Copy submission/approval actions to the new report
     const [copiedActionsOptimistic, copiedActionsSuccess, copiedActionsFailure, optimisticReportActionCopyIDs] = getDuplicateActionsForPartialReport(
         iouReport?.reportID,