Skip to content

Commit 262692a

Browse files
committed
fix: card reconciliation for QBD is unresponsive
1 parent f660f73 commit 262692a

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

src/ROUTES.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,12 @@ const ROUTES = {
11181118
},
11191119
WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED: {
11201120
route: 'workspaces/:policyID/accounting/quickbooks-desktop/advanced',
1121-
getRoute: (policyID: string) => `workspaces/${policyID}/accounting/quickbooks-desktop/advanced` as const,
1121+
getRoute: (policyID?: string) => {
1122+
if (!policyID) {
1123+
Log.warn('Invalid policyID is used to build the WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED route');
1124+
}
1125+
return `workspaces/${policyID}/accounting/quickbooks-desktop/advanced` as const;
1126+
},
11221127
},
11231128
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_DATE_SELECT: {
11241129
route: 'workspaces/:policyID/accounting/quickbooks-desktop/export/date-select',

src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ function CardReconciliationPage({policy, route}: CardReconciliationPageProps) {
9999
case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
100100
Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID));
101101
break;
102+
case CONST.POLICY.CONNECTIONS.ROUTE.QBD:
103+
Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.getRoute(policyID));
104+
break;
102105
default:
103106
break;
104107
}

src/pages/workspace/accounting/utils.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ function getAccountingIntegrationData(
281281
),
282282
onImportPagePress: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_IMPORT.getRoute(policyID)),
283283
onExportPagePress: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT.getRoute(policyID)),
284-
onCardReconciliationPagePress: () => {},
284+
onCardReconciliationPagePress: () => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_CARD_RECONCILIATION.getRoute(policyID, CONST.POLICY.CONNECTIONS.ROUTE.QBD)),
285285
onAdvancedPagePress: () => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.getRoute(policyID)),
286286
subscribedImportSettings: [
287287
CONST.QUICKBOOKS_DESKTOP_CONFIG.ENABLE_NEW_CATEGORIES,

0 commit comments

Comments
 (0)