Remove deferred scheduleNavigationCheck pattern for simplicity

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>

Author: MelvinBot

src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts

@@ -25,23 +25,6 @@ function resetSessionFlag() {
     hasRedirectedToMigratedUserModal = false;
 }
 
-let pendingNavigationCheck: ReturnType<typeof setTimeout> | undefined;
-
-/**
- * Schedules a deferred navigation check. The check is deferred to the next event loop tick
- * so it doesn't run synchronously inside Onyx callbacks, which would interfere with
- * Onyx batch processing and cause extra component renders.
- */
-function scheduleNavigationCheck() {
-    if (pendingNavigationCheck !== undefined) {
-        return;
-    }
-    pendingNavigationCheck = setTimeout(() => {
-        pendingNavigationCheck = undefined;
-        navigateToMigratedUserWelcomeModalIfReady();
-    }, 0);
-}
-
 /**
  * Proactively navigate to the migrated user welcome modal when all conditions are met,
  * without waiting for a user-initiated navigation action.
@@ -70,15 +53,15 @@ function navigateToMigratedUserWelcomeModalIfReady() {
 function onSessionOrLoadingAppChanged(sessionValue: OnyxEntry<Session>, isLoadingAppValue: boolean) {
     session = sessionValue;
     isLoadingApp = isLoadingAppValue;
-    scheduleNavigationCheck();
+    navigateToMigratedUserWelcomeModalIfReady();
 }
 
 Onyx.connectWithoutView({
     key: ONYXKEYS.NVP_TRY_NEW_DOT,
     callback: (value) => {
         const result = value ? tryNewDotOnyxSelector(value) : undefined;
         hasBeenAddedToNudgeMigration = result?.hasBeenAddedToNudgeMigration ?? false;
-        scheduleNavigationCheck();
+        navigateToMigratedUserWelcomeModalIfReady();
     },
 });