Skip to content

Commit 2c8cb2e

Browse files
committed
fix: lint
1 parent 45213be commit 2c8cb2e

6 files changed

Lines changed: 6 additions & 41 deletions

File tree

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersGroupByPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function SearchFiltersGroupByPage() {
2929
keyForList: groupOption.value,
3030
isSelected: selectedItem === groupOption.value,
3131
}));
32-
}, [selectedItem, translate]);
32+
}, [selectedItem]);
3333

3434
const updateSelectedItem = useCallback((type: ListItem<SearchGroupBy>) => {
3535
setSelectedItem(type?.keyForList ?? undefined);

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function SearchFiltersTypePage() {
3232
keyForList: typeOption.value,
3333
isSelected: selectedItem === typeOption.value,
3434
}));
35-
}, [allPolicies, selectedItem, session?.email, translate]);
35+
}, [allPolicies, selectedItem, session?.email]);
3636

3737
const updateSelectedItem = useCallback((type: ListItem<SearchDataTypes>) => {
3838
setSelectedItem(type?.keyForList ?? CONST.SEARCH.DATA_TYPES.EXPENSE);

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -345,22 +345,7 @@ function IOURequestStepConfirmation({
345345

346346
// This has selected the participants from the beginning and the participant field shouldn't be editable.
347347
navigateToStartMoneyRequestStep(requestType, iouType, initialTransactionID, reportID, action);
348-
}, [
349-
action,
350-
isPerDiemRequest,
351-
transaction?.isFromGlobalCreate,
352-
transaction?.receipt?.isTestReceipt,
353-
transaction?.receipt?.isTestDriveReceipt,
354-
transaction?.participantsAutoAssigned,
355-
transaction?.reportID,
356-
transaction?.participants,
357-
requestType,
358-
iouType,
359-
initialTransactionID,
360-
reportID,
361-
participantsAutoAssignedFromRoute,
362-
isMovingTransactionFromTrackExpense,
363-
]);
348+
}, [action, isPerDiemRequest, transaction?.isFromGlobalCreate, transaction.receipt?.isTestReceipt, transaction.receipt?.isTestDriveReceipt, transaction.participants, transaction?.participantsAutoAssigned, transaction?.reportID, requestType, iouType, initialTransactionID, reportID, isMovingTransactionFromTrackExpense, participantsAutoAssignedFromRoute, isBetaEnabled]);
364349

365350
const navigateToAddReceipt = useCallback(() => {
366351
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(action, iouType, initialTransactionID, reportID, Navigation.getActiveRouteWithoutParams()));

src/pages/iou/request/step/IOURequestStepParticipants.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ function IOURequestStepParticipants({
173173
Navigation.navigate(iouConfirmationPageRoute);
174174
}
175175
});
176-
}, [action, backTo, selfDMReport, selfDMReportID, transactions, initialTransactionID, waitForKeyboardDismiss]);
176+
}, [selfDMReportID, transactions, action, initialTransactionID, waitForKeyboardDismiss, isBetaEnabled, iouType, selfDMReport, isActivePolicyRequest, backTo]);
177177

178178
const addParticipant = useCallback(
179179
(val: Participant[]) => {

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -481,27 +481,7 @@ function IOURequestStepScan({
481481
navigateToParticipantPage(iouType, initialTransactionID, reportID);
482482
}
483483
},
484-
[
485-
backTo,
486-
report,
487-
reportNameValuePairs,
488-
iouType,
489-
initialTransaction?.participants,
490-
initialTransaction?.currency,
491-
initialTransaction?.reportID,
492-
activePolicy,
493-
initialTransactionID,
494-
navigateToConfirmationPage,
495-
shouldSkipConfirmation,
496-
personalDetails,
497-
createTransaction,
498-
currentUserPersonalDetails?.login,
499-
currentUserPersonalDetails.accountID,
500-
reportID,
501-
transactionTaxCode,
502-
transactionTaxAmount,
503-
policy,
504-
],
484+
[backTo, report, reportNameValuePairs, iouType, activePolicy, initialTransactionID, navigateToConfirmationPage, shouldSkipConfirmation, personalDetails, createTransaction, currentUserPersonalDetails?.login, currentUserPersonalDetails.accountID, reportID, initialTransaction?.currency, initialTransaction?.participants, initialTransaction?.reportID, transactionTaxCode, transactionTaxAmount, policy, selfDMReportID],
505485
);
506486

507487
const updateScanAndNavigate = useCallback(

src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ function PolicyAccountingPage({policy}: PolicyAccountingPageProps) {
514514
}
515515
// Else, display the following and link to their Concierge DM.
516516
return [translate('workspace.accounting.talkToConcierge'), conciergeReportID];
517-
}, [account, conciergeReportID, translate]);
517+
}, [account?.accountManagerAccountID, account?.accountManagerReportID, conciergeReportID, policy?.chatReportIDAdmins, translate]);
518518

519519
return (
520520
<AccessOrNotFoundWrapper

0 commit comments

Comments
 (0)