Skip to content

Commit 2d63fcd

Browse files
authored
Merge pull request Expensify#76576 from bernhardoj/fix/76242-md-not-applied-if-there-is-custom-emoji
2 parents 02e9f44 + 608da6d commit 2d63fcd

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/components/EmojiWithTooltip/index.ios.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@ import type EmojiWithTooltipProps from './types';
55

66
function EmojiWithTooltip({emojiCode, style = {}, isMedium = false}: EmojiWithTooltipProps) {
77
const styles = useThemeStyles();
8+
const isCustomEmoji = emojiCode === '\uE100';
89

910
return isMedium ? (
1011
<Text style={style}>
1112
<View>
12-
<Text style={styles.emojisWithTextFontSizeAligned}>{emojiCode}</Text>
13+
<Text style={[styles.emojisWithTextFontSizeAligned, isCustomEmoji && styles.customEmojiFontAlignment]}>{emojiCode}</Text>
1314
</View>
1415
</Text>
1516
) : (
16-
<Text style={style}>{emojiCode}</Text>
17+
<Text style={[style, isCustomEmoji && styles.customEmojiFontAlignment]}>{emojiCode}</Text>
1718
);
1819
}
1920

src/pages/home/report/comment/TextCommentFragment.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import useTheme from '@hooks/useTheme';
1111
import useThemeStyles from '@hooks/useThemeStyles';
1212
import convertToLTR from '@libs/convertToLTR';
1313
import {canUseTouchScreen} from '@libs/DeviceCapabilities';
14-
import {containsCustomEmoji, containsOnlyCustomEmoji as containsOnlyCustomEmojiUtil, containsOnlyEmojis as containsOnlyEmojisUtil, splitTextWithEmojis} from '@libs/EmojiUtils';
14+
import {containsOnlyCustomEmoji as containsOnlyCustomEmojiUtil, containsOnlyEmojis as containsOnlyEmojisUtil, splitTextWithEmojis} from '@libs/EmojiUtils';
1515
import Parser from '@libs/Parser';
1616
import Performance from '@libs/Performance';
1717
import {getHtmlWithAttachmentID, getTextFromHtml} from '@libs/ReportActionsUtils';
@@ -76,7 +76,7 @@ function TextCommentFragment({fragment, styleAsDeleted, reportActionID, styleAsM
7676
const containsOnlyEmojis = containsOnlyEmojisUtil(text ?? '');
7777
const containsOnlyCustomEmoji = useMemo(() => containsOnlyCustomEmojiUtil(text), [text]);
7878
const containsEmojis = CONST.REGEX.ALL_EMOJIS.test(text ?? '');
79-
if (!shouldRenderAsText(html, text ?? '') && !(containsOnlyEmojis && styleAsDeleted) && (containsOnlyEmojis || !containsCustomEmoji(text))) {
79+
if (!shouldRenderAsText(html, text ?? '') && !(containsOnlyEmojis && styleAsDeleted)) {
8080
const editedTag = fragment?.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''}></edited>` : '';
8181
// We need to replace the space at the beginning of each line with &nbsp;
8282
const escapedHtml = html.replaceAll(/(^|<br \/>)[ ]+/gm, (match: string, p1: string) => p1 + '&nbsp;'.repeat(match.length - p1.length));

0 commit comments

Comments
 (0)