Refactor reportAttributes badge logic to preserve original control flow

Restructure the Submit-badge-priority logic to use the original sequential
if-block pattern instead of an if/else wrapper. This maintains the same
execution flow that the perf test baseline expects while still achieving
the desired behavior: when a report is ready to submit, always show the
green Submit badge regardless of violations.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

Author: MelvinBot

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

@@ -299,36 +299,30 @@ export default createOnyxDerivedValueConfig({
 
                 // When the report is ready to submit, always show the green Submit badge
                 // regardless of violations — the user should submit first, then fix.
-                if (requiresAttention && actionGreenBadge === CONST.REPORT.ACTION_BADGE.SUBMIT) {
-                    if (reasonAndReportAction) {
-                        needsParentChatErrorPropagation = true;
+                const willShowGreenSubmit = requiresAttention && actionGreenBadge === CONST.REPORT.ACTION_BADGE.SUBMIT;
+
+                // if report has errors or violations, show red dot
+                if (reasonAndReportAction) {
+                    needsParentChatErrorPropagation = true;
+
+                    // RBR/Fix mirrors GBR's access rule: only show on the child when the user can't already
+                    // see it on the parent workspace chat. The parent still gets ERROR/FIX through the
+                    // propagation loop below, so the actionable indicator surfaces on the workspace chat row
+                    // (which is where C+ wants it). Skips when the chat parent isn't accessible to the user.
+                    // Also skip setting ERROR when we'll show the green Submit badge — let the user submit first.
+                    const chatPolicy = chatReport?.policyID ? policies?.[`${ONYXKEYS.COLLECTION.POLICY}${chatReport.policyID}`] : undefined;
+                    const isChildOfAccessiblePolicyExpenseChat = !!chatReport && isPolicyExpenseChat(chatReport) && (!!chatReport.isOwnPolicyExpenseChat || isPolicyAdmin(chatPolicy));
+                    if (!isChildOfAccessiblePolicyExpenseChat && !willShowGreenSubmit) {
+                        brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
+                        actionBadge = CONST.REPORT.ACTION_BADGE.FIX;
+                        actionTargetReportActionID = reasonAndReportAction.reportAction?.reportActionID;
                     }
+                }
+                // if report does not have error, check if it should show green dot
+                if (brickRoadStatus !== CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR && requiresAttention) {
                     brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
                     actionBadge = actionGreenBadge;
                     actionTargetReportActionID = actionGreenTargetReportActionID;
-                } else {
-                    // if report has errors or violations, show red dot
-                    if (reasonAndReportAction) {
-                        needsParentChatErrorPropagation = true;
-
-                        // RBR/Fix mirrors GBR's access rule: only show on the child when the user can't already
-                        // see it on the parent workspace chat. The parent still gets ERROR/FIX through the
-                        // propagation loop below, so the actionable indicator surfaces on the workspace chat row
-                        // (which is where C+ wants it). Skips when the chat parent isn't accessible to the user.
-                        const chatPolicy = chatReport?.policyID ? policies?.[`${ONYXKEYS.COLLECTION.POLICY}${chatReport.policyID}`] : undefined;
-                        const isChildOfAccessiblePolicyExpenseChat = !!chatReport && isPolicyExpenseChat(chatReport) && (!!chatReport.isOwnPolicyExpenseChat || isPolicyAdmin(chatPolicy));
-                        if (!isChildOfAccessiblePolicyExpenseChat) {
-                            brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
-                            actionBadge = CONST.REPORT.ACTION_BADGE.FIX;
-                            actionTargetReportActionID = reasonAndReportAction.reportAction?.reportActionID;
-                        }
-                    }
-                    // if report does not have error, check if it should show green dot
-                    if (brickRoadStatus !== CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR && requiresAttention) {
-                        brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
-                        actionBadge = actionGreenBadge;
-                        actionTargetReportActionID = actionGreenTargetReportActionID;
-                    }
                 }
 
                 acc[report.reportID] = {