Merge pull request Expensify#85193 from Burhan-Rashid/fix/75556

fix: current active menu button not getting announced in settings profile page

Author: mollfpr

src/components/MenuItem.tsx

@@ -797,6 +797,7 @@ function MenuItem({
                                 role={interactive ? role : undefined}
                                 accessibilityLabel={`${enhancedAccessibilityLabel}${brickRoadIndicator ? `. ${translate('common.yourReviewIsRequired')}` : ''}`}
                                 accessible={shouldBeAccessible}
+                                accessibilityState={role === CONST.ROLE.TAB ? {selected: focused} : undefined}
                                 tabIndex={interactive ? tabIndex : -1}
                                 onFocus={onFocus}
                                 sentryLabel={sentryLabel}

src/pages/Search/SavedSearchList.tsx

@@ -86,6 +86,7 @@ function SavedSearchList({hash}: SavedSearchListProps) {
 
         return {
             ...baseMenuItem,
+            role: CONST.ROLE.TAB,
             sentryLabel: CONST.SENTRY_LABEL.SEARCH.SAVED_SEARCH_MENU_ITEM,
             onPress: () => {
                 setSearchContext(false);

src/pages/Search/SearchTypeMenuItem.tsx

@@ -41,7 +41,8 @@ function SearchTypeMenuItem({title, icon, badgeText, focused = false, onPress}:
         <PressableWithoutFeedback
             onPress={onPress}
             accessibilityLabel={title}
-            role={CONST.ROLE.BUTTON}
+            accessibilityState={{selected: focused}}
+            role={CONST.ROLE.TAB}
             sentryLabel={CONST.SENTRY_LABEL.SEARCH.TYPE_MENU_ITEM}
             style={({hovered, pressed}) => [
                 styles.flexRow,

src/pages/settings/InitialSettingsPage.tsx

@@ -470,6 +470,7 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr
                             shouldBlockSelection={!!item.link}
                             onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined}
                             focused={isFocused}
+                            role={CONST.ROLE.TAB}
                             isPaneMenu
                             sentryLabel={item.sentryLabel}
                             iconRight={item.iconRight}

src/pages/workspace/WorkspaceInitialPage.tsx

@@ -478,6 +478,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac
                                     wrapperStyle={styles.sectionMenuItem(shouldUseNarrowLayout)}
                                     highlighted={!!item?.highlighted}
                                     focused={!!(item.screenName && activeRoute?.startsWith(item.screenName))}
+                                    role={CONST.ROLE.TAB}
                                     badgeText={item.badgeText}
                                     shouldIconUseAutoWidthStyle
                                     sentryLabel={item.sentryLabel}