Skip to content

Commit 2e79b66

Browse files
nkuochnkuoch
authored
Merge pull request Expensify#68678 from Expensify/jules-clearUpChecklistDebugging
Remove temporary 'Deployer FYI' note from staging checklist generation
2 parents 62a9731 + c2a38de commit 2e79b66

19 files changed

Lines changed: 21 additions & 78 deletions

File tree

‎.github/actions/javascript/authorChecklist/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15908,12 +15908,9 @@ class GithubUtils {
1590815908
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1590915909
}
1591015910
issueBody += '\r\n';
15911-
// Warn deployers about potential bugs with the new process
15912-
issueBody +=
15913-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1591415911
// PR list
1591515912
if (sortedPRList.length > 0) {
15916-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
15913+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1591715914
sortedPRList.forEach((URL) => {
1591815915
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1591915916
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/awaitStagingDeploys/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12689,12 +12689,9 @@ class GithubUtils {
1268912689
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1269012690
}
1269112691
issueBody += '\r\n';
12692-
// Warn deployers about potential bugs with the new process
12693-
issueBody +=
12694-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1269512692
// PR list
1269612693
if (sortedPRList.length > 0) {
12697-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
12694+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1269812695
sortedPRList.forEach((URL) => {
1269912696
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1270012697
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/checkAndroidStatus/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -737392,12 +737392,9 @@ class GithubUtils {
737392737392
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
737393737393
}
737394737394
issueBody += '\r\n';
737395-
// Warn deployers about potential bugs with the new process
737396-
issueBody +=
737397-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
737398737395
// PR list
737399737396
if (sortedPRList.length > 0) {
737400-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
737397+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
737401737398
sortedPRList.forEach((URL) => {
737402737399
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
737403737400
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/checkDeployBlockers/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11956,12 +11956,9 @@ class GithubUtils {
1195611956
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1195711957
}
1195811958
issueBody += '\r\n';
11959-
// Warn deployers about potential bugs with the new process
11960-
issueBody +=
11961-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1196211959
// PR list
1196311960
if (sortedPRList.length > 0) {
11964-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
11961+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1196511962
sortedPRList.forEach((URL) => {
1196611963
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1196711964
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/createOrUpdateStagingDeploy/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12243,12 +12243,9 @@ class GithubUtils {
1224312243
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1224412244
}
1224512245
issueBody += '\r\n';
12246-
// Warn deployers about potential bugs with the new process
12247-
issueBody +=
12248-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1224912246
// PR list
1225012247
if (sortedPRList.length > 0) {
12251-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
12248+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1225212249
sortedPRList.forEach((URL) => {
1225312250
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1225412251
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/getArtifactInfo/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11917,12 +11917,9 @@ class GithubUtils {
1191711917
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1191811918
}
1191911919
issueBody += '\r\n';
11920-
// Warn deployers about potential bugs with the new process
11921-
issueBody +=
11922-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1192311920
// PR list
1192411921
if (sortedPRList.length > 0) {
11925-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
11922+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1192611923
sortedPRList.forEach((URL) => {
1192711924
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1192811925
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/getDeployPullRequestList/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12262,12 +12262,9 @@ class GithubUtils {
1226212262
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1226312263
}
1226412264
issueBody += '\r\n';
12265-
// Warn deployers about potential bugs with the new process
12266-
issueBody +=
12267-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1226812265
// PR list
1226912266
if (sortedPRList.length > 0) {
12270-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
12267+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1227112268
sortedPRList.forEach((URL) => {
1227212269
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1227312270
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/getPreviousVersion/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12073,12 +12073,9 @@ class GithubUtils {
1207312073
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1207412074
}
1207512075
issueBody += '\r\n';
12076-
// Warn deployers about potential bugs with the new process
12077-
issueBody +=
12078-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1207912076
// PR list
1208012077
if (sortedPRList.length > 0) {
12081-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
12078+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1208212079
sortedPRList.forEach((URL) => {
1208312080
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1208412081
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/getPullRequestDetails/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12046,12 +12046,9 @@ class GithubUtils {
1204612046
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1204712047
}
1204812048
issueBody += '\r\n';
12049-
// Warn deployers about potential bugs with the new process
12050-
issueBody +=
12051-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1205212049
// PR list
1205312050
if (sortedPRList.length > 0) {
12054-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
12051+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1205512052
sortedPRList.forEach((URL) => {
1205612053
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1205712054
issueBody += ` ${URL}\r\n`;

‎.github/actions/javascript/isStagingDeployLocked/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11917,12 +11917,9 @@ class GithubUtils {
1191711917
issueBody += `**Mobile-Expensify Changes:** https://github.com/${CONST_1.default.GITHUB_OWNER}/${CONST_1.default.MOBILE_EXPENSIFY_REPO}/compare/production...staging\r\n`;
1191811918
}
1191911919
issueBody += '\r\n';
11920-
// Warn deployers about potential bugs with the new process
11921-
issueBody +=
11922-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
1192311920
// PR list
1192411921
if (sortedPRList.length > 0) {
11925-
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';
11922+
issueBody += '**This release contains changes from the following pull requests:**\r\n';
1192611923
sortedPRList.forEach((URL) => {
1192711924
issueBody += verifiedOrNoQAPRs.includes(URL) ? '- [x]' : '- [ ]';
1192811925
issueBody += ` ${URL}\r\n`;

0 commit comments

Comments
 (0)