Skip to content

Commit 2ec5a48

Browse files
authored
Merge pull request Expensify#67493 from shubham1206agra/refactor-onyx-19
[NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in betaChecker
2 parents 540415f + 329632b commit 2ec5a48

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
4747
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
4848
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
49-
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=313 --cache --cache-location=node_modules/.cache/eslint",
49+
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=312 --cache --cache-location=node_modules/.cache/eslint",
5050
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
5151
"lint-watch": "npx eslint-watch --watch --changed",
5252
"shellcheck": "./scripts/shellCheck.sh",

src/libs/Environment/betaChecker/index.android.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ type GithubReleaseJSON = {
1212
};
1313

1414
let isLastSavedBeta = false;
15-
Onyx.connect({
15+
// We have opted for `connectWithoutView` here as this is a strictly non-UI data.
16+
Onyx.connectWithoutView({
1617
key: ONYXKEYS.IS_BETA,
1718
callback: (value) => {
1819
isLastSavedBeta = !!value;

0 commit comments

Comments
 (0)