Revert "fix: Screen Reader: Many Pages: There is no dialog role and title announced"

Author: amyevans

src/CONST/index.ts

@@ -5858,8 +5858,6 @@ const CONST = {
         NAVIGATION: 'navigation',
         /** Use for Tooltips */
         TOOLTIP: 'tooltip',
-        /** Use for dialog/modal elements */
-        DIALOG: 'dialog',
         /** Use for data table containers. */
         TABLE: 'table',
         /** Use for table rows. */

src/components/DialogLabelContext.tsx

@@ -1,11 +1,9 @@
 import type {ReactNode} from 'react';
-import React, {useEffect, useMemo, useRef} from 'react';
+import React, {useMemo} from 'react';
 import type {StyleProp, TextStyle, ViewStyle} from 'react-native';
 import {Linking, View} from 'react-native';
-import useDialogTitleFocus from '@hooks/useDialogTitleFocus';
 import useThemeStyles from '@hooks/useThemeStyles';
 import CONST from '@src/CONST';
-import {useDialogLabelActions} from './DialogLabelContext';
 import EnvironmentBadge from './EnvironmentBadge';
 import Text from './Text';
 import TextLink from './TextLink';
@@ -38,37 +36,6 @@ type HeaderProps = {
 
 function Header({title = '', subtitle = '', textStyles = [], style, containerStyles = [], shouldShowEnvironmentBadge = false, subTitleLink = '', numberOfTitleLines = 2}: HeaderProps) {
     const styles = useThemeStyles();
-    const {isInsideDialog, pushLabel, popLabel, updateLabel} = useDialogLabelActions();
-    const labelIdRef = useRef<number | undefined>(undefined);
-    const titleRef = useRef<React.ComponentRef<typeof Text>>(null);
-
-    // Register/update label in dialog context (non-string titles are skipped).
-    useEffect(() => {
-        if (!isInsideDialog || typeof title !== 'string' || !title) {
-            return;
-        }
-        if (labelIdRef.current === undefined) {
-            labelIdRef.current = pushLabel(title);
-        } else {
-            updateLabel(labelIdRef.current, title);
-        }
-    }, [isInsideDialog, title, pushLabel, updateLabel]);
-
-    // Focus title after RHP transition completes (web only, no-op on native)
-    useDialogTitleFocus(titleRef, isInsideDialog);
-
-    // Cleanup label on unmount
-    useEffect(
-        () => () => {
-            if (labelIdRef.current === undefined) {
-                return;
-            }
-            popLabel(labelIdRef.current);
-            labelIdRef.current = undefined;
-        },
-        [popLabel],
-    );
-
     const renderedSubtitle = useMemo(
         () => (
             <>
@@ -109,12 +76,10 @@ function Header({title = '', subtitle = '', textStyles = [], style, containerSty
                 {typeof title === 'string'
                     ? !!title && (
                           <Text
-                              ref={isInsideDialog ? titleRef : undefined}
                               numberOfLines={numberOfTitleLines}
                               style={[styles.headerText, styles.textLarge, styles.lineHeightXLarge, textStyles]}
                               accessibilityRole={CONST.ROLE.HEADER}
                               accessibilityLabel={title}
-                              tabIndex={isInsideDialog ? -1 : undefined}
                           >
                               {title}
                           </Text>