Fix stale TRANSACTION_DRAFT entry after editing split expense amount

setSplitShares and resetSplitShares unconditionally wrote to
TRANSACTION_DRAFT even when editing an existing (non-draft) split
transaction. This left an orphaned entry that was never cleaned up,
causing the next new expense to show "Create 2 expenses" on the
confirmation page.

Add an isDraft parameter (default true) to both functions, matching
the pattern used by setMoneyRequestCreated and other peer functions.
Pass isDraft=false from IOURequestStepAmount when editing.

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

Author: MelvinBot

src/libs/actions/IOU/Split.ts

@@ -1077,15 +1077,17 @@ function completeSplitBill(
 /**
  * Sets the `splitShares` map that holds individual shares of a split bill
  */
-function setSplitShares(transaction: OnyxEntry<OnyxTypes.Transaction>, amount: number, currency: string, newAccountIDs: number[]) {
+function setSplitShares(transaction: OnyxEntry<OnyxTypes.Transaction>, amount: number, currency: string, newAccountIDs: number[], isDraft = true) {
     if (!transaction) {
         return;
     }
 
+    const collectionKey = isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION;
+
     // For pending split distance requests, we don't want to set split shares to zero amount
     // instead we will reset it which would mean splitting the amount equally when the pending distance is resolved.
     if (isDistanceRequestTransactionUtils(transaction) && !amount) {
-        Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, {splitShares: null});
+        Onyx.merge(`${collectionKey}${transaction.transactionID}`, {splitShares: null});
         return;
     }
 
@@ -1116,18 +1118,18 @@ function setSplitShares(transaction: OnyxEntry<OnyxTypes.Transaction>, amount: n
         return acc;
     }, {});
 
-    Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transaction.transactionID}`, {splitShares});
+    Onyx.merge(`${collectionKey}${transaction.transactionID}`, {splitShares});
 }
 
-function resetSplitShares(transaction: OnyxEntry<OnyxTypes.Transaction>, newAmount?: number, currency?: string) {
+function resetSplitShares(transaction: OnyxEntry<OnyxTypes.Transaction>, newAmount?: number, currency?: string, isDraft = true) {
     if (!transaction) {
         return;
     }
     const accountIDs = Object.keys(transaction.splitShares ?? {}).map((key) => Number(key));
     if (!accountIDs) {
         return;
     }
-    setSplitShares(transaction, newAmount ?? transaction.amount, currency ?? transaction.currency, accountIDs);
+    setSplitShares(transaction, newAmount ?? transaction.amount, currency ?? transaction.currency, accountIDs, isDraft);
 }
 
 function setDraftSplitTransaction(

src/pages/iou/request/step/IOURequestStepAmount.tsx

@@ -399,7 +399,7 @@ function IOURequestStepAmount({
 
         // Edits to the amount from the splits page should reset the split shares.
         if (transaction?.splitShares) {
-            resetSplitShares(transaction, newAmount, selectedCurrency);
+            resetSplitShares(transaction, newAmount, selectedCurrency, !isEditing);
         }
 
         if (!isEditing) {