refactor toggleProfileTool

Author: allgandalf

src/components/RecordTroubleshootDataToolMenu/BaseRecordTroubleshootDataToolMenu.tsx

@@ -87,7 +87,7 @@ function BaseRecordTroubleshootDataToolMenu({
     const styles = useThemeStyles();
     const [shouldRecordTroubleshootData] = useOnyx(ONYXKEYS.SHOULD_RECORD_TROUBLESHOOT_DATA, {canBeMissing: true});
     const [capturedLogs] = useOnyx(ONYXKEYS.LOGS, {canBeMissing: true});
-    const [isProfilingInProgress] = useOnyx(ONYXKEYS.APP_PROFILING_IN_PROGRESS, {canBeMissing: true});
+    const [isProfilingInProgress = false] = useOnyx(ONYXKEYS.APP_PROFILING_IN_PROGRESS, {canBeMissing: true});
     const [shareUrls, setShareUrls] = useState<string[]>();
     const [isDisabled, setIsDisabled] = useState<boolean>(false);
 
@@ -103,7 +103,7 @@ function BaseRecordTroubleshootDataToolMenu({
         } else {
             Performance.disableMonitoring();
         }
-        toggleProfileTool();
+        toggleProfileTool({isProfilingInProgress});
         return () => {
             Performance.disableMonitoring();
         };

src/libs/actions/ProfilingTool.ts

@@ -3,18 +3,16 @@ import Onyx from 'react-native-onyx';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 
-let isProfilingInProgress = false;
-Onyx.connect({
-    key: ONYXKEYS.APP_PROFILING_IN_PROGRESS,
-    callback: (val) => (isProfilingInProgress = val ?? false),
-});
+type ToggleProfileToolParams = {
+    isProfilingInProgress: boolean;
+};
 
 /**
  * Toggle the test tools modal open or closed.
  * Throttle the toggle to make the modal stay open if you accidentally tap an extra time, which is easy to do.
  */
-function toggleProfileTool() {
-    const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, !isProfilingInProgress);
+function toggleProfileTool({isProfilingInProgress}: ToggleProfileToolParams) {
+    const toggle = () => Onyx.set(ONYXKEYS.APP_PROFILING_IN_PROGRESS, isProfilingInProgress);
     const throttledToggle = throttle(toggle, CONST.TIMING.TEST_TOOLS_MODAL_THROTTLE_TIME);
     throttledToggle();
 }