cleanup and reverts

Author: chiragsalian

src/CONST/index.ts

@@ -3013,7 +3013,6 @@ const CONST = {
             },
             SYNC_STAGE_TIMEOUT_MINUTES: 20,
         },
-
         ACCESS_VARIANTS: {
             PAID: 'paid',
             ADMIN: 'admin',

src/libs/AccountingUtils.ts

@@ -23,7 +23,7 @@ function getConnectionNameFromRouteParam(routeParam: ValueOf<typeof CONST.POLICY
 }
 
 function getRouteParamForConnection(connectionName: ConnectionName) {
-    return NAME_ROUTE_MAPPING[connectionName as keyof typeof NAME_ROUTE_MAPPING];
+    return NAME_ROUTE_MAPPING[connectionName];
 }
 
 export {getConnectionNameFromRouteParam, getRouteParamForConnection};

src/libs/PolicyUtils.ts

@@ -1189,15 +1189,7 @@ function getValidConnectedIntegration(policy: Policy | undefined, accountingInte
 }
 
 function hasIntegrationAutoSync(policy: Policy | undefined, connectedIntegration?: ConnectionName) {
-    const connectionConfig = connectedIntegration ? policy?.connections?.[connectedIntegration]?.config : undefined;
-    return !!(
-        connectionConfig &&
-        'autoSync' in connectionConfig &&
-        connectionConfig.autoSync &&
-        typeof connectionConfig.autoSync === 'object' &&
-        'enabled' in connectionConfig.autoSync &&
-        connectionConfig.autoSync.enabled
-    );
+    return (connectedIntegration && policy?.connections?.[connectedIntegration]?.config?.autoSync?.enabled) ?? false;
 }
 
 function hasUnsupportedIntegration(policy: Policy | undefined, accountingIntegrations?: ConnectionName[]) {

src/libs/actions/connections/index.ts

@@ -160,10 +160,12 @@ function syncConnection(policy: Policy | undefined, connectionName: PolicyConnec
     });
 }
 
-function updateManyPolicyConnectionConfigs<
-    TConnectionName extends ConnectionNameExceptNetSuite,
-    TConfigUpdate extends Partial<(Connections[TConnectionName] & {config: Record<string, unknown>})['config']>,
->(policyID: string | undefined, connectionName: TConnectionName, configUpdate: TConfigUpdate, configCurrentData: TConfigUpdate) {
+function updateManyPolicyConnectionConfigs<TConnectionName extends ConnectionNameExceptNetSuite, TConfigUpdate extends Partial<Connections[TConnectionName]['config']>>(
+    policyID: string | undefined,
+    connectionName: TConnectionName,
+    configUpdate: TConfigUpdate,
+    configCurrentData: TConfigUpdate,
+) {
     if (!policyID) {
         return;
     }

src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

@@ -12,7 +12,6 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import {getConnectionNameFromRouteParam} from '@libs/AccountingUtils';
 import {isExpensifyCardFullySetUp} from '@libs/CardUtils';
 import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
-import {hasIntegrationAutoSync} from '@libs/PolicyUtils';
 import Navigation from '@navigation/Navigation';
 import type {SettingsNavigatorParamList} from '@navigation/types';
 import AccessOrNotFoundWrapper from '@pages/workspace/AccessOrNotFoundWrapper';
@@ -76,7 +75,7 @@ function CardReconciliationPage({policy, route}: CardReconciliationPageProps) {
 
     const {connection} = route.params;
     const connectionName = getConnectionNameFromRouteParam(connection) as ConnectionName;
-    const autoSync = hasIntegrationAutoSync(policy, connectionName);
+    const autoSync = !!policy?.connections?.[connectionName]?.config?.autoSync?.enabled;
     const shouldShow = !!fullySetUpCardSetting.cardSetting?.paymentBankAccountID;
 
     const handleToggleContinuousReconciliation = (value: boolean) => {