cover empty string case

nkdengineer · nkdengineer · commit 32560ce1ab4d · 2025-06-17T11:19:23.000+07:00
diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
@@ -4019,7 +4019,8 @@ function canEditFieldOfMoneyRequest(reportAction: OnyxInputOrEntry<ReportAction>
     }
 
     if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {
-        const isUnreported = transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
+        // Unreported transaction from OldDot can have the reportID as an empty string
+        const isUnreported = !transaction?.reportID || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
         return isUnreported
             ? Object.values(allPolicies ?? {}).flatMap((currentPolicy) => getOutstandingReportsForUser(currentPolicy?.id, currentUserAccountID, allReports ?? {})).length > 0
             : getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 1;

Original file line number	Diff line number	Diff line change
`@@ -4019,7 +4019,8 @@ function canEditFieldOfMoneyRequest(reportAction: OnyxInputOrEntry<ReportAction>`
`4019`	`4019`	`}`
`4020`	`4020`
`4021`	`4021`	`if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {`
`4022`		`- const isUnreported = transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;`
	`4022`	`+ // Unreported transaction from OldDot can have the reportID as an empty string`
	`4023`	`+ const isUnreported = !transaction?.reportID \|\| transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;`
`4023`	`4024`	`return isUnreported`
`4024`	`4025`	`? Object.values(allPolicies ?? {}).flatMap((currentPolicy) => getOutstandingReportsForUser(currentPolicy?.id, currentUserAccountID, allReports ?? {})).length > 0`
`4025`	`4026`	`: getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 1;`