Remove unnecessary extra animated value

Author: blazejkustra

src/components/Modal/BaseModal.tsx

@@ -109,9 +109,10 @@ function BaseModal(
     // We need to use isSmallScreenWidth instead of shouldUseNarrowLayout to apply correct modal width
     // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
     const {isSmallScreenWidth, shouldUseNarrowLayout} = useResponsiveLayout();
-    const {sidePanelOffset, modalTranslateX} = useSidePanel();
+    const {sidePanelOffset} = useSidePanel();
     const sidePanelStyle = !shouldUseReanimatedModal && shouldApplySidePanelOffset && !isSmallScreenWidth ? {paddingRight: sidePanelOffset.current} : undefined;
-    const sidePanelReanimatedStyle = shouldUseReanimatedModal && shouldApplySidePanelOffset && !isSmallScreenWidth ? {transform: [{translateX: modalTranslateX.current}]} : undefined;
+    const sidePanelReanimatedStyle =
+        shouldUseReanimatedModal && shouldApplySidePanelOffset && !isSmallScreenWidth ? {transform: [{translateX: Animated.multiply(sidePanelOffset.current, -1)}]} : undefined;
     const keyboardStateContextValue = useKeyboardState();
 
     const insets = useSafeAreaInsets();

src/hooks/useSidePanel.ts

@@ -71,7 +71,7 @@ function useSidePanel() {
     const shouldApplySidePanelOffset = isExtraLargeScreenWidth && !shouldHideSidePanel;
     const sidePanelOffset = useRef(new Animated.Value(shouldApplySidePanelOffset ? variables.sideBarWidth : 0));
     const sidePanelTranslateX = useRef(new Animated.Value(shouldHideSidePanel ? sidePanelWidth : 0));
-    const modalTranslateX = useRef(new Animated.Value(shouldApplySidePanelOffset ? -variables.sideBarWidth : 0));
+
     useEffect(() => {
         setIsSidePanelTransitionEnded(false);
         Animated.parallel([
@@ -85,11 +85,6 @@ function useSidePanel() {
                 duration: CONST.ANIMATED_TRANSITION,
                 useNativeDriver: true,
             }),
-            Animated.timing(modalTranslateX.current, {
-                toValue: shouldApplySidePanelOffset ? -variables.sideBarWidth : 0,
-                duration: CONST.ANIMATED_TRANSITION,
-                useNativeDriver: true,
-            }),
         ]).start(() => setIsSidePanelTransitionEnded(true));
 
         // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps -- sidePanelWidth dependency caused the help panel content to slide in on window resize
@@ -121,7 +116,6 @@ function useSidePanel() {
         shouldHideToolTip,
         sidePanelOffset,
         sidePanelTranslateX,
-        modalTranslateX,
         openSidePanel,
         closeSidePanel,
     };