Skip to content

Commit 37ce226

Browse files
committed
Improve comments
1 parent dc05221 commit 37ce226

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/deploy.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ jobs:
623623
- name: Upload artifacts to GitHub Release
624624
continue-on-error: true
625625
run: |
626-
# Release asset name should follow the template: [platform]-[staging, production or blank]-[sourcemap or blank].[file extension]
626+
# Release asset name should follow the template: fileNameOnRunner#fileNameInRelease
627627
files="
628628
./android-build-artifact/Expensify-release.aab#android.aab
629629
./android-apk-artifact/Expensify.apk#android.apk
@@ -638,6 +638,7 @@ jobs:
638638
"
639639
640640
# Loop through each file and upload individually (so if one fails, we still have other platforms uploaded)
641+
# Note: Not all of these files are present for production releases, because we don't build the native apps for prod deploys. That's expected.
641642
echo -e "$files" | xargs -I {} --max-procs=4 bash -c '
642643
if gh release upload ${{ needs.prep.outputs.TAG }} --repo ${{ github.repository }} --clobber {}; then
643644
echo "✅ Successfully uploaded {}"

0 commit comments

Comments
 (0)