Skip to content

Commit 3858421

Browse files
authored
Merge pull request Expensify#68407 from Expensify/marcaaron-fixVersions
[CP Staging] Sync App version after race condition failed to recover
2 parents 55bf8af + 7cc462c commit 3858421

7 files changed

Lines changed: 13 additions & 8 deletions

File tree

.github/workflows/createNewVersion.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,12 @@ jobs:
124124
git commit -m "Update Mobile-Expensify submodule version to ${{ steps.bumpVersion.outputs.NEW_VERSION }}"
125125
if ! git push origin main; then
126126
echo "Race condition! E/App main was updated while this workflow was running, so push failed. Fetching remote, rebasing, and retrying push once."
127-
git fetch origin main
127+
if ! git fetch origin main; then
128+
echo "::error:: ❌ Unable to fetch main"
129+
echo "::error:: This can happen when Mobile-Expensify and E/App repos got out of sync."
130+
echo "::error:: We likely need to manually bump the version in E/App to match Mobile-Expensify."
131+
exit 1
132+
fi
128133
if ! git rebase origin/main; then
129134
echo "::error:: Rebase failed while retrying E/App push"
130135
exit 1

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ android {
115115
targetSdkVersion rootProject.ext.targetSdkVersion
116116
multiDexEnabled rootProject.ext.multiDexEnabled
117117
versionCode 1009019303
118-
versionName "9.1.93-3"
118+
versionName "9.1.93-4"
119119
// Supported language variants must be declared here to avoid from being removed during the compilation.
120120
// This also helps us to not include unnecessary language variants in the APK.
121121
resConfigs "en", "es"

ios/NewExpensify/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</dict>
4545
</array>
4646
<key>CFBundleVersion</key>
47-
<string>9.1.93.3</string>
47+
<string>9.1.93.4</string>
4848
<key>FullStory</key>
4949
<dict>
5050
<key>OrgId</key>

ios/NotificationServiceExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.93</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.93.3</string>
16+
<string>9.1.93.4</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionPointIdentifier</key>

ios/ShareViewController/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.93</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.93.3</string>
16+
<string>9.1.93.4</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionAttributes</key>

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "new.expensify",
3-
"version": "9.1.93-3",
3+
"version": "9.1.93-4",
44
"author": "Expensify, Inc.",
55
"homepage": "https://new.expensify.com",
66
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",

0 commit comments

Comments
 (0)