Merge pull request Expensify#88064 from Expensify/cristipaval/send-money-fraud-monitoring

Author: flodnv

src/libs/Middleware/FraudMonitoring.ts

@@ -12,7 +12,15 @@ type FraudSignal = {
     };
 };
 
-type FraudSignalFactory = (requestData?: Record<string, unknown>, responseData?: Record<string, unknown>) => FraudSignal;
+type FraudSignalFactory = (requestData?: Record<string, unknown>, responseData?: Record<string, unknown>) => FraudSignal | undefined;
+
+// Flag commands that create new accounts so the fraud protection backend can detect invite spam.
+const createNewAccountCountSignal: FraudSignalFactory = (_, responseData) => {
+    if (!responseData?.newAccountCount) {
+        return undefined;
+    }
+    return {event: FRAUD_PROTECTION_EVENT.NEW_EMAILS_INVITED, attribute: {key: 'new_account_count', value: responseData.newAccountCount as string}};
+};
 
 const fraudSignalFactoryByApiCommand: Record<string, FraudSignalFactory> = {
     [READ_COMMANDS.SIGN_IN_WITH_SUPPORT_AUTH_TOKEN]: () => ({event: FRAUD_PROTECTION_EVENT.START_SUPPORT_SESSION}),
@@ -37,14 +45,10 @@ const fraudSignalFactoryByApiCommand: Record<string, FraudSignalFactory> = {
     [WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_MANUALLY]: () => ({event: FRAUD_PROTECTION_EVENT.BUSINESS_BANK_ACCOUNT_SETUP}),
     [WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_WITH_PLAID]: () => ({event: FRAUD_PROTECTION_EVENT.BUSINESS_BANK_ACCOUNT_SETUP}),
     [WRITE_COMMANDS.ADD_PERSONAL_BANK_ACCOUNT]: () => ({event: FRAUD_PROTECTION_EVENT.PERSONAL_BANK_ACCOUNT_SETUP}),
-    [WRITE_COMMANDS.INVITE_TO_GROUP_CHAT]: (_, responseData) => {
-        const newAccountCountAttribute = responseData?.newAccountCount ? {key: 'new_account_count', value: responseData?.newAccountCount as string} : undefined;
-        return {event: FRAUD_PROTECTION_EVENT.NEW_EMAILS_INVITED, attribute: newAccountCountAttribute};
-    },
-    [WRITE_COMMANDS.INVITE_TO_ROOM]: (_, responseData) => {
-        const newAccountCountAttribute = responseData?.newAccountCount ? {key: 'new_account_count', value: responseData?.newAccountCount as string} : undefined;
-        return {event: FRAUD_PROTECTION_EVENT.NEW_EMAILS_INVITED, attribute: newAccountCountAttribute};
-    },
+    [WRITE_COMMANDS.INVITE_TO_GROUP_CHAT]: createNewAccountCountSignal,
+    [WRITE_COMMANDS.INVITE_TO_ROOM]: createNewAccountCountSignal,
+    [WRITE_COMMANDS.SEND_MONEY_ELSEWHERE]: createNewAccountCountSignal,
+    [WRITE_COMMANDS.SEND_MONEY_WITH_WALLET]: createNewAccountCountSignal,
 };
 
 const FraudMonitoring: Middleware = (response, request) =>
@@ -59,6 +63,10 @@ const FraudMonitoring: Middleware = (response, request) =>
         }
 
         const signal = createFraudSignal(request.data, responseData);
+        if (!signal) {
+            return responseData;
+        }
+
         FraudProtection.sendEvent(signal.event);
 
         if (!signal.attribute) {