Skip to content

Commit 39095a5

Browse files
committed
Resolve conflicts and fix landscape mode view
2 parents bea905d + 4e5b268 commit 39095a5

449 files changed

Lines changed: 14834 additions & 10297 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ source "https://rubygems.org"
44
ruby ">= 3.3.4"
55

66
gem "cocoapods", "= 1.16.2"
7-
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
7+
gem 'activesupport', '>= 7.2.3.1'
88
gem 'xcodeproj', '~> 1.27'
99
gem "fastlane", "~> 2", ">= 2.229.0"
1010
gem "xcpretty", "~> 0"

Gemfile.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ GEM
33
specs:
44
CFPropertyList (3.0.8)
55
abbrev (0.1.2)
6-
activesupport (7.2.3)
6+
activesupport (7.2.3.1)
77
base64
88
benchmark (>= 0.3)
99
bigdecimal
@@ -12,7 +12,7 @@ GEM
1212
drb
1313
i18n (>= 1.6, < 2)
1414
logger (>= 1.4.2)
15-
minitest (>= 5.1)
15+
minitest (>= 5.1, < 6)
1616
securerandom (>= 0.3)
1717
tzinfo (~> 2.0, >= 2.0.5)
1818
addressable (2.8.8)
@@ -45,8 +45,8 @@ GEM
4545
aws-eventstream (~> 1, >= 1.0.2)
4646
babosa (1.0.4)
4747
base64 (0.3.0)
48-
benchmark (0.3.0)
49-
bigdecimal (4.0.1)
48+
benchmark (0.5.0)
49+
bigdecimal (4.1.1)
5050
claide (1.1.0)
5151
cocoapods (1.16.2)
5252
addressable (~> 2.8)
@@ -89,8 +89,8 @@ GEM
8989
colored2 (3.1.2)
9090
commander (4.6.0)
9191
highline (~> 2.0.0)
92-
concurrent-ruby (1.3.5)
93-
connection_pool (2.5.4)
92+
concurrent-ruby (1.3.6)
93+
connection_pool (3.0.2)
9494
csv (3.3.5)
9595
declarative (0.0.20)
9696
digest-crc (0.7.0)
@@ -238,7 +238,7 @@ GEM
238238
domain_name (~> 0.5)
239239
httpclient (2.9.0)
240240
mutex_m
241-
i18n (1.14.7)
241+
i18n (1.14.8)
242242
concurrent-ruby (~> 1.0)
243243
jmespath (1.6.2)
244244
json (2.18.0)
@@ -251,7 +251,7 @@ GEM
251251
mime-types-data (3.2025.0924)
252252
mini_magick (4.13.2)
253253
mini_mime (1.1.5)
254-
minitest (5.26.1)
254+
minitest (5.27.0)
255255
molinillo (0.8.0)
256256
multi_json (1.18.0)
257257
multipart-post (2.4.1)
@@ -322,7 +322,7 @@ PLATFORMS
322322
x86_64-linux
323323

324324
DEPENDENCIES
325-
activesupport (>= 6.1.7.5, != 7.1.0)
325+
activesupport (>= 7.2.3.1)
326326
benchmark
327327
bigdecimal
328328
cocoapods (= 1.16.2)

Mobile-Expensify

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ android {
111111
minSdkVersion rootProject.ext.minSdkVersion
112112
targetSdkVersion rootProject.ext.targetSdkVersion
113113
multiDexEnabled rootProject.ext.multiDexEnabled
114-
versionCode 1009035200
115-
versionName "9.3.52-0"
114+
versionCode 1009035303
115+
versionName "9.3.53-3"
116116
// Supported language variants must be declared here to avoid from being removed during the compilation.
117117
// This also helps us to not include unnecessary language variants in the APK.
118118
resConfigs "en", "es"

android/app/src/main/java/com/expensify/chat/MainActivity.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ class MainActivity : ReactActivity() {
4646
.apply()
4747
BootSplash.init(this)
4848
super.onCreate(null)
49-
if (resources.getBoolean(R.bool.portrait_only)) {
50-
requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_PORTRAIT
51-
}
5249

5350
// Sets translucent status bar. This code is based on what the react-native StatusBar
5451
// module does, but we need to do it here to avoid the splash screen jumping on app start.

android/app/src/main/res/values-large/orientation.xml

Lines changed: 0 additions & 4 deletions
This file was deleted.

android/app/src/main/res/values-sw600dp/orientation.xml

Lines changed: 0 additions & 4 deletions
This file was deleted.

android/app/src/main/res/values/orientation.xml

Lines changed: 0 additions & 4 deletions
This file was deleted.

config/webpack/webpack.common.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
162162
{from: 'assets/fonts/web', to: 'fonts'},
163163
{from: 'assets/sounds', to: 'sounds'},
164164
{from: 'assets/pdfs', to: 'pdfs'},
165-
{from: 'node_modules/react-pdf/dist/esm/Page/AnnotationLayer.css', to: 'css/AnnotationLayer.css'},
166-
{from: 'node_modules/react-pdf/dist/esm/Page/TextLayer.css', to: 'css/TextLayer.css'},
165+
{from: 'node_modules/react-pdf/dist/Page/AnnotationLayer.css', to: 'css/AnnotationLayer.css'},
166+
{from: 'node_modules/react-pdf/dist/Page/TextLayer.css', to: 'css/TextLayer.css'},
167167
{from: '.well-known/apple-app-site-association', to: '.well-known/apple-app-site-association', toType: 'file'},
168168
{from: '.well-known/assetlinks.json', to: '.well-known/assetlinks.json'},
169169

@@ -260,7 +260,7 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
260260
// We are importing this worker as a string by using asset/source otherwise it will default to loading via an HTTPS request later.
261261
// This causes issues if we have gone offline before the pdfjs web worker is set up as we won't be able to load it from the server.
262262
{
263-
test: new RegExp('node_modules/pdfjs-dist/build/pdf.worker.min.mjs'),
263+
test: new RegExp('node_modules/pdfjs-dist/legacy/build/pdf.worker.min.mjs'),
264264
type: 'asset/source',
265265
},
266266

@@ -330,6 +330,8 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
330330
'victory-native': path.resolve(dirname, '../../node_modules/victory-native/src/index.ts'),
331331
// Required for @shopify/react-native-skia web support
332332
'react-native/Libraries/Image/AssetRegistry': false,
333+
// Use legacy build of pdfjs-dist to support older browsers
334+
'pdfjs-dist$': path.resolve(dirname, '../../node_modules/pdfjs-dist/legacy/build/pdf.mjs'),
333335
// Module alias for web
334336
// https://webpack.js.org/configuration/resolve/#resolvealias
335337
'@assets': path.resolve(dirname, '../../assets'),

contributingGuides/BUGZERO_CHECKLIST.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# BugZero Checklist:
22

3-
- [ ] **[Contributor]** The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
3+
- [ ] **[Contributor]** The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
44

5-
Link to comment:
5+
Link to the comment on the PR:
6+
Link to the comment on the Issue:
67

78
- [ ] **[Contributor]** If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in [#expensify-open-source](https://app.slack.com/client/E047TPA624F/C01GTK53T8Q) has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
89

0 commit comments

Comments
 (0)