Merge pull request Expensify#66230 from software-mansion-labs/war-in/bump-react-native-performance

[No QA] Bump `react-native-performance` & fix hybridApp soft exceptions

Author: Julesssss

ios/Podfile.lock

@@ -2139,7 +2139,7 @@ PODS:
     - ReactCommon/turbomodule/bridging
     - ReactCommon/turbomodule/core
     - Yoga
-  - react-native-performance (5.1.0):
+  - react-native-performance (5.1.4):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -3816,7 +3816,7 @@ SPEC CHECKSUMS:
   react-native-netinfo: 6aa96b58130ce8de834c2f6c00878b69703d9e10
   react-native-pager-view: 21fa9c2dc9ba43370132b0c996eaeaefd2be4be0
   react-native-pdf: 65f142fbddbb7ef4ee51c5e3bf2a03d24f507c11
-  react-native-performance: 025cfdaddd31efee1e334b15924a04f5497d9702
+  react-native-performance: 1e0b1e3a80e665fb392c658d5639d26a015efbdd
   react-native-plaid-link-sdk: d82ea6d7f8065e82d9ea8cf6abf3cf4914da8b5c
   react-native-release-profiler: 4dbd61f2e1ebc2b11cfa5a03511bbc88fda5a25b
   react-native-safe-area-context: 00d03dc688ba86664be66f9e3f203fc7d747d899

package-lock.json

@@ -181,7 +181,7 @@
     "react-native-onyx": "^2.0.117",
     "react-native-pager-view": "6.5.3",
     "react-native-pdf": "6.7.3",
-    "react-native-performance": "^5.1.0",
+    "react-native-performance": "^5.1.4",
     "react-native-permissions": "^5.4.0",
     "react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#07d60d78d4772d47afd7a744940fc6b6d1881806",
     "react-native-plaid-link-sdk": "11.11.0",

package.json

@@ -0,0 +1,18 @@
+# `react-native-performance` patches
+
+### [react-native-performance+5.1.4+001+fix-soft-crash-by-checking-for-active-react-instance.patch](react-native-performance+5.1.4+001+fix-soft-crash-by-checking-for-active-react-instance.patch)
+
+- Reason:
+
+    ```
+    `react-native-performance` emits some events using `RCTDeviceEventEmitter` on Android. Emitter should be used only after react instance has been created.
+    Otherwise, soft exception is thrown:
+      
+      ```
+      raiseSoftException(callWithExistingReactInstance(callFunctionOnModule("RCTDeviceEventEmitter", "emit"))): Execute: reactInstance is null. Dropping work.
+      ```
+    ```
+
+- Upstream PR/issue: https://github.com/oblador/react-native-performance/pull/117
+- E/App issue: https://github.com/Expensify/App/issues/66231
+- PR introducing patch: https://github.com/Expensify/App/pull/66230

patches/react-native-performance+5.1.0+001+bridgeless.patch

@@ -0,0 +1,28 @@
+diff --git a/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java b/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
+index 4a187bb..66c94ee 100644
+--- a/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
++++ b/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
+@@ -187,7 +187,7 @@ public class PerformanceModule extends ReactContextBaseJavaModule implements Tur
+             WritableMap map = Arguments.fromBundle(metric.getDetail());
+             params.putMap("detail", map);
+         }
+-        if (getReactApplicationContext().hasActiveCatalystInstance()) {
++        if (getReactApplicationContext().hasActiveReactInstance()) {
+             getReactApplicationContext()
+                     .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+                     .emit("metric", params);
+@@ -202,9 +202,11 @@ public class PerformanceModule extends ReactContextBaseJavaModule implements Tur
+             WritableMap map = Arguments.fromBundle(mark.getDetail());
+             params.putMap("detail", map);
+         }
+-        getReactApplicationContext()
+-                .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+-                .emit("mark", params);
++        if (getReactApplicationContext().hasActiveReactInstance()) {
++            getReactApplicationContext()
++                    .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
++                    .emit("mark", params);
++        }
+     }
+ 
+     @Override