Skip to content

Commit 3c02538

Browse files
committed
Fix offline indicator jumping on dismiss keyboard on mweb safari
1 parent aec6e76 commit 3c02538

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/pages/workspace/WorkspacePageWithSections.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@ type WorkspacePageWithSectionsProps = WithPolicyAndFullscreenLoadingProps &
9292

9393
/** Content to be added as modal */
9494
modals?: ReactNode;
95+
96+
/** Whether to use the maxHeight (true) or use the 100% of the height (false) */
97+
shouldEnableMaxHeight?: boolean;
9598
};
9699

97100
function fetchData(policyID: string | undefined, skipVBBACal?: boolean) {
@@ -118,6 +121,7 @@ function WorkspacePageWithSections({
118121
shouldShowLoading = true,
119122
shouldShowOfflineIndicatorInWideScreen = false,
120123
shouldShowNonAdmin = false,
124+
shouldEnableMaxHeight = true,
121125
headerContent,
122126
testID,
123127
shouldShowNotFoundPage = false,
@@ -200,7 +204,7 @@ function WorkspacePageWithSections({
200204
<ScreenWrapper
201205
enableEdgeToEdgeBottomSafeAreaPadding
202206
shouldEnablePickerAvoiding={false}
203-
shouldEnableMaxHeight
207+
shouldEnableMaxHeight={shouldEnableMaxHeight}
204208
testID={testID ?? 'WorkspacePageWithSections'}
205209
shouldShowOfflineIndicator={!shouldShow}
206210
shouldShowOfflineIndicatorInWideScreen={shouldShowOfflineIndicatorInWideScreen && !shouldShow}

src/pages/workspace/timeTracking/WorkspaceTimeTrackingPage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ function WorkspaceTimeTrackingPage({route}: WorkspaceTimeTrackingPageProps) {
3737
route={route}
3838
icon={illustrations.Clock}
3939
addBottomSafeAreaPadding
40+
shouldEnableMaxHeight={false}
4041
>
4142
<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
4243
<WorkspaceTimeTrackingDefaultRateSection policyID={policyID} />

0 commit comments

Comments
 (0)