fix tests after refactor

Author: TMisiukiewicz

tests/unit/hooks/useRestoreWorkspacesTabOnNavigate.test.ts

@@ -1,7 +1,9 @@
 import {renderHook} from '@testing-library/react-native';
 import getPathFromState from '@libs/Navigation/helpers/getPathFromState';
 import Navigation from '@libs/Navigation/Navigation';
+import navigationRef from '@libs/Navigation/navigationRef';
 import NAVIGATORS from '@src/NAVIGATORS';
+import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import SCREENS from '@src/SCREENS';
 import createRandomPolicy from '../../utils/collections/policies';
@@ -19,9 +21,6 @@ jest.mock('@hooks/useResponsiveLayout', () => () => mockResponsiveLayout());
 
 jest.mock('@hooks/useCurrentUserPersonalDetails', () => () => ({login: 'test@example.com'}));
 
-const mockRootState = jest.fn((): unknown => undefined);
-jest.mock('@hooks/useRootNavigationState', () => (selector: (state: unknown) => unknown) => selector(mockRootState()));
-
 const mockUseOnyx = jest.fn().mockReturnValue([undefined]);
 jest.mock('@hooks/useOnyx', () => (key: unknown, opts?: unknown) => mockUseOnyx(key, opts) as unknown[]);
 
@@ -35,6 +34,9 @@ jest.mock('@libs/Navigation/navigationRef', () => ({
 
 jest.mock('@react-navigation/native', () => ({
     findFocusedRoute: jest.fn(() => ({name: 'some-screen'})),
+    StackActions: {
+        pop: jest.fn((count: number) => ({type: 'POP', payload: {count}})),
+    },
 }));
 
 jest.mock('@libs/Navigation/Navigation', () => ({
@@ -55,6 +57,7 @@ jest.mock('@libs/PolicyUtils', () => ({
 const fakePolicyID = 'ABCD1234';
 const mockPolicy = {...createRandomPolicy(0), id: fakePolicyID};
 const mockedGetPathFromState = getPathFromState as jest.MockedFunction<typeof getPathFromState>;
+const mockedGetRootState = navigationRef.getRootState as jest.Mock;
 
 const useRestoreWorkspacesTabOnNavigate = (require('@hooks/useRestoreWorkspacesTabOnNavigate') as {default: () => () => void}).default;
 
@@ -63,9 +66,9 @@ const PolicyUtils = require('@libs/PolicyUtils') as {shouldShowPolicy: jest.Mock
 const lastVisitedTabPathUtils = require('@libs/Navigation/helpers/lastVisitedTabPathUtils') as {getWorkspacesTabStateFromSessionStorage: jest.Mock};
 
 function setupOnyxForPolicy() {
-    mockUseOnyx.mockImplementation((_key: unknown, opts?: {selector?: (data: unknown) => unknown}) => {
-        if (opts?.selector) {
-            return [opts.selector({[`policy_${fakePolicyID}`]: mockPolicy})];
+    mockUseOnyx.mockImplementation((key: unknown) => {
+        if (key === ONYXKEYS.COLLECTION.POLICY) {
+            return [{[`${ONYXKEYS.COLLECTION.POLICY}${fakePolicyID}`]: mockPolicy}];
         }
         return [undefined];
     });
@@ -100,13 +103,14 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
         PolicyUtils.shouldShowPolicy.mockReturnValue(true);
         PolicyUtils.isPendingDeletePolicy.mockReturnValue(false);
         mockedGetPathFromState.mockReset();
+        mockedGetRootState.mockReturnValue({routes: []});
     });
 
     it('restores to the last visited workspace when re-entering the Workspaces tab', () => {
         setupOnyxForPolicy();
         const restoredPath = `/workspaces/${fakePolicyID}` as const;
         mockedGetPathFromState.mockReturnValue(restoredPath);
-        mockRootState.mockReturnValue(
+        mockedGetRootState.mockReturnValue(
             buildStateWithUserOnDifferentTab([
                 {
                     name: NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR,
@@ -122,7 +126,7 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
     });
 
     it('falls back to the workspaces list when no workspace was previously visited', () => {
-        mockRootState.mockReturnValue({
+        mockedGetRootState.mockReturnValue({
             routes: [
                 {
                     name: NAVIGATORS.TAB_NAVIGATOR,
@@ -141,7 +145,7 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
         PolicyUtils.isPendingDeletePolicy.mockReturnValue(true);
 
         setupOnyxForPolicy();
-        mockRootState.mockReturnValue(
+        mockedGetRootState.mockReturnValue(
             buildStateWithUserOnDifferentTab([
                 {
                     name: NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR,
@@ -162,7 +166,7 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
         setupOnyxForPolicy();
         const restoredPath = `/workspaces/${fakePolicyID}/workflows` as const;
         mockedGetPathFromState.mockReturnValue(restoredPath);
-        mockRootState.mockReturnValue(
+        mockedGetRootState.mockReturnValue(
             buildStateWithUserOnDifferentTab([
                 {
                     name: NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR,
@@ -188,9 +192,7 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
     // TabNavigator instance still alive in the root stack to recover the user's last workspace sub-page.
     it('reads workspace state from an older TabNavigator instance when the topmost one is empty', () => {
         setupOnyxForPolicy();
-        const restoredPath = `/workspaces/${fakePolicyID}/workflows` as const;
-        mockedGetPathFromState.mockReturnValue(restoredPath);
-        mockRootState.mockReturnValue({
+        mockedGetRootState.mockReturnValue({
             routes: [
                 // Older TabNavigator: still holds the workspace state with WORKFLOWS focused.
                 {
@@ -233,15 +235,18 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
         const {result} = renderHook(() => useRestoreWorkspacesTabOnNavigate());
         result.current();
 
-        expect(Navigation.navigate).toHaveBeenCalledWith(restoredPath);
+        // The older TabNavigator is reached via StackActions.pop (popping the newer empty one off the root stack),
+        // not via a fresh Navigation.navigate. Verify dispatch was called with a POP action.
+        expect(navigationRef.dispatch).toHaveBeenCalledWith(expect.objectContaining({type: 'POP'}));
+        expect(Navigation.navigate).not.toHaveBeenCalled();
     });
 
     // On narrow layouts (mobile), the URL-based restore is skipped: we always land on the workspace's
     // initial page so the user can navigate inward via the side-list — matches mobile UX and the docs.
     it('falls back to the workspace initial page on narrow layouts even when a sub-page is focused', () => {
         mockResponsiveLayout.mockReturnValue({shouldUseNarrowLayout: true});
         setupOnyxForPolicy();
-        mockRootState.mockReturnValue(
+        mockedGetRootState.mockReturnValue(
             buildStateWithUserOnDifferentTab([
                 {
                     name: NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR,
@@ -269,7 +274,7 @@ describe('useRestoreWorkspacesTabOnNavigate', () => {
         setupOnyxForPolicy();
         const restoredPath = `/workspaces/${fakePolicyID}/workflows` as const;
         mockedGetPathFromState.mockReturnValue(restoredPath);
-        mockRootState.mockReturnValue({
+        mockedGetRootState.mockReturnValue({
             routes: [
                 {
                     name: NAVIGATORS.TAB_NAVIGATOR,