Merge pull request Expensify#65953 from callstack-internal/fix/65849-fix-changing-participant-to-self-dm-v2

fix: lint errors from pull 65898

Author: lakchote

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersGroupByPage.tsx

@@ -29,7 +29,7 @@ function SearchFiltersGroupByPage() {
             keyForList: groupOption.value,
             isSelected: selectedItem === groupOption.value,
         }));
-    }, [selectedItem, translate]);
+    }, [selectedItem]);
 
     const updateSelectedItem = useCallback((type: ListItem<SearchGroupBy>) => {
         setSelectedItem(type?.keyForList ?? undefined);

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

@@ -32,7 +32,7 @@ function SearchFiltersTypePage() {
             keyForList: typeOption.value,
             isSelected: selectedItem === typeOption.value,
         }));
-    }, [allPolicies, selectedItem, session?.email, translate]);
+    }, [allPolicies, selectedItem, session?.email]);
 
     const updateSelectedItem = useCallback((type: ListItem<SearchDataTypes>) => {
         setSelectedItem(type?.keyForList ?? CONST.SEARCH.DATA_TYPES.EXPENSE);

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

@@ -351,15 +351,16 @@ function IOURequestStepConfirmation({
         transaction?.isFromGlobalCreate,
         transaction?.receipt?.isTestReceipt,
         transaction?.receipt?.isTestDriveReceipt,
+        transaction?.participants,
         transaction?.participantsAutoAssigned,
         transaction?.reportID,
-        transaction?.participants,
         requestType,
         iouType,
         initialTransactionID,
         reportID,
-        participantsAutoAssignedFromRoute,
         isMovingTransactionFromTrackExpense,
+        participantsAutoAssignedFromRoute,
+        isBetaEnabled,
     ]);
 
     const navigateToAddReceipt = useCallback(() => {

src/pages/iou/request/step/IOURequestStepParticipants.tsx

@@ -173,7 +173,7 @@ function IOURequestStepParticipants({
                 Navigation.navigate(iouConfirmationPageRoute);
             }
         });
-    }, [action, backTo, selfDMReport, selfDMReportID, transactions, initialTransactionID, waitForKeyboardDismiss]);
+    }, [selfDMReportID, transactions, action, initialTransactionID, waitForKeyboardDismiss, isBetaEnabled, iouType, selfDMReport, isActivePolicyRequest, backTo]);
 
     const addParticipant = useCallback(
         (val: Participant[]) => {

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

@@ -486,9 +486,6 @@ function IOURequestStepScan({
             report,
             reportNameValuePairs,
             iouType,
-            initialTransaction?.participants,
-            initialTransaction?.currency,
-            initialTransaction?.reportID,
             activePolicy,
             initialTransactionID,
             navigateToConfirmationPage,
@@ -498,9 +495,13 @@ function IOURequestStepScan({
             currentUserPersonalDetails?.login,
             currentUserPersonalDetails.accountID,
             reportID,
+            initialTransaction?.currency,
+            initialTransaction?.participants,
+            initialTransaction?.reportID,
             transactionTaxCode,
             transactionTaxAmount,
             policy,
+            selfDMReportID,
         ],
     );
 

src/pages/workspace/accounting/PolicyAccountingPage.tsx

@@ -514,7 +514,7 @@ function PolicyAccountingPage({policy}: PolicyAccountingPageProps) {
         }
         // Else, display the following and link to their Concierge DM.
         return [translate('workspace.accounting.talkToConcierge'), conciergeReportID];
-    }, [account, conciergeReportID, translate]);
+    }, [account?.accountManagerAccountID, account?.accountManagerReportID, conciergeReportID, policy?.chatReportIDAdmins, translate]);
 
     return (
         <AccessOrNotFoundWrapper