Skip to content

Commit 3d9d631

Browse files
committed
clean up removeTransaction function
1 parent 0614d4e commit 3d9d631

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

src/components/Search/SearchContext.tsx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -142,28 +142,27 @@ function SearchContextProvider({children}: ChildrenProps) {
142142
}
143143
const selectedTransactionIDs = searchContextData.selectedTransactionIDs;
144144

145-
if (selectedTransactionIDs.length === 0) {
146-
const removedTransaction = searchContextData.selectedTransactions[transactionID];
145+
if (!isEmptyObject(searchContextData.selectedTransactions)) {
147146
const newSelectedTransactions = Object.entries(searchContextData.selectedTransactions).reduce((acc, [key, value]) => {
148147
if (key === transactionID) {
149148
return acc;
150149
}
151150
acc[key] = value;
152151
return acc;
153152
}, {} as SelectedTransactions);
154-
const reportIDOwningTransaction = removedTransaction?.reportID;
153+
155154
setSearchContextData((prevState) => ({
156155
...prevState,
157156
selectedTransactions: newSelectedTransactions,
158-
selectedReports: prevState.selectedReports.filter((report) => report.reportID !== reportIDOwningTransaction),
159157
}));
160-
return;
161158
}
162159

163-
setSearchContextData((prevState) => ({
164-
...prevState,
165-
selectedTransactionIDs: selectedTransactionIDs.filter((ID) => transactionID !== ID),
166-
}));
160+
if (selectedTransactionIDs.length > 0) {
161+
setSearchContextData((prevState) => ({
162+
...prevState,
163+
selectedTransactionIDs: selectedTransactionIDs.filter((ID) => transactionID !== ID),
164+
}));
165+
}
167166
},
168167
[searchContextData.selectedTransactionIDs, searchContextData.selectedTransactions],
169168
);

0 commit comments

Comments
 (0)