Merge pull request Expensify#64990 from linhvovan29546/fix/64237-remove-hasError-prop

fix: remove hasError prop

Author: roryabraham

src/components/ReceiptEmptyState.tsx

@@ -10,9 +10,6 @@ import * as Expensicons from './Icon/Expensicons';
 import PressableWithoutFeedback from './Pressable/PressableWithoutFeedback';
 
 type ReceiptEmptyStateProps = {
-    /** Whether or not there is an error */
-    hasError?: boolean;
-
     /** Callback to be called on onPress */
     onPress?: () => void;
 
@@ -32,7 +29,7 @@ type ReceiptEmptyStateProps = {
 };
 
 // Returns an SVG icon indicating that the user should attach a receipt
-function ReceiptEmptyState({hasError = false, onPress, disabled = false, isThumbnail = false, isInMoneyRequestView = false, shouldUseFullHeight = false, style}: ReceiptEmptyStateProps) {
+function ReceiptEmptyState({onPress, disabled = false, isThumbnail = false, isInMoneyRequestView = false, shouldUseFullHeight = false, style}: ReceiptEmptyStateProps) {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
     const theme = useTheme();
@@ -43,7 +40,6 @@ function ReceiptEmptyState({hasError = false, onPress, disabled = false, isThumb
         styles.justifyContentCenter,
         styles.moneyRequestViewImage,
         isThumbnail && !isInMoneyRequestView ? styles.moneyRequestAttachReceiptThumbnail : styles.moneyRequestAttachReceipt,
-        hasError && styles.borderColorDanger,
         shouldUseFullHeight && styles.receiptEmptyStateFullHeight,
         style,
     ];

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -564,7 +564,6 @@ function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = fals
                         style={styles.mv3}
                     >
                         <ReceiptEmptyState
-                            hasError={hasErrors}
                             disabled={!canEditReceipt}
                             onPress={() => {
                                 if (!transaction?.transactionID || !report?.reportID) {