Skip to content

Commit 42f3fb9

Browse files
Fix Android staging deploy: build AAB for Release, revert appName
Two changes to fix staging Android deploys via Rock: 1. Pass aab: true to Rock for Release builds. Google Play requires AAB, and Fastlane used bundleRelease to produce it. The Rock migration inadvertently switched to assembleRelease (APK only). Additionally, Fullstory's Gradle plugin relocates the APK from build/outputs to build/intermediates, causing Rock's artifact detection to fail. Building AAB sidesteps this since Fullstory doesn't relocate bundles. 2. Revert the ineffective appName: 'app' from rock.config.mjs. The Mobile-Expensify Android project has no app/ subdirectory (it IS the app module), so the RN CLI config validation rejects it and APP_NAME stays empty regardless. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 4e25cc3 commit 42f3fb9

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/buildAndroid.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ jobs:
154154
FORCE_NATIVE_BUILD: ${{ inputs.force-native-build == 'true' && github.run_id || '' }}
155155
with:
156156
variant: ${{ inputs.variant }}
157+
aab: ${{ inputs.variant == 'Release' }}
157158
sign: true
158159
re-sign: true
159160
ad-hoc: ${{ inputs.variant == 'Adhoc' }}

rock.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default {
1919
bundler: pluginMetro(),
2020
platforms: {
2121
ios: platformIOS({sourceDir: isHybrid ? './Mobile-Expensify/iOS' : './ios'}),
22-
android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android', appName: 'app'}),
22+
android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android'}),
2323
},
2424
fingerprint: {
2525
env: ['USE_WEB_PROXY', 'PUSHER_DEV_SUFFIX', 'SECURE_NGROK_URL', 'NGROK_URL', 'USE_NGROK', 'FORCE_NATIVE_BUILD'],

0 commit comments

Comments
 (0)