fix lint

Author: luacmartins

.github/actions/javascript/authorChecklist/categories/newComponentCategory.ts

@@ -91,7 +91,7 @@ async function detectReactComponentInFile(filename: string): Promise<boolean | u
     };
     try {
         const {data} = await GithubUtils.octokit.repos.getContent(params);
-        const content = nodeBase64ToUtf8('content' in data ? data?.content ?? '' : '');
+        const content = nodeBase64ToUtf8('content' in data ? (data?.content ?? '') : '');
         return detectReactComponent(content, filename);
     } catch (error) {
         console.error('An unknown error occurred with the GitHub API: ', error, params);

.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts

@@ -13,27 +13,30 @@ function getTestBuildMessage(): string {
         [inputs[3]]: 'Web',
     };
 
-    const result = inputs.reduce((acc, platform) => {
-        const input = core.getInput(platform, {required: false});
+    const result = inputs.reduce(
+        (acc, platform) => {
+            const input = core.getInput(platform, {required: false});
 
-        if (!input) {
-            acc[platform] = {link: 'N/A', qrCode: 'N/A'};
-            return acc;
-        }
+            if (!input) {
+                acc[platform] = {link: 'N/A', qrCode: 'N/A'};
+                return acc;
+            }
 
-        const isSuccess = input === 'success';
+            const isSuccess = input === 'success';
 
-        const link = isSuccess ? core.getInput(`${platform}_LINK`) : '❌ FAILED ❌';
-        const qrCode = isSuccess
-            ? `![${names[platform]}](https://api.qrserver.com/v1/create-qr-code/?size=120x120&data=${link})`
-            : `The QR code can't be generated, because the ${names[platform]} build failed`;
+            const link = isSuccess ? core.getInput(`${platform}_LINK`) : '❌ FAILED ❌';
+            const qrCode = isSuccess
+                ? `![${names[platform]}](https://api.qrserver.com/v1/create-qr-code/?size=120x120&data=${link})`
+                : `The QR code can't be generated, because the ${names[platform]} build failed`;
 
-        acc[platform] = {
-            link,
-            qrCode,
-        };
-        return acc;
-    }, {} as Record<TupleToUnion<typeof inputs>, {link: string; qrCode: string}>);
+            acc[platform] = {
+                link,
+                qrCode,
+            };
+            return acc;
+        },
+        {} as Record<TupleToUnion<typeof inputs>, {link: string; qrCode: string}>,
+    );
 
     const message = `:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:
 | Android :robot:  | iOS :apple: |

.github/libs/sanitizeStringForJSONParse.ts

@@ -8,7 +8,7 @@ const replacer = (str: string): string =>
         '\r': '\\r',
         '\f': '\\f',
         '"': '\\"',
-    }[str] ?? '');
+    })[str] ?? '';
 
 /**
  * Replace any characters in the string that will break JSON.parse for our Git Log output

src/CONST.ts

@@ -3643,11 +3643,14 @@ const CONST = {
         SELF_SELECT: '__predefined_selfSelect',
     },
 
-    EXPENSIFY_EMAILS_OBJECT: Object.entries(EMAIL).reduce((prev, [, email]) => {
-        // eslint-disable-next-line no-param-reassign
-        prev[email] = true;
-        return prev;
-    }, {} as Record<string, boolean>),
+    EXPENSIFY_EMAILS_OBJECT: Object.entries(EMAIL).reduce(
+        (prev, [, email]) => {
+            // eslint-disable-next-line no-param-reassign
+            prev[email] = true;
+            return prev;
+        },
+        {} as Record<string, boolean>,
+    ),
     EXPENSIFY_EMAILS: [
         EMAIL.ACCOUNTING,
         EMAIL.ACCOUNTS_PAYABLE,
@@ -5507,15 +5510,12 @@ const CONST = {
                     type: 'addAccountingIntegration',
                     autoCompleted: false,
                     mediaAttributes: {
-                        [`${CLOUDFRONT_URL}/${
-                            connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.netsuite]
-                        }`]: `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_netsuite.png" data-expensify-width="1920" data-expensify-height="1080"`,
-                        [`${CLOUDFRONT_URL}/${
-                            connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.quickbooksOnline]
-                        }`]: `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_qbo.png" data-expensify-width="1920" data-expensify-height="1080"`,
-                        [`${CLOUDFRONT_URL}/${
-                            connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.xero]
-                        }`]: `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_xero.png" data-expensify-width="1920" data-expensify-height="1080"`,
+                        [`${CLOUDFRONT_URL}/${connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.netsuite]}`]:
+                            `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_netsuite.png" data-expensify-width="1920" data-expensify-height="1080"`,
+                        [`${CLOUDFRONT_URL}/${connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.quickbooksOnline]}`]:
+                            `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_qbo.png" data-expensify-width="1920" data-expensify-height="1080"`,
+                        [`${CLOUDFRONT_URL}/${connectionsVideoPaths[ONBOARDING_ACCOUNTING_MAPPING.xero]}`]:
+                            `data-expensify-thumbnail-url="${CLOUDFRONT_URL}/images/walkthrough-connect_to_xero.png" data-expensify-width="1920" data-expensify-height="1080"`,
                     },
                     title: ({integrationName, workspaceAccountingLink}) => `Connect to [${integrationName}](${workspaceAccountingLink})`,
                     description: ({integrationName, workspaceAccountingLink}) =>

src/components/Avatar.tsx

@@ -120,7 +120,7 @@ function Avatar({
                         src={avatarSource}
                         height={iconSize}
                         width={iconSize}
-                        fill={imageError ? iconColors?.fill ?? theme.offline : iconColors?.fill ?? fill}
+                        fill={imageError ? (iconColors?.fill ?? theme.offline) : (iconColors?.fill ?? fill)}
                         additionalStyles={[StyleUtils.getAvatarBorderStyle(size, type), iconColors, iconAdditionalStyles]}
                     />
                 </View>

src/components/Button/index.tsx

@@ -327,7 +327,7 @@ function Button(
                             <View style={[styles.mr2, !text && styles.mr0, iconStyles]}>
                                 <Icon
                                     src={icon}
-                                    fill={isHovered ? iconHoverFill ?? defaultFill : iconFill ?? defaultFill}
+                                    fill={isHovered ? (iconHoverFill ?? defaultFill) : (iconFill ?? defaultFill)}
                                     small={small}
                                     medium={medium}
                                     large={large}
@@ -342,7 +342,7 @@ function Button(
                             {!isSplitButton ? (
                                 <Icon
                                     src={iconRight}
-                                    fill={isHovered ? iconHoverFill ?? defaultFill : iconFill ?? defaultFill}
+                                    fill={isHovered ? (iconHoverFill ?? defaultFill) : (iconFill ?? defaultFill)}
                                     small={small}
                                     medium={medium}
                                     large={large}
@@ -351,7 +351,7 @@ function Button(
                             ) : (
                                 <Icon
                                     src={iconRight}
-                                    fill={isHovered ? iconHoverFill ?? defaultFill : iconFill ?? defaultFill}
+                                    fill={isHovered ? (iconHoverFill ?? defaultFill) : (iconFill ?? defaultFill)}
                                     small={small}
                                     medium={medium}
                                     large={large}

src/components/CardPreview.tsx

@@ -22,7 +22,7 @@ type CardPreviewProps = CardPreviewOnyxProps;
 function CardPreview({privatePersonalDetails, session}: CardPreviewProps) {
     const styles = useThemeStyles();
     const {legalFirstName, legalLastName} = privatePersonalDetails ?? {};
-    const cardHolder = legalFirstName && legalLastName ? `${legalFirstName} ${legalLastName}` : session?.email ?? '';
+    const cardHolder = legalFirstName && legalLastName ? `${legalFirstName} ${legalLastName}` : (session?.email ?? '');
 
     return (
         <View style={styles.walletCard}>

src/components/Composer/implementation/index.tsx

@@ -289,28 +289,24 @@ function Composer(
         onClear(currentText);
     }, [onClear, onSelectionChange]);
 
-    useImperativeHandle(
-        ref,
-        () => {
-            const textInputRef = textInput.current;
-            if (!textInputRef) {
-                throw new Error('textInputRef is not available. This should never happen and indicates a developer error.');
-            }
+    useImperativeHandle(ref, () => {
+        const textInputRef = textInput.current;
+        if (!textInputRef) {
+            throw new Error('textInputRef is not available. This should never happen and indicates a developer error.');
+        }
 
-            return {
-                ...textInputRef,
-                // Overwrite clear with our custom implementation, which mimics how the native TextInput's clear method works
-                clear,
-                // We have to redefine these methods as they are inherited by prototype chain and are not accessible directly
-                blur: () => textInputRef.blur(),
-                focus: () => textInputRef.focus(),
-                get scrollTop() {
-                    return textInputRef.scrollTop;
-                },
-            };
-        },
-        [clear],
-    );
+        return {
+            ...textInputRef,
+            // Overwrite clear with our custom implementation, which mimics how the native TextInput's clear method works
+            clear,
+            // We have to redefine these methods as they are inherited by prototype chain and are not accessible directly
+            blur: () => textInputRef.blur(),
+            focus: () => textInputRef.focus(),
+            get scrollTop() {
+                return textInputRef.scrollTop;
+            },
+        };
+    }, [clear]);
 
     const handleKeyPress = useCallback(
         (e: NativeSyntheticEvent<TextInputKeyPressEventData>) => {

src/components/ConfirmContent.tsx

@@ -177,7 +177,7 @@ function ConfirmContent({
                         <View style={[shouldCenterIcon ? styles.justifyContentCenter : null, styles.flexRow, styles.mb3]}>
                             <Icon
                                 src={iconSource}
-                                fill={iconFill === false ? undefined : iconFill ?? theme.icon}
+                                fill={iconFill === false ? undefined : (iconFill ?? theme.icon)}
                                 width={iconWidth}
                                 height={iconHeight}
                                 additionalStyles={iconAdditionalStyles}

src/components/FlatList/index.tsx

@@ -57,7 +57,7 @@ function MVCPFlatList<TItem>({maintainVisibleContentPosition, horizontal = false
         if (!scrollRef.current) {
             return 0;
         }
-        return horizontal ? getScrollableNode(scrollRef.current)?.scrollLeft ?? 0 : getScrollableNode(scrollRef.current)?.scrollTop ?? 0;
+        return horizontal ? (getScrollableNode(scrollRef.current)?.scrollLeft ?? 0) : (getScrollableNode(scrollRef.current)?.scrollTop ?? 0);
     }, [horizontal]);
 
     const getContentView = useCallback(() => getScrollableNode(scrollRef.current)?.childNodes[0], []);