Merge branch 'main' into alberto-PRLink

Author: Gonals

.github/workflows/test.yml

@@ -31,10 +31,6 @@ jobs:
       - name: Setup Node
         uses: ./.github/actions/composite/setupNode
 
-      - name: Get number of CPU cores
-        id: cpu-cores
-        uses: SimenB/github-actions-cpu-cores@31e91de0f8654375a21e8e83078be625380e2b18
-
       - name: Cache Jest cache
         id: cache-jest-cache
         # v5.0.1

Mobile-Expensify

@@ -111,8 +111,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009036200
-        versionName "9.3.62-0"
+        versionCode 1009036204
+        versionName "9.3.62-4"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

android/app/build.gradle

@@ -130,6 +130,9 @@ const metro = {
         production: {
             plugins: [['transform-remove-console', {exclude: ['error', 'warn']}]],
         },
+        test: {
+            plugins: ['@babel/plugin-transform-dynamic-import'],
+        },
     },
 };
 

babel.config.js

@@ -282,7 +282,7 @@ Since our codebase is very complex, it results in a large DOM tree rendered for
 
 One of the most common issues is related to modals, popovers, and tooltips — elements that may appear on the screen. The problem is that they are usually present in the DOM tree even when initially invisible. Because of this, the initial render time of a screen may increase, ultimately slowing down the app.
 
-The solution is better control of invisible elements, making sure they are not included in the first render. This can be done, e.g., by a simple `return null`, smart usage of `lazy loading`, the `useTransition` hook, or the `<Deferred />` component.
+The solution is better control of invisible elements, making sure they are not included in the first render. This can be done, e.g., by a simple `return null`, smart usage of `lazy loading`, the `useTransition` hook, or the [`<NavigationDeferredMount />`](/src/components/NavigationDeferredMount.tsx) component. `<NavigationDeferredMount />` gates a heavy subtree behind navigation transition completion via `TransitionTracker`, rendering a cheap `placeholder` until the nav animation has finished, then mounting its `children` inside `startTransition` — ideal for heavy subtrees (e.g. report headers, page-level secondary actions) mounted during navigation transitions that pull many `useOnyx` subscriptions or heavy hooks but don't need to be interactive on first render.
 
 Another issue worth mentioning is unnecessary code execution, especially for elements that are never shown on a specific platform. In theory, we separate the logic between platforms by using index.tsx/index.native.tsx files, but sometimes platform-specific logic may slip in, causing unnecessary execution. For example, this may happen when logic specific to a wide layout (applicable only for web) is included.
 
@@ -294,6 +294,7 @@ Examples:
 - [PopoverWithMeasuredContent optimization for mobile](https://github.com/Expensify/App/pull/68223) - returns early to avoid unnecessary calculations
 - [Reduce confirm modal initial render count](https://github.com/Expensify/App/pull/67518) - returns early to reduce first load cost
 - [Do not render PopoverMenu until it gets opened](https://github.com/Expensify/App/pull/67877) - adds a wrapper to control if `PopoverMenu` should be rendered
+- [Defer mount of MoneyReportHeaderSecondaryActions](https://github.com/Expensify/App/pull/88522) - introduces `NavigationDeferredMount` and uses it to defer the "More" dropdown subtree (20+ `useOnyx` subscriptions) until the navigation transition completes
 
 # Proposing Performance Improvements
 

contributingGuides/PERFORMANCE.md

@@ -571,9 +571,7 @@ When you change the function id argument type to allow `undefined`, check if it
 
 ```diff
 function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = false, updatedTransaction, isFromReviewDuplicates = false}: MoneyRequestViewProps) {
-    const [parentReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`, {
-        canEvict: false,
-    });
+    const [parentReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`);
 -   const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? '-1'];
 +   const parentReportAction = parentReportActions?.[report?.parentReportActionID];
 ```

contributingGuides/STYLE.md

@@ -35,17 +35,7 @@ Different platforms come with varying storage capacities and Onyx has a way to g
 
 **To flag a key as safe for removal:**
 - Add the key to the `evictableKeys` option in `Onyx.init(options)`
-- Implement `canEvict` in the Onyx config for each component subscribing to a key
-- The key will only be deleted when all subscribers return `true` for `canEvict`
-
-Example:
-```js
-Onyx.init({
-    evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS],
-});
-
-const [reportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {canEvict: !isActiveReport});
-```
+- A least recently accessed key will only be deleted when an Onyx operation retries after failing.
 
 ## Onyx Derived Values
 

contributingGuides/philosophies/ONYX-DATA-MANAGEMENT.md

@@ -912,6 +912,7 @@
         "Zürcher",
         "CARDFROZEN",
         "CARDUNFROZEN",
+        "backgrounded",
         "Kolkata"
     ],
     "ignorePaths": [

cspell.json

@@ -2,14 +2,16 @@
 title: Avoiding common scams
 description: Learn how to recognize and avoid common phishing scams that pretend to be from Expensify, including fake phone calls and emails asking for your Magic Code.
 keywords: [Expensify scam, phishing, Magic Code, security, login code, avoid fraud, suspicious email, fake call, fraud prevention]
+internalScope: Audience is all Expensify members. Covers identifying and responding to scams involving Magic Codes. Does not cover account recovery or dispute workflows.
 ---
-<div id="expensify-classic" markdown="1">
 
-# How to avoid scams pretending to be from Expensify
+# Avoiding common scams
 
 Some scammers try to impersonate Expensify by sending fake emails or calling you directly, often asking for your **Magic Code** (your login code). These scams are designed to trick you into giving up access to your Expensify account.
 
-This guide explains what these scams look like, how to spot them, and what to do if you think you've been targeted.
+This article explains how these scams work, how to recognize them, and what actions to take.
+
+**Note:**  Expensify will never call you asking for login codes, passwords, or payment information. If you receive such a call, it's a scam.
 
 ---
 
@@ -21,21 +23,17 @@ The **Magic Code** is a one-time login code Expensify emails or texts to you whe
 
 ---
 
-## Common scams to watch out for
-
-Here are the most common types of scams we've seen targeting Expensify members:
-
-### 1. Phone call scams requesting your Magic Code
+## How to recognize phone call scams pretending to be Expensify
 
 - The scammer claims to be from Expensify and needs your Magic Code to verify your account.
 - They may spoof a legitimate phone number to make it seem more convincing.
 - Some scammers may create a sense of urgency (e.g., “We detected suspicious activity on your account.”)
 
-**If someone calls you asking for your Magic Code, hang up immediately.**
+**If you receive this type of call, hang up.**
 
 ---
 
-### 2. Phishing emails and texts requesting you use their link to login to Expensify
+## How to recognize phishing emails or texts pretending to be Expensify
 
 - Emails and text messages often look like they’re from Expensify or Visa, but the sender address is likely not from an expensify.com email address.
 - These emails and text messages may have links that lead to a fake login page, prompt you to reset your password, or ask you to reply with your Magic Code.
@@ -45,32 +43,46 @@ Here are the most common types of scams we've seen targeting Expensify members:
 
 ---
 
-## How to stay safe
-
-Here’s how you can protect your Expensify account:
+## How to protect your Expensify account
 
 - **Never share your Magic Code** — not over the phone, not by email, not via text.
 - **Don’t click suspicious links** — always verify the sender’s email address.
-- **Use 2FA** (two-factor authentication) to add an extra layer of security.
-- **If in doubt, message Concierge** directly from within the Expensify app.
+- **Use two-factor authentication (2FA)** - this adds an extra layer of security to your account. 
+- **If in doubt, message Concierge**  - reach out directly from within the Expensify app.
+
+[Learn how to enable two-factor authentication](/articles/expensify-classic/settings/Two-Factor-Authentication). 
+
+---
+
+## What to do if you receive a Magic Code you didn't request
+
+If you receive a Magic Code email but didn’t try to log in, this does not necessarily mean your account has been compromised. It can happen for a variety of reasons, such as someone mistyping an email address. 
+
+Here's what to do:
+
+1. **Do not share the code with anyone** — simply ignore or delete the email.
+2. **Do not click any links** in the email. 
+3. **Consider enabling [two-factor authentication](/articles/expensify-classic/settings/Two-Factor-Authentication)** for extra account security.
+
+**Note:** You do not need to lock your account just because you received an unexpected Magic Code. Only lock your account if you believe someone has gained access to your email account or if you shared your Magic Code with someone.
 
 ---
 
 ## What to do if you shared your Magic Code
 
 If you accidentally gave someone your Magic Code, act fast:
 
-1. **[Lock your Expensify account](https://help.expensify.com/articles/expensify-classic/settings/Report-Suspicious-Activity)** immediately to block unauthorized access.
+1. **[Lock your Expensify account](/articles/expensify-classic/settings/Report-Suspicious-Activity)** immediately to block unauthorized access.
 2. **Contact Concierge** from a safe device and explain the situation.
-3. **[Enable two-factor authentication](https://help.expensify.com/articles/expensify-classic/settings/Two-Factor-Authentication)** to protect your account going forward.
+3. **[Enable two-factor authentication](/articles/expensify-classic/settings/Two-Factor-Authentication)** to protect your account going forward.
 
 ---
 
 ## How to report phishing and lock your account
 
 If you believe your account has been targeted or compromised:
 
-1. **[Lock your Expensify account](https://help.expensify.com/articles/expensify-classic/settings/Report-Suspicious-Activity)** immediately to block unauthorized access.
+1. **[Lock your Expensify account](/articles/expensify-classic/settings/Report-Suspicious-Activity)** immediately to block unauthorized access.
 2. **Message Concierge immediately** via [email](mailto:concierge@expensify.com), or from within the Expensify app (web or mobile).
 3. Let us know if you’ve received a suspicious message or phone call.
 4. Our team will work to secure your account.
@@ -90,9 +102,12 @@ Expensify uses Magic Codes instead of passwords to simplify login while keeping
 
 Legitimate Expensify emails always come from an address ending in **@expensify.com** or **@team.expensify.com**. If you’re unsure, don’t click any links — just log into the Expensify app directly and message Concierge.
 
+## I received a Magic Code I didn't request. Is my account compromised?
+
+No. Receiving an unrequested Magic Code does not mean your account is compromised. It most likely means someone entered your email address by mistake when trying to log in. As long as you don't share the code with anyone, your account is safe. You can simply ignore or delete the email. If you want extra protection, enable [two-factor authentication](/articles/expensify-classic/settings/Two-Factor-Authentication).
+
 ## Can Expensify call me?
 
 Expensify will **never** call you asking for login codes, passwords, or payment information. If you receive such a call, it's a scam.
 
-</div>
 

docs/articles/expensify-classic/settings/Avoiding-common-scams.md

@@ -0,0 +1,78 @@
+---
+title: Accounting Search Shortcuts
+description: Use the Accounting search shortcuts on the Spend page to review expense status, prepare for export, and reconcile transactions with your accounting records.
+keywords: [New Expensify, accounting expensify, reconcile expenses, awaiting export, cash accruals, card accruals, card statements, bank reconciliation, month-end close, search shortcut, accounting shortcut]
+internalScope: Audience is Workspace Admins. Covers using the Accounting section to review expense states and support reconciliation workflows. Does not cover exporting or performing reconciliation in detail.
+---
+
+# Accounting Search Shortcuts
+
+The **Accounting** search shortcuts on the **Spend** page bring together the expense views you need to reconcile your records and close your books. It helps you identify what’s ready to export, what still needs attention, and what should be matched against statements or bank data.
+
+Workspace Admins can use these shortcuts to validate totals, track liabilities, and ensure your expenses align with accounting records before and after export.
+
+---
+
+## Who can use Accounting search shortcuts
+
+Workspace Admins with:
+- Approvals turned on
+- Either reimbursements enabled or at least one card feed connected
+
+---
+
+## How to use the Accounting search shortcuts
+
+1. In the navigation tabs (on the left on web, on the bottom on mobile) select **Spend**. 
+2. In the **Accounting** section, choose a search shortcut based on what you need to review.
+3. Use filters like **Date**, **Feed**, or **Posted** to refine your view.
+4. Review the **Total** in the footer to understand the amount for that view.
+
+Once you’ve reviewed the expenses, you can export them to a CSV if you need to share or work with the data outside of Expensify. Learn how to [export expenses to a CSV](/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses#how-to-export-multiple-expenses).
+
+---
+
+## What each Accounting search shortcut shows you
+
+- **Awaiting export**: Reports that are approved and ready to be exported to your accounting system.
+- **Cash accruals**: Reimbursable expenses that are not yet approved and may need to be accrued.
+- **Card accruals**: Imported card expenses that are not yet approved and may need to be accrued.
+- **Card statements**: Credit card expenses grouped by statement periods to help you reconcile against your card statement.
+- **Bank reconciliation**: Reimbursed reports and Expensify Card settlement withdrawals to help you match transactions with your bank data.
+
+---
+
+## What happens after you review expenses with Accounting search shortcuts
+
+ - You can identify reports that are ready to export to your accounting system.
+ - You can account for unapproved expenses as accruals before closing a period.
+ - You can verify imported credit card expense totals against statements and bank data.
+ - You can ensure your records are complete before and after reconciliation.
+
+---
+
+# FAQ
+
+## Why don’t I see all Accounting search shortcuts?
+
+Some search shortcuts only appear when the required features are enabled:
+
+ - **Cash accruals** requires reimbursements
+ - **Card accruals** and **Card statements** require a card feed
+ - **Bank reconciliation** requires a validated business bank account. 
+
+If a feature isn’t enabled, its shortcut won’t appear.
+
+## Can I export expenses from the Accounting search shortcuts?
+
+Yes. You can export expenses from any shortcut to a CSV file if you need to use the data outside of Expensify.
+
+
+## Why does the total change when I apply filters?
+
+The **Total** reflects only the expenses shown in your current shortcut. Changing filters like **Date**, **Feed,** or **Posted** will update the total based on those results.
+
+## Can I filter Card accruals by feed?
+
+Yes. If you have more than one card feed, a **Feed** filter will appear so you can review one account at a time.
+