Skip to content

Commit 4a14376

Browse files
authored
Merge pull request Expensify#65998 from nabi-ebrahimi/fix/reload-resets-to-workspace-bg
fix: reset background to workspace on page reload in Track Expense
2 parents 7e39d6a + d048c57 commit 4a14376

6 files changed

Lines changed: 17 additions & 8 deletions

File tree

src/ROUTES.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -602,10 +602,11 @@ const ROUTES = {
602602
},
603603
MONEY_REQUEST_STEP_CONFIRMATION: {
604604
route: ':action/:iouType/confirmation/:transactionID/:reportID/:backToReport?',
605-
getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string | undefined, backToReport?: string, participantsAutoAssigned?: boolean) =>
606-
`${action as string}/${iouType as string}/confirmation/${transactionID}/${reportID}/${backToReport ?? ''}${
607-
participantsAutoAssigned ? '?participantsAutoAssigned=true' : ''
608-
}` as const,
605+
getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string | undefined, backToReport?: string, participantsAutoAssigned?: boolean, backTo?: string) =>
606+
getUrlWithBackToParam(
607+
`${action as string}/${iouType as string}/confirmation/${transactionID}/${reportID}/${backToReport ?? ''}${participantsAutoAssigned ? '?participantsAutoAssigned=true' : ''}`,
608+
backTo,
609+
),
609610
},
610611
MONEY_REQUEST_STEP_AMOUNT: {
611612
route: ':action/:iouType/amount/:transactionID/:reportID/:pageIndex?/:backToReport?',

src/libs/Navigation/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1411,7 +1411,7 @@ type MoneyRequestNavigatorParamList = {
14111411
transactionID: string;
14121412
reportID: string;
14131413
pageIndex?: string;
1414-
backTo?: string;
1414+
backTo?: Routes;
14151415
participantsAutoAssigned?: string;
14161416
backToReport?: string;
14171417
};

src/libs/ReportUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9910,7 +9910,7 @@ function createDraftTransactionAndNavigateToParticipantSelector(
99109910
}
99119911

99129912
if (actionName === CONST.IOU.ACTION.SHARE) {
9913-
Navigation.navigate(ROUTES.MONEY_REQUEST_ACCOUNTANT.getRoute(actionName, CONST.IOU.TYPE.SUBMIT, transactionID, reportID, undefined));
9913+
Navigation.navigate(ROUTES.MONEY_REQUEST_ACCOUNTANT.getRoute(actionName, CONST.IOU.TYPE.SUBMIT, transactionID, reportID, Navigation.getActiveRoute()));
99149914
return;
99159915
}
99169916

src/pages/iou/request/step/IOURequestStepAccountant.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function IOURequestStepAccountant({
3939
return;
4040
}
4141

42-
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID, undefined, action));
42+
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID, Navigation.getActiveRoute(), action));
4343
}, [iouType, transactionID, reportID, action, currentUserLogin]);
4444

4545
const navigateBack = useCallback(() => {

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function IOURequestStepConfirmation({
8080
report: reportReal,
8181
reportDraft,
8282
route: {
83-
params: {iouType, reportID, transactionID: initialTransactionID, action, participantsAutoAssigned: participantsAutoAssignedFromRoute, backToReport},
83+
params: {iouType, reportID, transactionID: initialTransactionID, action, participantsAutoAssigned: participantsAutoAssignedFromRoute, backToReport, backTo},
8484
},
8585
transaction: initialTransaction,
8686
isLoadingTransaction,
@@ -296,6 +296,10 @@ function IOURequestStepConfirmation({
296296
}, [transactionIDs, requestType, defaultCategory, policy?.id]);
297297

298298
const navigateBack = useCallback(() => {
299+
if (backTo) {
300+
Navigation.goBack(backTo);
301+
return;
302+
}
299303
// If the action is categorize and there's no policies other than personal one, we simply call goBack(), i.e: dismiss the whole flow together
300304
// We don't need to subscribe to policy_ collection as we only need to check on the latest collection value
301305
if (action === CONST.IOU.ACTION.CATEGORIZE) {
@@ -357,6 +361,7 @@ function IOURequestStepConfirmation({
357361
reportID,
358362
isMovingTransactionFromTrackExpense,
359363
participantsAutoAssignedFromRoute,
364+
backTo,
360365
]);
361366

362367
const navigateToAddReceipt = useCallback(() => {

src/pages/iou/request/step/IOURequestStepParticipants.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,9 @@ function IOURequestStepParticipants({
261261
iouType === CONST.IOU.TYPE.CREATE ? CONST.IOU.TYPE.SUBMIT : iouType,
262262
initialTransactionID,
263263
newReportID,
264+
undefined,
265+
undefined,
266+
action === CONST.IOU.ACTION.SHARE ? Navigation.getActiveRoute() : undefined,
264267
);
265268

266269
const route = isCategorizing

0 commit comments

Comments
 (0)