Skip to content

Commit 4dbbb24

Browse files
mountinymountiny
authored
Merge pull request Expensify#65906 from callstack-internal/bugfix/gh-actions-build
2 parents db7fd7b + abcf176 commit 4dbbb24

22 files changed

Lines changed: 423 additions & 394 deletions

File tree

‎.github/.eslintrc.js‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,16 @@ module.exports = {
77
'no-await-in-loop': 'off',
88
'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
99
'no-continue': 'off',
10-
'no-restricted-imports': 'off',
10+
'no-restricted-imports': [
11+
'error',
12+
{
13+
patterns: [
14+
{
15+
group: ['@src/**'],
16+
message: 'Do not import files from src/ directory as they can break the GH Actions build script.',
17+
},
18+
],
19+
},
20+
],
1121
},
1222
};

‎.github/actions/javascript/authorChecklist/index.js‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -15622,9 +15622,9 @@ const utils_1 = __nccwpck_require__(3030);
1562215622
const plugin_paginate_rest_1 = __nccwpck_require__(4193);
1562315623
const plugin_throttling_1 = __nccwpck_require__(9968);
1562415624
const request_error_1 = __nccwpck_require__(537);
15625-
const EmptyObject_1 = __nccwpck_require__(8227);
15626-
const arrayDifference_1 = __importDefault(__nccwpck_require__(7034));
15625+
const arrayDifference_1 = __importDefault(__nccwpck_require__(7532));
1562715626
const CONST_1 = __importDefault(__nccwpck_require__(9873));
15627+
const isEmptyObject_1 = __nccwpck_require__(6497);
1562815628
class GithubUtils {
1562915629
static internalOctokit;
1563015630
/**
@@ -15815,7 +15815,7 @@ class GithubUtils {
1581515815
static generateStagingDeployCashBodyAndAssignees(tag, PRList, verifiedPRList = [], deployBlockers = [], resolvedDeployBlockers = [], resolvedInternalQAPRs = [], isFirebaseChecked = false, isGHStatusChecked = false) {
1581615816
return this.fetchAllPullRequests(PRList.map((pr) => this.getPullRequestNumberFromURL(pr)))
1581715817
.then((data) => {
15818-
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, EmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
15818+
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, isEmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
1581915819
return Promise.all(internalQAPRs.map((pr) => this.getPullRequestMergerLogin(pr.number).then((mergerLogin) => ({ url: pr.html_url, mergerLogin })))).then((results) => {
1582015820
// The format of this map is following:
1582115821
// {
@@ -15845,7 +15845,7 @@ class GithubUtils {
1584515845
issueBody += '\r\n\r\n';
1584615846
}
1584715847
// Internal QA PR list
15848-
if (!(0, EmptyObject_1.isEmptyObject)(internalQAPRMap)) {
15848+
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
1584915849
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
1585015850
issueBody += '**Internal QA:**\r\n';
1585115851
Object.keys(internalQAPRMap).forEach((URL) => {
@@ -16127,38 +16127,25 @@ exports["default"] = GithubUtils;
1612716127

1612816128
/***/ }),
1612916129

16130-
/***/ 8534:
16130+
/***/ 7532:
1613116131
/***/ ((__unused_webpack_module, exports) => {
1613216132

1613316133
"use strict";
1613416134

1613516135
Object.defineProperty(exports, "__esModule", ({ value: true }));
1613616136
/**
16137-
* Like _.some but for promises. It short-circuts after a promise fulfills with a value that passes the test implemented by provided function.
16138-
* It does not wait for the other promises to complete once it finds one.
16139-
* If no promise passes the provided test, it rejects.
16137+
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
16138+
* It returns an array of items that are in the first array but not in the second array.
1614016139
*/
16141-
function promiseSome(promises, callbackFn) {
16142-
return new Promise((resolve, reject) => {
16143-
for (const p of promises) {
16144-
Promise.resolve(p)
16145-
.then((res) => {
16146-
if (!callbackFn(res)) {
16147-
return;
16148-
}
16149-
resolve(true);
16150-
})
16151-
.catch(() => { });
16152-
}
16153-
Promise.allSettled(promises).then(() => reject());
16154-
});
16140+
function arrayDifference(array1, array2) {
16141+
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
1615516142
}
16156-
exports["default"] = promiseSome;
16143+
exports["default"] = arrayDifference;
1615716144

1615816145

1615916146
/***/ }),
1616016147

16161-
/***/ 8227:
16148+
/***/ 6497:
1616216149
/***/ ((__unused_webpack_module, exports) => {
1616316150

1616416151
"use strict";
@@ -16173,20 +16160,33 @@ exports.isEmptyObject = isEmptyObject;
1617316160

1617416161
/***/ }),
1617516162

16176-
/***/ 7034:
16163+
/***/ 8534:
1617716164
/***/ ((__unused_webpack_module, exports) => {
1617816165

1617916166
"use strict";
1618016167

1618116168
Object.defineProperty(exports, "__esModule", ({ value: true }));
1618216169
/**
16183-
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
16184-
* It returns an array of items that are in the first array but not in the second array.
16170+
* Like _.some but for promises. It short-circuts after a promise fulfills with a value that passes the test implemented by provided function.
16171+
* It does not wait for the other promises to complete once it finds one.
16172+
* If no promise passes the provided test, it rejects.
1618516173
*/
16186-
function arrayDifference(array1, array2) {
16187-
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
16174+
function promiseSome(promises, callbackFn) {
16175+
return new Promise((resolve, reject) => {
16176+
for (const p of promises) {
16177+
Promise.resolve(p)
16178+
.then((res) => {
16179+
if (!callbackFn(res)) {
16180+
return;
16181+
}
16182+
resolve(true);
16183+
})
16184+
.catch(() => { });
16185+
}
16186+
Promise.allSettled(promises).then(() => reject());
16187+
});
1618816188
}
16189-
exports["default"] = arrayDifference;
16189+
exports["default"] = promiseSome;
1619016190

1619116191

1619216192
/***/ }),

‎.github/actions/javascript/awaitStagingDeploys/index.js‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -12396,9 +12396,9 @@ const utils_1 = __nccwpck_require__(3030);
1239612396
const plugin_paginate_rest_1 = __nccwpck_require__(4193);
1239712397
const plugin_throttling_1 = __nccwpck_require__(9968);
1239812398
const request_error_1 = __nccwpck_require__(537);
12399-
const EmptyObject_1 = __nccwpck_require__(8227);
12400-
const arrayDifference_1 = __importDefault(__nccwpck_require__(7034));
12399+
const arrayDifference_1 = __importDefault(__nccwpck_require__(7532));
1240112400
const CONST_1 = __importDefault(__nccwpck_require__(9873));
12401+
const isEmptyObject_1 = __nccwpck_require__(6497);
1240212402
class GithubUtils {
1240312403
static internalOctokit;
1240412404
/**
@@ -12589,7 +12589,7 @@ class GithubUtils {
1258912589
static generateStagingDeployCashBodyAndAssignees(tag, PRList, verifiedPRList = [], deployBlockers = [], resolvedDeployBlockers = [], resolvedInternalQAPRs = [], isFirebaseChecked = false, isGHStatusChecked = false) {
1259012590
return this.fetchAllPullRequests(PRList.map((pr) => this.getPullRequestNumberFromURL(pr)))
1259112591
.then((data) => {
12592-
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, EmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
12592+
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, isEmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
1259312593
return Promise.all(internalQAPRs.map((pr) => this.getPullRequestMergerLogin(pr.number).then((mergerLogin) => ({ url: pr.html_url, mergerLogin })))).then((results) => {
1259412594
// The format of this map is following:
1259512595
// {
@@ -12619,7 +12619,7 @@ class GithubUtils {
1261912619
issueBody += '\r\n\r\n';
1262012620
}
1262112621
// Internal QA PR list
12622-
if (!(0, EmptyObject_1.isEmptyObject)(internalQAPRMap)) {
12622+
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
1262312623
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
1262412624
issueBody += '**Internal QA:**\r\n';
1262512625
Object.keys(internalQAPRMap).forEach((URL) => {
@@ -12899,6 +12899,39 @@ class GithubUtils {
1289912899
exports["default"] = GithubUtils;
1290012900

1290112901

12902+
/***/ }),
12903+
12904+
/***/ 7532:
12905+
/***/ ((__unused_webpack_module, exports) => {
12906+
12907+
"use strict";
12908+
12909+
Object.defineProperty(exports, "__esModule", ({ value: true }));
12910+
/**
12911+
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
12912+
* It returns an array of items that are in the first array but not in the second array.
12913+
*/
12914+
function arrayDifference(array1, array2) {
12915+
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
12916+
}
12917+
exports["default"] = arrayDifference;
12918+
12919+
12920+
/***/ }),
12921+
12922+
/***/ 6497:
12923+
/***/ ((__unused_webpack_module, exports) => {
12924+
12925+
"use strict";
12926+
12927+
Object.defineProperty(exports, "__esModule", ({ value: true }));
12928+
exports.isEmptyObject = void 0;
12929+
function isEmptyObject(obj) {
12930+
return Object.keys(obj ?? {}).length === 0;
12931+
}
12932+
exports.isEmptyObject = isEmptyObject;
12933+
12934+
1290212935
/***/ }),
1290312936

1290412937
/***/ 9438:
@@ -12954,39 +12987,6 @@ function promiseDoWhile(condition, action) {
1295412987
exports.promiseDoWhile = promiseDoWhile;
1295512988

1295612989

12957-
/***/ }),
12958-
12959-
/***/ 8227:
12960-
/***/ ((__unused_webpack_module, exports) => {
12961-
12962-
"use strict";
12963-
12964-
Object.defineProperty(exports, "__esModule", ({ value: true }));
12965-
exports.isEmptyObject = void 0;
12966-
function isEmptyObject(obj) {
12967-
return Object.keys(obj ?? {}).length === 0;
12968-
}
12969-
exports.isEmptyObject = isEmptyObject;
12970-
12971-
12972-
/***/ }),
12973-
12974-
/***/ 7034:
12975-
/***/ ((__unused_webpack_module, exports) => {
12976-
12977-
"use strict";
12978-
12979-
Object.defineProperty(exports, "__esModule", ({ value: true }));
12980-
/**
12981-
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
12982-
* It returns an array of items that are in the first array but not in the second array.
12983-
*/
12984-
function arrayDifference(array1, array2) {
12985-
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
12986-
}
12987-
exports["default"] = arrayDifference;
12988-
12989-
1299012990
/***/ }),
1299112991

1299212992
/***/ 9491:

‎.github/actions/javascript/checkAndroidStatus/index.js‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -737115,9 +737115,9 @@ const utils_1 = __nccwpck_require__(73030);
737115737115
const plugin_paginate_rest_1 = __nccwpck_require__(64193);
737116737116
const plugin_throttling_1 = __nccwpck_require__(9968);
737117737117
const request_error_1 = __nccwpck_require__(10537);
737118-
const EmptyObject_1 = __nccwpck_require__(58227);
737119-
const arrayDifference_1 = __importDefault(__nccwpck_require__(97034));
737118+
const arrayDifference_1 = __importDefault(__nccwpck_require__(17532));
737120737119
const CONST_1 = __importDefault(__nccwpck_require__(29873));
737120+
const isEmptyObject_1 = __nccwpck_require__(86497);
737121737121
class GithubUtils {
737122737122
static internalOctokit;
737123737123
/**
@@ -737308,7 +737308,7 @@ class GithubUtils {
737308737308
static generateStagingDeployCashBodyAndAssignees(tag, PRList, verifiedPRList = [], deployBlockers = [], resolvedDeployBlockers = [], resolvedInternalQAPRs = [], isFirebaseChecked = false, isGHStatusChecked = false) {
737309737309
return this.fetchAllPullRequests(PRList.map((pr) => this.getPullRequestNumberFromURL(pr)))
737310737310
.then((data) => {
737311-
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, EmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
737311+
const internalQAPRs = Array.isArray(data) ? data.filter((pr) => !(0, isEmptyObject_1.isEmptyObject)(pr.labels.find((item) => item.name === CONST_1.default.LABELS.INTERNAL_QA))) : [];
737312737312
return Promise.all(internalQAPRs.map((pr) => this.getPullRequestMergerLogin(pr.number).then((mergerLogin) => ({ url: pr.html_url, mergerLogin })))).then((results) => {
737313737313
// The format of this map is following:
737314737314
// {
@@ -737338,7 +737338,7 @@ class GithubUtils {
737338737338
issueBody += '\r\n\r\n';
737339737339
}
737340737340
// Internal QA PR list
737341-
if (!(0, EmptyObject_1.isEmptyObject)(internalQAPRMap)) {
737341+
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
737342737342
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
737343737343
issueBody += '**Internal QA:**\r\n';
737344737344
Object.keys(internalQAPRMap).forEach((URL) => {
@@ -737620,35 +737620,35 @@ exports["default"] = GithubUtils;
737620737620

737621737621
/***/ }),
737622737622

737623-
/***/ 58227:
737623+
/***/ 17532:
737624737624
/***/ ((__unused_webpack_module, exports) => {
737625737625

737626737626
"use strict";
737627737627

737628737628
Object.defineProperty(exports, "__esModule", ({ value: true }));
737629-
exports.isEmptyObject = void 0;
737630-
function isEmptyObject(obj) {
737631-
return Object.keys(obj ?? {}).length === 0;
737629+
/**
737630+
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
737631+
* It returns an array of items that are in the first array but not in the second array.
737632+
*/
737633+
function arrayDifference(array1, array2) {
737634+
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
737632737635
}
737633-
exports.isEmptyObject = isEmptyObject;
737636+
exports["default"] = arrayDifference;
737634737637

737635737638

737636737639
/***/ }),
737637737640

737638-
/***/ 97034:
737641+
/***/ 86497:
737639737642
/***/ ((__unused_webpack_module, exports) => {
737640737643

737641737644
"use strict";
737642737645

737643737646
Object.defineProperty(exports, "__esModule", ({ value: true }));
737644-
/**
737645-
* This function is an equivalent of _.difference, it takes two arrays and returns the difference between them.
737646-
* It returns an array of items that are in the first array but not in the second array.
737647-
*/
737648-
function arrayDifference(array1, array2) {
737649-
return [array1, array2].reduce((a, b) => a.filter((c) => !b.includes(c)));
737647+
exports.isEmptyObject = void 0;
737648+
function isEmptyObject(obj) {
737649+
return Object.keys(obj ?? {}).length === 0;
737650737650
}
737651-
exports["default"] = arrayDifference;
737651+
exports.isEmptyObject = isEmptyObject;
737652737652

737653737653

737654737654
/***/ }),

‎.github/actions/javascript/checkDeployBlockers/checkDeployBlockers.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import * as core from '@actions/core';
33
import CONST from '@github/libs/CONST';
44
import GithubUtils from '@github/libs/GithubUtils';
5-
import {isEmptyObject} from '@src/types/utils/EmptyObject';
5+
import {isEmptyObject} from '@github/libs/isEmptyObject';
66

77
const run = function (): Promise<void> {
88
const issueNumber = Number(core.getInput('ISSUE_NUMBER', {required: true}));

0 commit comments

Comments
 (0)