Merge pull request Expensify#64865 from bernhardoj/fix/64556-double-modal-hide

Fix double modal hide callbacks when unmounted

Author: mollfpr

src/components/Modal/BaseModal.tsx

@@ -109,8 +109,6 @@ function BaseModal(
     const insets = useSafeAreaInsets();
 
     const isVisibleRef = useRef(isVisible);
-    const hideModalCallbackRef = useRef<(callHideCallback: boolean) => void>(undefined);
-
     const wasVisible = usePrevious(isVisible);
 
     const uniqueModalId = useMemo(() => modalId ?? ComposerFocusManager.getId(), [modalId]);
@@ -160,22 +158,6 @@ function BaseModal(
         };
     }, [isVisible, wasVisible, onClose, type]);
 
-    useEffect(() => {
-        hideModalCallbackRef.current = hideModal;
-    }, [hideModal]);
-
-    useEffect(
-        () => () => {
-            // Only trigger onClose and setModalVisibility if the modal is unmounting while visible.
-            if (!isVisibleRef.current) {
-                return;
-            }
-            hideModalCallbackRef.current?.(true);
-        },
-        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-        [],
-    );
-
     const handleShowModal = useCallback(() => {
         if (shouldSetModalVisibility) {
             setModalVisibility(true, type);